Page MenuHomePhabricator

Add image captions in “Suggested edits”
Closed, ResolvedPublic4 Story Points

Description

Conceptual descriptions

  • Unlock criteria:
    • 3 non-reverted edits of image captions
  • Feed: Show files in card feed that have unstructured descriptions on Commons.
    • To discuss: Preferably, we are displaying captions that are associated with Wikipedia articles in the user’s current language. After all, it’s the *Wikipedia* Android app (according to @Mholloway, indexing will take several weeks, so this is more something for version 2 - these enhancements are tracked in T224232)
  • Card information architecture (output as plain text), from Commons file page
    • File name
    • Author, if not available, display Artist
    • Date
    • Source
    • [Show more structured data based on available space)
  • Images are displayed in 16:9 ratio
  • Tapping the card leads editors to the Add image caption screen, in which the unstructured description will be displayed.
  • UI enhancements:
    • Removing info icon from input field since it’s available at various other places, we don’t want to interrupt the flow.
    • Add a microphone button/icon to the input field to promote voice input
    • Truncate bottom of card in a improved way, as showcased here.
    • Draggable bottom sheet (Details in T223130)

Visuals

👉Zeplin: T224051 | Add image captions within “Suggested edits”

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2019, 5:30 PM
schoenbaechler renamed this task from Caption addition to Add image captions (within “Suggested edits”).May 22 2019, 1:27 PM
schoenbaechler renamed this task from Add image captions (within “Suggested edits”) to Add image captions within “Suggested edits”.May 22 2019, 1:52 PM
schoenbaechler renamed this task from Add image captions within “Suggested edits” to Add image captions to “Suggested edits”.May 22 2019, 5:01 PM
schoenbaechler updated the task description. (Show Details)
schoenbaechler added a subscriber: Mholloway.
schoenbaechler renamed this task from Add image captions to “Suggested edits” to Add image captions in “Suggested edits”.May 22 2019, 5:08 PM
JoeWalsh updated the task description. (Show Details)May 24 2019, 3:06 PM
Johan added a subscriber: Johan.EditedMay 28 2019, 9:06 AM

Would it be possible to use this space for a short explanation, or would that make it too cluttered? How much copy do we have room for?

A few suggestions, to be edited:

"Write a new short caption."

"Write a short caption in your own words."

"Write a short caption in one or two sentences in your own words."

I think "new" really is enough to indicate that this is supposed to be something else than the description but it doesn't explain why we want a new caption. This really isn't obvious. Do we have a good way of explaining this? Have I missed plans we already have? Without contextualisation, we're basically asking people to write descriptions of files that already have descriptions, but not telling them why this is useful.

@Johan, great input and sounds good to me. Let me work on integrating your suggestions.

I would also love to get your input for the “Suggested edits“ support page, which is, let’s formulate it positively, pretty minimalistic right now. Feel free to edit the hell out of this page ;).

CC: @Charlotte and @alexhollender, who shared similar ideas in T223129.

Charlotte triaged this task as Normal priority.May 28 2019, 4:32 PM
Charlotte set the point value for this task to 4.
Charlotte raised the priority of this task from Normal to High.May 28 2019, 4:55 PM
Charlotte added a subscriber: Mholloway.

@schoenbaechler Do you have any preference in mind here for items that do or don't have unstructured captions in the target language, or is that concern specific to the translations endpoint only?

Good question @Mholloway.

I suggest to display items that don’t have an unstructured caption in the target language. The Add image captions task will take care of “porting” unstructured to structured captions.

A related thought: Would it make sense to publish user translations to both structured and unstructured caption in the target language? Or is that a technical and legal nightmare? (CC’ing @Charlotte about the “legal nightmare” part). If this suggestion is too far away from being feasible (Hello reality distortion field), feel free to pretend that you haven’t read it ;).

Good question @Mholloway.
I suggest to display items that don’t have an unstructured caption in the target language. The Add image captions task will take care of “porting” unstructured to structured captions.

Just to be clear, did you mean to link to this ticket? The second sentence seems to contradict the first, so I'm wondering if you were actually talking about translating image captions in the first.

A related thought: Would it make sense to publish user translations to both structured and unstructured caption in the target language? Or is that a technical and legal nightmare? (CC’ing @Charlotte about the “legal nightmare” part). If this suggestion is too far away from being feasible (Hello reality distortion field), feel free to pretend that you haven’t read it ;).

I don't think SDC supports multiple captions per language.

A related thought: Would it make sense to publish user translations to both structured and unstructured caption in the target language? Or is that a technical and legal nightmare? (CC’ing @Charlotte about the “legal nightmare” part). If this suggestion is too far away from being feasible (Hello reality distortion field), feel free to pretend that you haven’t read it ;).

I don't think SDC supports multiple captions per language.

Ah, now I understand your proposal (after a few more gulps of coffee). ;) Yes, publishing to both structured and unstructured (where no unstructured caption yet exists) seems reasonable in principle. On the technical side, I'm not sure if there's an existing API for setting unstructured image metadata, and I kind of doubt it, but that's something I or one of the Android engineers can look into.

Dbrant added a subscriber: Dbrant.May 30 2019, 1:08 PM

Or is that a technical and legal nightmare?

Yes. Let's please restrict editing to structured data for now.

@Mholloway

Just to be clear, did you mean to link to this ticket? The second sentence seems to contradict the first, so I'm wondering if you were actually talking about translating image captions in the first.

Yes, I’m talking about translating image captions in the first sentence.

(after a few more gulps of coffee). ;)

Very much relatable! 🙃

On the technical side, I'm not sure if there's an existing API for setting unstructured image metadata, and I kind of doubt it, but that's something I or one of the Android engineers can look into.

Sounds good! If you come to the conclusion that it’s feasible but it would lead lots of additional work, we need to talk to @Charlotte about timeline!

@Mholloway

On the technical side, I'm not sure if there's an existing API for setting unstructured image metadata, and I kind of doubt it, but that's something I or one of the Android engineers can look into.

Sounds good! If you come to the conclusion that it’s feasible but it would lead lots of additional work, we need to talk to @Charlotte about timeline!

I'm not sure what the user benefit would be to doing this, since we will be changing how we display captions in gallery? Agreed with @Dbrant that we should restrict editing to structured data for v1... and to consider editing unstructured data in the future, there will have to be a good argument in favour of doing the considerable work it would probably require. :)

Yeah, to be clear, I don't think it's worth investing time/effort into infrastructure to do that if it doesn't already exist.

schoenbaechler added a comment.EditedMay 30 2019, 1:53 PM

@Mholloway

Yeah, to be clear, I don't think it's worth investing time/effort into infrastructure to do that if it doesn't already exist.

+1


@Charlotte

I'm not sure what the user benefit would be to doing this, since we will be changing how we display captions in gallery?

There is no user benefit, we would just complete the Commons database with unstructured descriptions. Kind of kill two birds with one stone. But if the future is structured captions anyway for all WMF products, then we shouldn’t bother.

Johan added a comment.May 31 2019, 4:11 AM

I would also love to get your input for the “Suggested edits“ support page, which is, let’s formulate it positively, pretty minimalistic right now. Feel free to edit the hell out of this page ;).

As a start, I've suggested a couple of additions that explain what the feed is and does.

A related thought: Would it make sense to publish user translations to both structured and unstructured caption in the target language? Or is that a technical and legal nightmare

It would sort of undermine our argument that we want the user to think of captions in a different way than descriptions (e.g. shorter), wouldn't it?

@Johan

As a start, I've suggested a couple of additions that explain what the feed is and does.

Thanks!

It would sort of undermine our argument that we want the user to think of captions in a different way than descriptions (e.g. shorter), wouldn't it?

Haven’t thought of it that way but you’re absolutely right.

cooltey added a subscriber: cooltey.

@schoenbaechler I would like to claim and work on this ticket. Is it available now?

Yes @cooltey, please go ahead!

cooltey claimed this task.Jun 10 2019, 4:20 PM
cooltey added a subscriber: schoenbaechler.

Thanks for the work on this @cooltey. Moving the task to QA signoff as all the issues related to this task are listed in T225635, namely 07), 12), 13), 14), 15), 16), 17), 18), 19), 20), 21), 22), 23), 24), 27).

ABorbaWMF added a subscriber: ABorbaWMF.

Looks good to me as an overall test on 2.7.50282-alpha-2019-06-18

Will continue to test in smaller tickets as well.