Compare revision: as a user I want to compare two revisions in my history
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	LGoto
	Jul 23 2019, 6:47 PM

Description

Why are we doing this?

History and dif pages are used by editors and readers to understand how an article has changed over time. For editors, these pages are integral for gathering context around notifications and are key elements in a variety of common workflows.

User story

As a user of the iOS app, I would like to be able to see how an article has changed over time by comparing two different revisions of an article.

Proposed designs

User flows

Selecting Revisions for Comparison@1x.png (648×3 px, 119 KB)

Selecting Revisions for Comparison.pdf37 KBDownload

Selecting a revision

Click through prototype: https://wikimedia.invisionapp.com/share/7JSR4PIXM2H

History screen	History screen with 'compare'	First selected revision	Second selected revision	Attempting to select third revision

Zeplin: https://zpl.io/VQQ9wmm	Zeplin: https://zpl.io/bekLRnm	Zeplin: https://zpl.io/2ZnkWJE	Zeplin: https://zpl.io/bAW4MqP	Zeplin: https://zpl.io/2jYPG4r

Comparing revisions

User education	Top of compare revisions / diff page	Scrolled down on compare revisions / diff page

Zeplin: https://zpl.io/ad1xGjE	Zeplin: https://zpl.io/aN1wMdn	Zeplin: https://zpl.io/bekNRNP

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		LGoto	T216665 As a curating editor I want to be able to see a useable page history and take revert actions
Resolved		• JMinor	T228792 Compare revision: as a user I want to compare two revisions in my history
Resolved		Tsevener	T228793 Add revision comparison ("diff") screen
Resolved		• JMinor	T234930 Diff screen - display moved paragraphs
Declined		Tsevener	T236189 Diff - display intermediate section count in moved paragraphs old location
Resolved		Tsevener	T237445 Diff - alternate patch for returning byteOffsetStart objects from wikidiff2
Resolved		Tsevener	T234931 Diff screen - Show empty state if there are no changes
Resolved		• JMinor	T234934 Diff screen - show error states
Resolved	Spike	Tsevener	T228794 Investigate technical needs for native mobile diffs, including supporting APIs
Resolved		Tsevener	T232231 Update wikidiff2 to output structured data
Resolved		Tsevener	T234096 Add section titles to InlineDiffJSON output in wikidiff2
Resolved		Tsevener	T237417 Diff single revision and compare - RTL audit
Resolved		Mhurd	T237418 Diff single revision and compare - accessibility audit
Resolved		Mhurd	T239176 Allow diff revision cells to be treated as atomic accessibility links
Resolved		Mhurd	T239179 Fix order VoiceOver speaks top of Diff detail view (and Saved screens)
Resolved		• JMinor	T238219 Diff Compare - implement intermediate counts endpoint when ready

Event Timeline

LGoto created this task.Jul 23 2019, 6:47 PM

cmadeo moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v6.4-Seamonkey-On-A-Hoverboard board.Jul 23 2019, 9:02 PM

• JMinor renamed this task from Compare revision: as a user I want to compare two revisions in my history to As a curating editor I want to compare two revisions of an article.Jul 23 2019, 9:22 PM

• JMinor triaged this task as Medium priority.

cmadeo renamed this task from As a curating editor I want to compare two revisions of an article to Compare revision: as a user I want to compare two revisions in my history.Jul 23 2019, 9:43 PM

cmadeo raised the priority of this task from Medium to Needs Triage.

cmadeo updated the task description. (Show Details)

cmadeo moved this task from Needs Design to Design Doing on the iOS-app-v6.4-Seamonkey-On-A-Hoverboard board.

cmadeo merged a task: T208903: Ability to see what changed in an edit (diffs) on iOS app.

cmadeo added subscribers: Remagoxer, Krenair, • alexhollender_WMF.

cmadeo updated the task description. (Show Details)Jul 23 2019, 9:46 PM

Was this issue created after mine? Just wondering.

Edit: indeed it was; I guess you just needed the ability to show the demo?

@Remagoxer yes it was, I just needed to be able to keep track of the child tickets associated with this ticket and both tickets were (I believe) describing the same feature request. We'll be working on this feature soon, so it's helpful to have a single ticket for this work. Feel free to add any information you feel is missing.

@cmadeo ahhhh

Also: minor error in the pic (https://phab.wmfusercontent.org/file/data/rxxgymopspxpkb63zffu/PHID-FILE-n37bj4rad7jg5njlg3dp/375_History_-Compare_revisions.png{F29853676}); it should read “When you compare two different revisions of an article, the differences between them are generated and shown. Only the edit information related to the newest one is shown.”

As a WikiGnome, I felt the need to correct that sentence.

Updated, thanks @Remagoxer!

cmadeo updated the task description. (Show Details)Jul 24 2019, 8:20 PM

cmadeo moved this task from Design Doing to Needs Acceptance Criteria on the iOS-app-v6.4-Seamonkey-On-A-Hoverboard board.

cmadeo merged a task: T228785: As a curating editor I want to select two revisions to compare.Jul 24 2019, 8:27 PM

• JMinor triaged this task as Medium priority.Jul 29 2019, 6:45 PM

• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Jul 29 2019, 6:56 PM

• JMinor moved this task from Needs Acceptance Criteria to Needs Engineering Sync on the iOS-app-v6.4-Seamonkey-On-A-Hoverboard board.Aug 1 2019, 7:48 PM

• JMinor edited projects, added iOS-app-v6.5-Squid-On-A-Tandem-Bike; removed iOS-app-v6.4-Seamonkey-On-A-Hoverboard.Aug 28 2019, 1:52 AM

cmadeo updated the task description. (Show Details)Aug 28 2019, 8:21 PM

Tsevener mentioned this in T232231: Update wikidiff2 to output structured data.Sep 6 2019, 10:01 PM

• JMinor closed subtask T228794: Investigate technical needs for native mobile diffs, including supporting APIs as Resolved.Sep 12 2019, 8:27 PM

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

The following two tasks may be related to this one:

Hi, is there already a task for integrating the new wikidiff2 JSON output format into an API endpoint?

• JMinor moved this task from Ready for Development to Blocked or Waiting on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Oct 29 2019, 6:16 PM

@awight Sorry for the late response - the endpoint was implemented here.

Tsevener moved this task from Blocked or Waiting to Needs Code Review on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 5 2019, 7:22 PM

In T228792#5636215, @Tsevener wrote:

@awight Sorry for the late response - the endpoint was implemented here.

Just idle curiosity, no rush. Thanks for the reply!
I found some example output here: https://en.wikipedia.beta.wmflabs.org/w/rest.php/v1/revision/388864/compare/388866

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 8 2019, 9:17 PM

Tsevener closed subtask T232231: Update wikidiff2 to output structured data as Resolved.Nov 13 2019, 2:41 PM

Tsevener moved this task from Waiting for Build to Needs QA on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 13 2019, 2:45 PM

Tsevener added a subtask: T238219: Diff Compare - implement intermediate counts endpoint when ready.Nov 13 2019, 3:09 PM

Looks good on 6.5.0 (1690)

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 15 2019, 6:03 PM

Mhurd closed subtask T237418: Diff single revision and compare - accessibility audit as Resolved.Nov 26 2019, 11:09 PM

• alexhollender_WMF unsubscribed.Dec 1 2019, 10:36 PM

• JMinor closed subtask T238219: Diff Compare - implement intermediate counts endpoint when ready as Resolved.Dec 2 2019, 6:49 PM

• JMinor closed subtask T237417: Diff single revision and compare - RTL audit as Resolved.Dec 2 2019, 6:51 PM

• JMinor closed subtask T228793: Add revision comparison ("diff") screen as Resolved.

Excellent work all!

	F30144282: 105_History: Compare - Attempt to select third.png
	Aug 28 2019, 8:21 PM

	F30144491: 375_History -Compare revisions 1st time.png
	Aug 28 2019, 8:21 PM

	F30144500: 375_History -Compare revisions (2).png
	Aug 28 2019, 8:21 PM

	F30144279: 104_History: Compare - 2 selected.png
	Aug 28 2019, 8:21 PM

	F30144271: 102_History: Compare - 1 selected.png
	Aug 28 2019, 8:21 PM

	F30144507: 375a_History - Compare revisions - unedited text expanded.png
	Aug 28 2019, 8:21 PM

Compare revision: as a user I want to compare two revisions in my historyClosed, ResolvedPublicActions