Page MenuHomePhabricator
Create Task
Maniphest T231269

All API help links should use `Special:MyLanguage`
Closed, ResolvedPublic
Actions

Assigned To
DannyS712
Authored By
DannyS712
Aug 27 2019, 6:13 AM
Tags
Referenced Files
None
Subscribers
Aklapper
DannyS712
JTannerWMF
kostajh
TheDJ

Description

API modules can include a getHelpUrls function. The url is displayed in multiple places, including within the API help and the API sandbox (if that extension in installed). All such links that point to mediawiki should use https://www.mediawiki.org/wiki/Special:MyLanguage/Help page instead of just https://www.mediawiki.org/wiki/Help page

A codesearch reveals 19 extensions that add help links without using Special:MyLanguage - the search isn't perfect, since it doesn't support negative lookaheads, but it is a starting place, and the scope of this task is to fix those identified.

For clarity, the following extensions will be affected:

Details

SubjectRepoBranchLines +/-
Use `Special:MyLanguage` in API help linksmediawiki/extensions/BounceHandlermaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/GeoDatamaster+2 -2
Use `Special:MyLanguage` in API help linksmediawiki/extensions/UploadWizardmaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/PageViewInfomaster+3 -3
Use `Special:MyLanguage` in API help linksmediawiki/extensions/Jademaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/TextExtractsmaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/ORESmaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/RegexBlockmaster+2 -2
Use `Special:MyLanguage` in API help linksmediawiki/extensions/MobileFrontendmaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/Wikibasemaster+2 -2
Use `Special:MyLanguage` in API help linksmediawiki/extensions/Favoritesmaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/MachineVisionmaster+2 -2
Use `Special:MyLanguage` in API help linksmediawiki/extensions/ApiFeatureUsagemaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/BetaFeaturesmaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/TemplateDatamaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/CheckUsermaster+2 -2
Use `Special:MyLanguage` in API help linksmediawiki/extensions/TimedMediaHandlermaster+2 -2
Use `Special:MyLanguage` in API help linksmediawiki/extensions/Echomaster+5 -5
Use `Special:MyLanguage` in API help linksmediawiki/extensions/Flowmaster+1 -1
Use `Special:MyLanguage` in API help linksmediawiki/extensions/PageAssessmentsmaster+3 -3
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Aug 27 2019, 6:13 AM

Change 532521 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532521

gerritbot added a project: Patch-For-Review.Aug 27 2019, 6:13 AM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Aug 27 2019, 6:25 AM
gerritbot added a comment.Aug 27 2019, 6:33 AM

Change 532524 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageAssessments@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532524

gerritbot added a comment.Aug 27 2019, 6:34 AM

Change 532525 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageViewInfo@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532525

gerritbot added a comment.Aug 27 2019, 6:34 AM

Change 532526 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CheckUser@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532526

gerritbot added a comment.Aug 27 2019, 6:35 AM

Change 532527 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GeoData@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532527

gerritbot added a comment.Aug 27 2019, 6:36 AM

Change 532528 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MachineVision@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532528

gerritbot added a comment.Aug 27 2019, 6:37 AM

Change 532529 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/RegexBlock@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532529

gerritbot added a comment.Aug 27 2019, 6:38 AM

Change 532530 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TimedMediaHandler@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532530

gerritbot added a comment.Aug 27 2019, 6:39 AM

Change 532531 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532531

gerritbot added a comment.Aug 27 2019, 6:40 AM

Change 532532 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ApiFeatureUsage@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532532

gerritbot added a comment.Aug 27 2019, 6:40 AM

Change 532533 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BetaFeatures@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532533

gerritbot added a comment.Aug 27 2019, 6:41 AM

Change 532534 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Favorites@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532534

gerritbot added a comment.Aug 27 2019, 6:41 AM

Change 532535 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532535

gerritbot added a comment.Aug 27 2019, 6:42 AM

Change 532536 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532536

gerritbot added a comment.Aug 27 2019, 6:42 AM

Change 532538 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532538

gerritbot added a comment.Aug 27 2019, 6:43 AM

Change 532539 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ORES@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532539

gerritbot added a comment.Aug 27 2019, 6:44 AM

Change 532540 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TemplateData@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532540

gerritbot added a comment.Aug 27 2019, 6:44 AM

Change 532541 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TextExtracts@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532541

gerritbot added a comment.Aug 27 2019, 6:45 AM

Change 532542 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UploadWizard@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532542

DannyS712 added projects: Notifications, MediaWiki-extensions-PageAssessments, PageViewInfo, CheckUser, GeoData, MachineVision, RegexBlock, TimedMediaHandler, MediaWiki-extensions-WikibaseClient, ApiFeatureUsage, BetaFeatures, StructuredDiscussions, Jade, MobileFrontend, ORES, TemplateData, TextExtracts, UploadWizard.EditedAug 27 2019, 7:21 AM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.

I tagged each of the extensions[1] that is within the scope of this task. For ease of reviewing, I should note:

  • The only changes made are the addition of Special:MyLanguage/[2]
  • Even if the target page is not translated, the link will still work,[3] and if it becomes translated in the future it will then be useful
  • All patches are verified +2 by jenkins, and are double checked for typos[4]

[1] With the exception of favorites, which does not appear to have a phabricator tag
[2] With the exception of MobileFrontEnd, where I had to split the link into 2 lines because it was too long
[3] Example: https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:PageViewInfo
[4] With the exception of the patches for MachineVision and Wikibase, both of which failed tests associated with wikibase - looking at the changes and the error output on the console, it appears that the patches I submitted are unrelated to this error - see T231264

Restricted Application added projects: VisualEditor, Growth-Team, Wikidata, Discovery-Search, Machine-Learning-Team, Community-Tech. · View Herald TranscriptAug 27 2019, 7:21 AM
DannyS712 moved this task from Backlog to Doing on the BetaFeatures board.Aug 27 2019, 7:22 AM
DannyS712 moved this task from Ready to Needs Review/Feedback on the MediaWiki-extensions-PageAssessments board.
DannyS712 updated the task description. (Show Details)Aug 27 2019, 7:26 AM
DannyS712 updated the task description. (Show Details)
kostajh moved this task from Inbox to External on the Growth-Team board.Aug 27 2019, 7:28 AM
kostajh subscribed.

I've merged the patches related to Growth-Team maintained extensions. Thanks @DannyS712

kostajh updated the task description. (Show Details)Aug 27 2019, 7:28 AM
DannyS712 moved this task from General / Unsorted to Patches for review on the CheckUser board.Aug 27 2019, 7:38 AM
DannyS712 moved this task from Backlog to External on the Notifications board.
TheDJ subscribed.Aug 27 2019, 7:39 AM

Nice work @DannyS712 !

DannyS712 added a comment.Aug 27 2019, 7:41 AM
In T231269#5440205, @TheDJ wrote:

Nice work @DannyS712 !

Thanks. I see you have +2 for TimedMediaHandler - can you take a look at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimedMediaHandler/+/532530/ ?

gerritbot added a comment.Aug 27 2019, 7:51 AM

Change 532535 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532535

gerritbot added a comment.Aug 27 2019, 7:51 AM

Change 532521 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532521

gerritbot added a comment.Aug 27 2019, 7:51 AM

Change 532524 merged by jenkins-bot:
[mediawiki/extensions/PageAssessments@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532524

DannyS712 updated the task description. (Show Details)Aug 27 2019, 7:52 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 27 2019, 8:00 AM
Lydia_Pintscher added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Aug 27 2019, 9:55 AM
Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Aug 27 2019, 10:53 AM

Change 532526 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532526

gerritbot added a comment.Aug 27 2019, 10:53 AM

Change 532533 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532533

gerritbot added a comment.Aug 27 2019, 10:53 AM

Change 532530 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532530

gerritbot added a comment.Aug 27 2019, 10:55 AM

Change 532540 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532540

DannyS712 updated the task description. (Show Details)Aug 27 2019, 10:56 AM
gerritbot added a comment.Aug 27 2019, 1:53 PM

Change 532532 merged by jenkins-bot:
[mediawiki/extensions/ApiFeatureUsage@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532532

DannyS712 mentioned this in rEAFU3c9349d0d6c1: Use `Special:MyLanguage` in API help links.Aug 27 2019, 1:55 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.21; 2019-09-03); removed MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 27 2019, 2:00 PM
• Mholloway moved this task from Backlog to Tracking on the MachineVision board.Aug 27 2019, 3:12 PM
gerritbot added a comment.Aug 27 2019, 3:19 PM

Change 532528 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532528

gerritbot added a comment.Aug 27 2019, 4:21 PM

Change 532538 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532538

gerritbot added a comment.Aug 27 2019, 6:56 PM

Change 532539 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532539

gerritbot added a comment.Aug 27 2019, 7:01 PM

Change 532536 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532536

gerritbot added a comment.Aug 27 2019, 7:03 PM

Change 532541 merged by jenkins-bot:
[mediawiki/extensions/TextExtracts@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532541

gerritbot added a comment.Aug 27 2019, 7:06 PM

Change 532525 merged by jenkins-bot:
[mediawiki/extensions/PageViewInfo@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532525

DannyS712 updated the task description. (Show Details)Aug 27 2019, 7:43 PM
gerritbot added a comment.Aug 27 2019, 7:50 PM

Change 532542 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532542

gerritbot added a comment.Aug 27 2019, 8:06 PM

Change 532534 merged by jenkins-bot:
[mediawiki/extensions/Favorites@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532534

DannyS712 updated the task description. (Show Details)Aug 27 2019, 8:07 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 27 2019, 8:08 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 27 2019, 8:33 PM
gerritbot added a comment.Aug 27 2019, 8:38 PM

Change 532531 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532531

DannyS712 triaged this task as Medium priority.Aug 27 2019, 8:49 PM
DannyS712 updated the task description. (Show Details)Aug 27 2019, 9:26 PM
DannyS712 moved this task from Patches for review to Done on the CheckUser board.
DannyS712 moved this task from New & TBD Tickets to Older: Tracking Work by Others on the Community-Tech board.
DannyS712 moved this task from needs triage to Geodata on the Discovery-Search board.
DannyS712 moved this task from Inbox to In Progress on the Jade board.
DannyS712 moved this task from Backlog to External on the StructuredDiscussions board.
DannyS712 moved this task from incoming to in progress on the Wikidata board.
DannyS712 moved this task from To sort to Done on the TimedMediaHandler board.Aug 27 2019, 9:28 PM
gerritbot added a comment.Aug 27 2019, 10:48 PM

Change 532529 merged by jenkins-bot:
[mediawiki/extensions/RegexBlock@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532529

DannyS712 updated the task description. (Show Details)Aug 27 2019, 11:15 PM
DannyS712 mentioned this in rERXB0d2ab2f722ea: Use `Special:MyLanguage` in API help links.Aug 27 2019, 11:55 PM
Halfak moved this task from Unsorted to Backlog/Lift Wing on the Machine-Learning-Team board.Sep 4 2019, 3:42 PM
JTannerWMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Sep 10 2019, 4:02 PM
JTannerWMF subscribed.

It appears someone else is working on this. So the Editing-team is moving this to external.

• alaa_wmde removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 1 2019, 2:50 PM
DannyS712 added a comment.Oct 9 2019, 1:09 AM

@JTannerWMF is Editing-team willing to take a look at the one remaining patch (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GeoData/+/532527/)?

Niharika removed a project: CheckUser.Nov 7 2019, 12:24 AM
gerritbot added a comment.Nov 7 2019, 11:13 AM

Change 549447 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/BounceHandler@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/549447

gerritbot added a comment.Nov 7 2019, 11:34 AM

Change 532527 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/532527

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 7 2019, 12:00 PM
Mvolz closed this task as Resolved.Nov 7 2019, 12:32 PM
Mvolz updated the task description. (Show Details)
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 7 2019, 12:32 PM
DannyS712 removed projects: User-Ryasmeen, Patch-For-Review.Nov 7 2019, 4:30 PM
gerritbot added a comment.Nov 15 2019, 2:06 PM

Change 549447 merged by jenkins-bot:
[mediawiki/extensions/BounceHandler@master] Use Special:MyLanguage in API help links

https://gerrit.wikimedia.org/r/549447

DannyS712 moved this task from Awaiting review and deployment to Resolved (help links) on the User-DannyS712 board.Nov 26 2019, 11:55 AM
kaldari moved this task from Needs Review/Feedback to Done on the MediaWiki-extensions-PageAssessments board.Apr 7 2020, 8:05 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptApr 7 2020, 8:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL