Page MenuHomePhabricator

MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skin
Open, Needs TriagePublicBUG REPORT

Description

The page title e.g. contents of the <title> tag of the main page of Wikimedia projects in the Minerva skin reads “- Project name” instead of just “Project name” (or maybe “Main page - Project name”).

Steps to Reproduce: open the main page of a Wikimedia Project (Wikipedia, Wikinews, etc) in either Mobile Web (m. domain) or with Minerva skin (?useskin=minerva) and check the page title (as visible eg in browser tabs).

Actual Results (Minerva):

image.png (1×1 px, 339 KB)

Developer notes

T265892#6563562

Expected Results (Vector):

image.png (1×1 px, 473 KB)

Developer notes

The issue is the line https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/Skins/SkinMinerva.php#L565

A similar problem exists in T255682 i

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

This bug is not only in Chinese Wikipedia, but in all Wikimedia Project Sites.

toorich renamed this task from Pagetitle on main page of zh.wikipedia in mobile version has an unneeded " - " prefix to Pagetitle on main page of Wikimedia Project Sites in mobile version has an unneeded " - " prefix.Oct 22 2020, 2:59 AM

Has been noticed on dewiki as well. As we have deactivated the mobile "Welcome, USERNAME!", the "– Wikipedia" is displayed also for registered users. It seems like this happened only after last Thursday's update. Before then the title read "Wikipedia – Die freie Enzyklopädie". Please fix it, as it looks quite unprofessional!

toorich raised the priority of this task from Low to Needs Triage.Oct 24 2020, 4:00 AM

So the reason of the problem seems from MediaWiki itself.

@toorich: Please do not reset priority for no reason. Thanks!

Jdlrobson raised the priority of this task from Low to Needs Triage.Oct 26 2020, 4:45 PM
Jdlrobson removed a project: patch-welcome.
Jdlrobson added subscribers: ovasileva, Jdlrobson.

What do you think the priority should be @ovasileva ? Does seem to impact all logged in users.

So why does it happened?

@toorich: Don't know yet. You or someone else still need to find out. That's why this task is still open (see upper left corner).

ovasileva triaged this task as Medium priority.EditedNov 6 2020, 10:51 AM

@toorich - we'll look into it

So why does it happened?

This has been a bug for several years looking at the code, it's just that nobody reported it until now. Fix should hopefully be straightforward.

Is this issue still open? May I work on this?

I can confirm that it still looks like this, yes!

@Helix17 should I assign you?

Sorry, I didn't see your message. Yes sir, please assign it to me, I will get started immediately.

@Jdlrobson sir, I have reproduced the bug as mentioned above by @Aklapper. But I am not able to find where the code is. I have gone through the codebase, but I don't know where to make changes. Can you please help me?

@Helix17: Have you gone through the MinervaNeue codebase and looked where the page title gets set? See also T265892#6563562. (PS: No sirs needed, people's names are fine.)

@Aklapper Thank you, I am going through the codebase right now.

toorich renamed this task from Pagetitle on main page of Wikimedia Project Sites in mobile version has an unneeded " - " prefix to MediaWiki:Pagetitle-view-mainpage doesn't working in mobile version.Jul 11 2021, 2:09 PM
toorich renamed this task from MediaWiki:Pagetitle-view-mainpage doesn't working in mobile version to `MediaWiki:Pagetitle-view-mainpage` doesn't work in mobile version.Jul 11 2021, 2:12 PM

This error start appears at third-party wiki like BetaWiki.

toorich renamed this task from `MediaWiki:Pagetitle-view-mainpage` doesn't work in mobile version to MediaWiki:Pagetitle-view-mainpage doesn't work in mobile version.Jul 11 2021, 2:16 PM
This comment was removed by toorich.

Please note that @Helix17 was inactive since April 5th.

Can somebody update the description of the task as it is very unclear what the problem is now I look at it a year later. The expected results show the desktop site, but the actual results show the mobile site and this links to an outdated URI.

This bug has a better chance of being addressed if the description is improved.

Does it relate to T255682 in any way?

Jdlrobson changed the task status from Open to Stalled.Jul 13 2021, 7:29 PM
Jdlrobson removed a project: good first task.

I have tried to describe what the original problem was (and still is)

Jdlrobson renamed this task from MediaWiki:Pagetitle-view-mainpage doesn't work in mobile version to MediaWiki:Pagetitle-view-mainpage does not behave the same in mobile version as it does in the desktop version.Jul 13 2021, 8:14 PM
Jdlrobson changed the task status from Stalled to Open.
Jdlrobson updated the task description. (Show Details)

Thanks @XanonymusX I've made a few tweaks to make it clearer what we need to do here.

Almost 1 year later... the bug is still not fixed...

@toorich: If you would like to see a bug fixed, please see https://www.mediawiki.org/wiki/Gerrit/Tutorial and contribute a patch. Age of a ticket is irrelevant; please refrain from adding such comments. Also see https://www.mediawiki.org/wiki/Bug_management/Development_prioritization for general info - thanks a lot! :)

toorich renamed this task from MediaWiki:Pagetitle-view-mainpage does not behave the same in mobile version as it does in the desktop version to MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skin.Oct 26 2021, 7:23 PM
toorich raised the priority of this task from Medium to Needs Triage.Oct 26 2021, 7:27 PM
toorich triaged this task as Unbreak Now! priority.Sun, Nov 7, 6:29 AM
Majavah lowered the priority of this task from Unbreak Now! to Needs Triage.Sun, Nov 7, 8:41 AM

Change 737216 had a related patch set uploaded (by A2093064; author: A2093064):

[mediawiki/skins/MinervaNeue@master] Fix empty title for logged-out users using Minerva skin

https://gerrit.wikimedia.org/r/737216

Change 737112 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Minerva uses core page title handling

https://gerrit.wikimedia.org/r/737112

Change 738039 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaMessages@master] On mobile override, main page title

https://gerrit.wikimedia.org/r/738039

Change 737216 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix empty title for logged-out users using Minerva skin

https://gerrit.wikimedia.org/r/737216

Is the fact that the main page started to output title for anonymous readers caused by the patches above being merged?

(See https://ru.m.wikipedia.org/wiki/Заглавная_страница as an example or any other main page currently.)