MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skin
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	toorich
	Oct 19 2020, 12:22 PM

Description

The page title e.g. contents of the <title> tag of the main page of Wikimedia projects in the Minerva skin reads “- Project name” instead of just “Project name” (or maybe “Main page - Project name”).

Steps to Reproduce: open the main page of a Wikimedia Project (Wikipedia, Wikinews, etc) in either Mobile Web (m. domain) or with Minerva skin (?useskin=minerva) and check the page title (as visible eg in browser tabs).

Actual Results (Minerva):

Developer notes

T265892#6563562

Expected Results (Vector):

The issue is the line https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/Skins/SkinMinerva.php#L565

A similar problem exists in T255682 i

QA steps

Go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page as a logged in user and confirm the title says "Welcome, Username!"
Go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page as an anonymous user and confirm the title is absent from the page.

QA Results - Prod

AC	Status	Details
1	✅	T265892#7611539
2	✅	T265892#7611539

Details

Subject	Repo	Branch	Lines +/-
[Most used] Remove a deleted message	translatewiki	master	+0 -1
Minerva uses core page title handling	mediawiki/skins/MinervaNeue	master	+41 -43
Prepare for Minerva heading ID change	mediawiki/extensions/GrowthExperiments	master	+3 -0
On mobile override main page title	mediawiki/extensions/WikimediaMessages	master	+12 -0
Fix empty title for logged-out users using Minerva skin	mediawiki/skins/MinervaNeue	master	+1 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T287412 [GOAL, placeholder] Fix bugs relating to user experience in Minerva impacting mobile users
		Resolved	BUG REPORT	ovasileva	T265892 MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skin

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

toorich added a comment.Jul 13 2021, 7:18 PM

This comment was removed by toorich.

Please note that @Helix17 was inactive since April 5th.

Can somebody update the description of the task as it is very unclear what the problem is now I look at it a year later. The expected results show the desktop site, but the actual results show the mobile site and this links to an outdated URI.

This bug has a better chance of being addressed if the description is improved.

Does it relate to T255682 in any way?

Jdlrobson changed the task status from Open to Stalled.Jul 13 2021, 7:29 PM

Jdlrobson removed a project: good first task.

I have tried to describe what the original problem was (and still is)

Thanks @XanonymusX I've made a few tweaks to make it clearer what we need to do here.

Jdlrobson moved this task from Backlog to Tech debt on the MinervaNeue board.Jul 21 2021, 7:36 PM

Jdlrobson added a parent task: T287412: [GOAL, placeholder] Fix bugs relating to user experience in Minerva impacting mobile users.Jul 26 2021, 8:38 PM

Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Jul 26 2021, 8:55 PM

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (Tracking).Sep 3 2021, 5:09 PM

Jdlrobson moved this task from Backlog to Unused on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 3 2021, 5:17 PM

Almost 1 year later... the bug is still not fixed...

@toorich: If you would like to see a bug fixed, please see https://www.mediawiki.org/wiki/Gerrit/Tutorial and contribute a patch. Age of a ticket is irrelevant; please refrain from adding such comments. Also see https://www.mediawiki.org/wiki/Bug_management/Development_prioritization for general info - thanks a lot! :)

toorich renamed this task from MediaWiki:Pagetitle-view-mainpage does not behave the same in mobile version as it does in the desktop version to MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skin.Oct 26 2021, 7:23 PM

toorich raised the priority of this task from Medium to Needs Triage.Oct 26 2021, 7:27 PM

stjn mentioned this in T293941: [Regression] Browser tab title broken for mobile main page ("- Wikipedia").Oct 28 2021, 10:22 PM

toorich added a subscriber: Liuxinyu970226.Nov 3 2021, 12:26 PM

toorich triaged this task as Unbreak Now! priority.Nov 7 2021, 6:29 AM

toorich added a subscriber: A2569875.Nov 7 2021, 6:35 AM

SD_hehua subscribed.Nov 7 2021, 7:39 AM

taavi lowered the priority of this task from Unbreak Now! to Needs Triage.Nov 7 2021, 8:41 AM

@toorich: Please do not set random priorities. Thanks.

Change 737216 had a related patch set uploaded (by A2093064; author: A2093064):

[mediawiki/skins/MinervaNeue@master] Fix empty title for logged-out users using Minerva skin

https://gerrit.wikimedia.org/r/737216

gerritbot added a project: Patch-For-Review.Nov 8 2021, 4:17 AM

Test wiki created on Patch Demo by Xiplus using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/739aa3b7db/w/

Demo: https://patchdemo.wmflabs.org/wikis/739aa3b7db/wiki/Main_Page?useskin=minerva
No " - " prefix in <title>.

Change 737112 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Minerva uses core page title handling

https://gerrit.wikimedia.org/r/737112

Change 738039 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaMessages@master] On mobile override, main page title

https://gerrit.wikimedia.org/r/738039

Jdlrobson claimed this task.Nov 12 2021, 3:49 PM

Change 737216 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix empty title for logged-out users using Minerva skin

https://gerrit.wikimedia.org/r/737216

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 12 2021, 5:00 PM

Is the fact that the main page started to output title for anonymous readers caused by the patches above being merged?

(See https://ru.m.wikipedia.org/wiki/Заглавная_страница as an example or any other main page currently.)

@stjn: That's T296109: 1.38.0-wmf.9 introduces visible page title on main page for anonymous readers, interfering with design (and might be related, indeed).

Aklapper mentioned this in T296109: 1.38.0-wmf.9 introduces visible page title on main page for anonymous readers, interfering with design.Nov 20 2021, 7:29 PM

Jdlrobson mentioned this in T255682: Formalize Main page heading behaviour.Dec 1 2021, 5:53 PM

Jdlrobson triaged this task as Medium priority.Dec 1 2021, 9:48 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 2 2021, 10:53 PM

Jdlrobson mentioned this in T296969: Projects can customize their main page heading.Dec 2 2021, 11:08 PM

Izno subscribed.Dec 2 2021, 11:14 PM

Jdlrobson removed Jdlrobson as the assignee of this task.Dec 13 2021, 6:33 PM

Change 738039 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] On mobile override main page title

https://gerrit.wikimedia.org/r/738039

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.16; 2022-01-03); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Dec 14 2021, 10:00 AM

Jdlrobson updated the task description. (Show Details)Dec 14 2021, 5:01 PM

Change 747182 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/GrowthExperiments@master] Prepare for Minerva heading ID change

https://gerrit.wikimedia.org/r/747182

LGoto set the point value for this task to 3.Dec 14 2021, 6:25 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 14 2021, 7:11 PM

kostajh added a project: Growth-Team (Sprint 0 (Growth Team)).Dec 14 2021, 7:20 PM

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

(@Etonkovidova for Growth, nothing to QA yet, but once https://gerrit.wikimedia.org/r/c/737112 is merged, then QA for homepage would be nice.)

Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 14 2021, 8:02 PM

Change 747182 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Prepare for Minerva heading ID change

https://gerrit.wikimedia.org/r/747182

https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/737112 is ready for review now.

Jdlrobson mentioned this in T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.Dec 22 2021, 1:14 AM

Change 737112 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Minerva uses core page title handling

https://gerrit.wikimedia.org/r/737112

Jdlrobson assigned this task to Edtadros.Dec 22 2021, 7:27 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 22 2021, 11:53 PM

Change 749692 had a related patch set uploaded (by Amire80; author: Amire80):

[translatewiki@master] [Most used] Remove a deleted message

https://gerrit.wikimedia.org/r/749692

Change 749692 merged by jenkins-bot:

[translatewiki@master] [Most used] Remove a deleted message

https://gerrit.wikimedia.org/r/749692

jenkins-bot mentioned this in rGTWN8ff3cd504122: [Most used] Remove a deleted message.Dec 23 2021, 2:22 PM

In T265892#7570936, @kostajh wrote:

(@Etonkovidova for Growth, nothing to QA yet, but once https://gerrit.wikimedia.org/r/c/737112 is merged, then QA for homepage would be nice.)

Checked Main page on betalabs and on wmf.16 (for several wikis including zhwiki wmf.16) . Special:Homepage correctly displayed a user name. The title is displayed as following:

skin	url	title
new Vector	Special:Homepage - https://en.wikipedia.org/w/index.php?title=Special:Homepage&source=personaltoolslink&namespace=0	`<title>Hello, ‪Zilant17‬! - Wikipedia</title>` `<h1 id="firstHeading" class="firstHeading mw-first-heading">Hello, ‪Zilant17‬!</h1>`
new Vector	Main page - https://en.wikipedia.org/wiki/Main_Page	`<title>Wikipedia, the free encyclopedia</title>`
Minerva	Special:Homepage - https://en.m.wikipedia.org/w/index.php?title=Special:Homepage&namespace=0	`<title>Hello, ‪Zilant17‬! - Wikipedia</title>`, `<div class="page-heading"> <h1 id="firstHeading" class="firstHeading mw-first-heading">Hello, ‪Zilant17‬!</h1>`
Minerva	Main page - https://en.m.wikipedia.org/wiki/Main_Page	`<title>Wikipedia, the free encyclopedia</title>` `<div class="page-heading"><h1 id="firstHeading" class="firstHeading mw-first-heading">Welcome, Zilant17!</h1>`

Etonkovidova removed a project: Growth-Team (Sprint 0 (Growth Team)).Jan 7 2022, 1:43 AM

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 11 2022, 2:26 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome, Firefox
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Go to https://en.m.wikipedia.org/wiki/Main_Page as a logged in user and confirm the title says "Welcome, Username!"

Screen Shot 2022-01-10 at 6.29.01 PM.png (342×709 px, 55 KB)

✅ AC2: Go to https://en.m.wikipedia.org/wiki/Main_Page as an anonymous user and confirm the title is absent from the page.

Screen Shot 2022-01-10 at 6.29.41 PM.png (272×627 px, 40 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Jan 11 2022, 2:30 AM

Edtadros updated the task description. (Show Details)

Edtadros subscribed.

ovasileva closed this task as Resolved.Jan 17 2022, 2:29 PM

Stang unsubscribed.Jan 17 2022, 3:59 PM

SD_hehua awarded a token.Jan 21 2022, 6:46 AM

SD_hehua unsubscribed.

Following up to gerrit 737112 from late 2021 which has these FIXME:

// FIXME: #section_0 rule can be removed > 1 week after
// I2ffdedd64414ffb3c6e441391a75fd6e744847a4 is in production.

These remaining #section_0 selectors may now be removed.

Posted https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/776219 :) Thanks for letting me know!

Jdlrobson mentioned this in T305285: Minerva Skin/MobileFrontEnd causing issues with Google SERPS.Apr 2 2022, 12:19 AM

Jdlrobson merged a task: T305285: Minerva Skin/MobileFrontEnd causing issues with Google SERPS.Apr 4 2022, 3:26 PM

Jdlrobson added subscribers: ArrakisMiner, MinervaNeue, MobileFrontend.

Test wiki on Patch demo by Xiplus using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/739aa3b7db/w/~~

Aklapper removed a subscriber: MinervaNeue.May 17 2023, 7:37 AM

Maintenance_bot removed a project: Patch-For-Review.May 17 2023, 8:11 AM

Aklapper added a project: MobileFrontend.May 24 2023, 1:22 PM

Aklapper removed a subscriber: MobileFrontend.

	F34913877: Screen Shot 2022-01-10 at 6.29.01 PM.png
	Jan 11 2022, 2:30 AM

	F34913879: Screen Shot 2022-01-10 at 6.29.41 PM.png
	Jan 11 2022, 2:30 AM

MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skinClosed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions