The AC says "The link should apply for pages without a language button", but the the developer notes mention hiding the link for pages without languages.

@ovasileva could you help clarify if the interwiki link should be inside the sidebar for pages without the language button? I might not be testing this right, but I don't see the link on pages without the language button right now.

Change 708173 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Copy interwiki links into sidebar

https://gerrit.wikimedia.org/r/708173

The AC says "The link should apply for pages without a language button", but the the developer notes mention hiding the link for pages without languages.

@ovasileva could you help clarify if the interwiki link should be inside the sidebar for pages without the language button? I might not be testing this right, but I don't see the link on pages without the language button right now.

I can expand on this one. Right now we don't output a language button for pages without languages.

We still don't want to show the language button, but we'll want to render it in the HTML so that the JavaScript hack works. Thus, we'll need to hide this in CSS instead as part of this task.

do we want to add an AC about ensuring that this link doesn't appear in legacy vector (or other skins)?

Change 708173 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Copy interwiki links into sidebar

https://gerrit.wikimedia.org/r/708173

In T287206#7240424, @alexhollender wrote:

do we want to add an AC about ensuring that this link doesn't appear in legacy vector (or other skins)?

This is part of the QA steps.

This approach seems odd. If you want to move the language links to the top-right, then people will start expecting to see the links there. So if you add the 'add links' back to the sidebar, then no-one will look for them there. Why not always show the interlanguage link in whatever place is now normal, and include the 'add links' link in that directly?

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In modern Vector (useskinversion=2)

✅ AC1: Ensure "Edit interlanguage links" link is added to the "Tools" menu in the sidebar and matches the styles of the links around it

In legacy Vector (useskinversion=1)

✅ AC4: Ensure the language section in the sidebar is present on https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page?useskinversion=1 and has a gray "Add links" in the bottom right corner.

This has been implemented at euwiki but the system is not the same, and it should. Now we have a form at Wikidata that is new for all users.

We had one perfectly working solution, now we have changed the place and the system, so we have two problems.

@Theklan wrote:
It should work in the exact same way it used to work, with a pop-up in wiki, without going to any other project.
The link introduced creates a New Item at Wikidata, instead of linking to other languages.

I'm sorry, I can't reproduce.

I go to a random page on Wikipedia in Euskara with the Desktop Improvements:

Enabled, Eustomias brevibarbatus, I find that it's already connected, and when I choose "Edit interlanguage links", I go to https://www.wikidata.org/wiki/Q4993563#sitelinks-wikipedia.

Disabled, Eustomias brevibarbatus, I choose "Edit links", I go to the very same section on the same page: https://www.wikidata.org/wiki/Q942005#sitelinks-wikipedia.

So in both situations, I go to another project.

I don't create a new item either.

Alright, sorry, I checked with a page that hasn't been linked to Wikidata, and now I understand.

Indeed, selecting "Add links" in Vector shows a pop-up. Selecting "Add interlanguage links" redirects to d:Special:NewItem.

That's it! This feature is for newly created pages that should be linked to other languages, so it shouldn't create NewItem, but link to already existing items. This feature now is creating duplicated entries at Wikidata, making the possible mess much bigger for volunteers.

You can easily reproduce the problem by going to any page linked in Special:UnconnectedPages. This would make finding the issue easier.

it's clear this fails the AC " It should work in the exact same way it used to work, with a pop-up in wiki, without going to any other project." So moving to needs more work (I've explained why on the Gerrit patch)

Change 711196 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Copy class across to new language link item

https://gerrit.wikimedia.org/r/711196

The dialog is added via this code:
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/f2e96e1b08fc5ae2e2e92f05d5eda137dc6b1bc8/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js#172
and added by https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/f2e96e1b08fc5ae2e2e92f05d5eda137dc6b1bc8/client/resources/wikibase.client.linkitem.init.js#82

... and added as part of the 'wikibase.client.linkitem.init' module which apparently is getting loaded mw.loader.getState('wikibase.client.linkitem.init') === 'ready'

This actually works fine with debug=true, (https://eu.wikipedia.org/wiki/Messali_Hadj?useskinversion=2&debug=true) so this tells me we have some kind of race condition.

I still can't setup Wikibase but I replicated this behaviour with:

$wgHooks['SkinAfterPortlet'][] = function ( $skin, $name, &$html ) {
	//$html .= "<!--injected by LocalSettings.php: $name-->";
	if ( $name === 'lang' ) {
		$html .= '<span class="wb-langlinks-edit wb-langlinks-link" style="list-style: none;text-align: right;padding-right: 0.5em !important;line-height: 1.125em;font-size: 0.75em;float: right;"><a href="https://www.wikidata.org/wiki/Special:EntityPage/Q107514094#sitelinks-wikipedia" title="Edit interlanguage links" class="wbc-editpage" style="color: #54595d !important;">Edit links</a></span>';
		$html .= '<script>$(".wb-langlinks-link .wbc-editpage").on("click", (ev) => { alert("Works"); ev.preventDefault(); });</script>';
	}
};

With that, it was clear the issue relates to a missing class added in https://gerrit.wikimedia.org/r/711196

Change 711196 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Copy class across to new language link item

https://gerrit.wikimedia.org/r/711196

https://en.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.7996054623137496-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n?useskin=vector&useskinversion=2

It's functional now, but likely needs some better styling treatment.

Either by overrides or (preferred) scoping the styles in https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/036d7e2c3e8b8faae26406908552e1b4c8d756bb/client/resources/wikibase.client.css#1 to Vector legacy some how. @Ladsgroup is there any clean way I could do this?

Change 712408 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Add wikibase skin style

https://gerrit.wikimedia.org/r/712408

Change 712408 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add wikibase skin style

https://gerrit.wikimedia.org/r/712408

I mean !important is evil but I don't know a better alternative atm :/ I can take a look at it but I doubt I would be able to come up with a solution tbh.

Change 712950 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Revert \"Add wikibase skin style\"

https://gerrit.wikimedia.org/r/712950

Change 713011 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikibase@master] Provide special styling for modern Vector for add language links

https://gerrit.wikimedia.org/r/713011

The skinStyle was not applying, as it seems skins can't register skinStyles if the skinStyle is defined inside the extension it's trying to extend.

@Ladsgroup https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/713011 should fix the remaining styling problem. I can't think of a better way to do it right now.

Change 712950 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert \"Add wikibase skin style\"

https://gerrit.wikimedia.org/r/712950

Change 713011 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Provide special styling for modern Vector for add language links

https://gerrit.wikimedia.org/r/713011

I ran into a New Vector wiki while logged-out, and noticed this doesn't seem to look quite right:

https://pt.wikipedia.org/wiki/Algoritmo

It has the grey right-aligned pencil styling as if it were at the end of a list of language links. I assume this styling is no longer meant to apply. Perhaps this is due to a change that was incompatible with our caching in production? (I suspect, since it doesn't appear to be this way everywhere)

Yup, it's a known problem that its fix got merged last night (look at the above comment by gerritbot). It can be also backported but I leave that to the reading team.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In modern Vector (useskinversion=2)

✅ AC1: Ensure "Edit interlanguage links" link is added to the "Tools" menu in the sidebar and matches the styles of the links around it

✅ AC2: Ensure the language button is only visible on pages with languages. It should be visible on https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page There should be no languages section in the sidebar on this page.

✅ AC3: Ensure the language button is only visible on pages with languages. It should NOT be visible on https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_link_test_0.0409507727617362. There should be no languages section in the sidebar on this page.

In legacy Vector (useskinversion=1)

✅ AC4: Ensure the language section in the sidebar is present on https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page?useskinversion=1 and has a gray "Add links" in the bottom right corner.

A question: is this related to why some languages (en, no, etc.) display the links by default, and others (fr) don't? Or is that just an option that the French have opted out of? My recollection is, that fr-wiki used to display them as well, but my memory may be off.