| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Tooltip: replace our own Tooltip component with Codex Tooltip | mediawiki/extensions/WikiLambda | master | +23 -187 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | DSmit-WMF | T298040 Replace our bespoke Tooltip component with Codex's, now that it exists | |||
| Resolved | JFernandez-WMF | T340456 Tooltip: Add Tooltip component to Codex | |||
| Resolved | JFernandez-WMF | T364638 Design: Tooltip component | |||
| Resolved | egardner | T366104 Tooltip: Introduce a WIP component to Codex | |||
| Resolved | DTorsani-WMF | T366129 Publish guidelines for Tooltip component | |||
| Resolved | lwatson | T367101 Publish Tooltip component | |||
| Resolved | lwatson | T367467 Tooltip: add snapshot and unit tests |
Event Timeline
Comment Actions
So for the tooltips inside the app; for the function editor input and outputs tooltips: we can use the Codex one. (although the third party lib has a bug I think, contacted design system team about that).
For the titles on the viewpage and editpage, that are outside of the Vue scope:
I don't think we can use Codex here because you cannot bind directives outside of Vue.
After discussing with Geno:
Our suggestion would be to:
- remove all tooltips from title (they overlap and are broken now because of overflow hidden on the header).
- change data-title to title attr, which then shows as a native browser tooltip on hover with the long name (so we have some sort of tooltip func)
Add them back only when:
-> codex has SSR
-> codex has a only css variant for the tooltip
Comment Actions
Change #1060107 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):
[mediawiki/extensions/WikiLambda@master] [WIP] Tooltip: replace our own Tooltip component with Codex Tooltip
Comment Actions
Change #1060107 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Tooltip: replace our own Tooltip component with Codex Tooltip