Page MenuHomePhabricator

Align contentSub with page title
Closed, ResolvedPublic

Description

The contentSub should be aligned with the page title.

current alignmentcorrect alignment
image.png (474×1 px, 139 KB)
image.png (474×1 px, 140 KB)
image.png (600×1 px, 183 KB)
image.png (600×1 px, 183 KB)

Open questions

  • 1. On desktop, how should the latest comment indicator that will appear at the top of talk pages be shown when other content exists within the contentSub element?
  • 2. What skin(s) should this change impact? Vector (2022)? Vector (2022) and Legacy Vector?
    • Vector (2022)

Event Timeline

This is how contentSub is presented on Vector (and Monobook and Modern; on the other hand, Minerva, Timeless and Cologne Blue have no indentation). I don’t think it looks bad, but if it’s changed, it should be changed in Vector, not in DiscussionTools, otherwise it’d get unaligned with other contentSub elements like breadcrumbs.

alexhollender_WMF renamed this task from Freshness indicator should appear aligned with the Talk Page title to Align contentSub with page title.May 23 2022, 8:11 PM
alexhollender_WMF updated the task description. (Show Details)

We are currently only re-aligning our own message, which looks odd when there are other contentSub's:

image.png (298×714 px, 34 KB)

cc @KieranMcCann

ppelberg updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.

We talked about this today, editing team needs to work out if this is a Vector-2022 change only, or both Vector skins change. The editing team will take on the work for this and reach out to web team if necessary

Change 825878 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Vector 2022: Align #contentSub with page title (to the left)

https://gerrit.wikimedia.org/r/825878

Change 825878 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Vector 2022: Align #contentSub with page title (to the left)

https://gerrit.wikimedia.org/r/825878

ppelberg claimed this task.