Page MenuHomePhabricator

New post-edit dialog for non-suggested edits
Closed, ResolvedPublic

Description

User Story

As a newcomer who has never tried a suggested edit, I want to try a suggested edit, because I'm still learning and want to find simple ways to participate while I learn core wiki skills (and when visiting my homepage, I can see my impact which is motivational and encouraging)

As a more advanced Wikimedian, I want newcomer retention to improve, because the long-term health of the wikis will require new contributors

Design

Figma Designs

Illustration assets (from T323785)

LTRRTL

Description

Introduce newcomers who complete ‘normal’ edits to suggested edits. There are two variant for this messaging – the ‘standard’ and an opt-in message. For either option, the criteria for being shown this message will be the same.

image.png (1×652 px, 109 KB)

For this initial experiment we will only show this message to newcomers who:

  • Have Growth features enabled.
  • Have never tried a suggested edit.
  • A newcomer will only ever see this message twice:
    • once they complete a 3rd article namespace edit
    • once they complete a 7th article namespace edit

(We may adjust these numbers in the future as we gather more data T322433).

Details:

  • Toast message normally shown after editing in VE is shown (not the green success message).
  • A message and illustration encourages people to try suggested edits, with a specific opt-in.
  • If “Try a suggested edit” is selected, they are taken to the Suggested edits module.
  • If “No thanks” is selected, dialog is dismissed.
  • Ensure there is no conflict with other products such as the CX tool which has the same suggestion point (see T287025).

Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Only shown for edits made in VE, not WE.

Out of curiosity, why do we exclude users who utilize the wikitext editor? In some wikis, they are pushed to do that (e.g. enwiki), and I imagine that those users would benefit from trying suggested edits. The guidance feature in Suggested Edits supports users with the wikitext editor, though it does nudge them to switch to VE.

If “Try a suggested edit” is selected, they are taken to the Suggested edits module.

On desktop, do we need to highlight the suggested edits module or otherwise point to it with a guided tour?

Only shown for edits made in VE, not WE.

Out of curiosity, why do we exclude users who utilize the wikitext editor? In some wikis, they are pushed to do that (e.g. enwiki), and I imagine that those users would benefit from trying suggested edits. The guidance feature in Suggested Edits supports users with the wikitext editor, though it does nudge them to switch to VE.

Yeah, that is a good point. Initially I included this as I didn't want people who are using WE (likely more experienced folks) to be thrown by the change in editor given all Suggested Edits guidance is intended for use with VE, and structured tasks being built over VE. @KStoller-WMF what do you think about removing this and showing to any newcomer on their 3rd and 7th edit who sees this on Wikitext or Visual Editor?

If “Try a suggested edit” is selected, they are taken to the Suggested edits module.

On desktop, do we need to highlight the suggested edits module or otherwise point to it with a guided tour?

Yeah, that is a good point. Initially I included this as I didn't want people who are using WE (likely more experienced folks) to be thrown by the change in editor given all Suggested Edits guidance is intended for use with VE, and structured tasks being built over VE. @KStoller-WMF what do you think about removing this and showing to any newcomer on their 3rd and 7th edit who sees this on Wikitext or Visual Editor?

Since we are only showing this twice and early on, it seems safe to remove that requirement. I've updated the task.

A newcomer will only ever see this message twice:

  • once they complete a 3rd edit
  • once they complete a 7th edit

I'm assuming we are talking about article namespace edits here.

I'm also assuming it's not super important for every user to see this message. There is an easier way to implement (just check user's edit count after an edit; if it matches, show the notification) and a more complex way (keep a "user has not seen the 3rd-edit notice yet" flag in user preferences; if the flag is true and the user is making a 3rd or latter edit, show the notice and unset the flag). The easy way can fail in all kinds of edge cases (like saving two edits in different tabs at the same time).

Also, since we can easily get the total edit count, but calculating the article namespace edit count takes some effort, there should be a total-editcount cutoff here (something like 20 total edits maybe?) where if the user has more edits than that, we assume they probably have more than 7 article namespace edits and don't even check.

Also I assume we want to limit this to non-autocreated accounts if possible (although not sure how feasible that is).

A newcomer will only ever see this message twice:

  • once they complete a 3rd edit
  • once they complete a 7th edit

I'm assuming we are talking about article namespace edits here.

Yes. I'll update the task description.

I'm also assuming it's not super important for every user to see this message. There is an easier way to implement (just check user's edit count after an edit; if it matches, show the notification) and a more complex way (keep a "user has not seen the 3rd-edit notice yet" flag in user preferences; if the flag is true and the user is making a 3rd or latter edit, show the notice and unset the flag). The easy way can fail in all kinds of edge cases (like saving two edits in different tabs at the same time).

I agree, I don't think it's super important for every user sees this message, let's implement in the easier way.

Also, since we can easily get the total edit count, but calculating the article namespace edit count takes some effort, there should be a total-editcount cutoff here (something like 20 total edits maybe?) where if the user has more edits than that, we assume they probably have more than 7 article namespace edits and don't even check.

Yes, it makes sense to set a total-editcount cutoff. 20 total edits is fine with me.

Also I assume we want to limit this to non-autocreated accounts if possible (although not sure how feasible that is).

Whatever is easiest to implement is fine with me. Since we only show this dialog after a user has made several article namespace edits it seems like the user is engaging in the wiki in a way that indicates this notice is appropriate. (At the moment it's almost a non-issue since autocreated accounts don't receive Growth features by default...).

Change 892386 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Suggested edits invitation server side

https://gerrit.wikimedia.org/r/892386

Change 892387 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Use SuggestedEditSession for non-suggested edits

https://gerrit.wikimedia.org/r/892387

Change 893402 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/MobileFrontend@master] Flag post-edit reloads in the wikitext editor

https://gerrit.wikimedia.org/r/893402

Change 893403 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Detect post-edit reload in mobile wikitext editor

https://gerrit.wikimedia.org/r/893403

Change 892386 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Suggested edits invitation server side

https://gerrit.wikimedia.org/r/892386

Change 892387 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Show invite dialog after non-suggested edits

https://gerrit.wikimedia.org/r/892387

Ensure there is no conflict with other products such as the CX tool which has the same suggestion point (see T287025).

In the longer run, we should create some kind of generic mechanism for dealing with such issues. Filed T331240: Create a mechanism for coordinating introductory popups/guiders/invitations in MediaWiki extensions about that.

Change 894219 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/ContentTranslation@master] Allow suppressing SX invitation dialog via JS variable

https://gerrit.wikimedia.org/r/894219

Change 894220 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Suppress CX invite on non-suggested post-edit notice

https://gerrit.wikimedia.org/r/894220

Change 894221 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Hide postedit-nonsuggested drawer when editing

https://gerrit.wikimedia.org/r/894221

@Etonkovidova much of this task is available for QA on desktop; the mobile implementation is still awaiting code review from other teams.

Change 894219 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Allow suppressing SX invitation dialog via JS variable

https://gerrit.wikimedia.org/r/894219

@Etonkovidova much of this task is available for QA on desktop; the mobile implementation is still awaiting code review from other teams.

@Etonkovidova @KStoller-WMF the mobile implementation will be available for QA on beta wikis shortly.

Change 893402 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Flag post-edit reloads in the wikitext editor

https://gerrit.wikimedia.org/r/893402

Change 893403 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Detect post-edit reload in mobile wikitext editor

https://gerrit.wikimedia.org/r/893403

Change 894220 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Suppress CX invite on non-suggested post-edit notice

https://gerrit.wikimedia.org/r/894220

Change 894221 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Hide postedit-nonsuggested drawer when editing

https://gerrit.wikimedia.org/r/894221

@Etonkovidova much of this task is available for QA on desktop; the mobile implementation is still awaiting code review from other teams.

@Etonkovidova @KStoller-WMF the mobile implementation will be available for QA on beta wikis shortly.

Thx, @kostajh!

The first time drawer is displayed (after the third edit), it stays until a user will interact with it. After the seventh edit, the drawer momentarily appears and would be gone not allowing users to interact with it:

after the third edit - the drawer sticksafter the seventh edit - the drawer disappears immediately
(click on the animated gif)
non_suggested_edits.gif (678×960 px, 491 KB)
(click on the animated gif)
non_suggested_edits2.gif (678×960 px, 468 KB)

The same behavior is on the mobile - after the seventh edit, the drawer disappears immediately after being displayed.

For Design review - @JFernandez-WMF :

(1) The following spec is not in place:

For this initial experiment we will only show this message to newcomers who:

Have Growth features enabled.

"Try a suggested edit" will be shown to all users, including users who don't have Homepage enabled or they disabled it. If users without Homepage, clicks on "Try suggested edits", users would be redirected to a page with the prompt and a link to go to Special:Preferences.

(2) the line spacing seems to be tight on desktop

Screen Shot 2023-03-10 at 4.01.00 PM.png (698×970 px, 110 KB)
Screen Shot 2023-03-10 at 4.29.54 PM.png (1×728 px, 170 KB)

(3) the mobile mockup has a more visible border around the image

mockupmobile
Screen Shot 2023-03-10 at 4.49.13 PM.png (1×646 px, 117 KB)
Screen Shot 2023-03-10 at 4.29.54 PM.png (1×728 px, 173 KB)

Change 897399 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Fix non-suggested post-edit dialog hiding logic

https://gerrit.wikimedia.org/r/897399

Change 897399 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Fix non-suggested post-edit dialog hiding logic

https://gerrit.wikimedia.org/r/897399

(3) the mobile mockup has a more visible border around the image

I think that's part of the diagram on Figma, or at least I couldn't figure out how to show the properties for it. Likewise, the background color of the diagram is a bit different. I think that would have to be fixed in the SVG asset (if it is something to be fixed).

(3) the mobile mockup has a more visible border around the image

I think that's part of the diagram on Figma, or at least I couldn't figure out how to show the properties for it. Likewise, the background color of the diagram is a bit different. I think that would have to be fixed in the SVG asset (if it is something to be fixed).

Sorry for confusion, but @Etonkovidova is right that the intention is to have a 1px border (in color Border/Subtle in Codex or color.gray300 if using the old reference) around the image container.

Change 898860 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Fix non-suggested postedit dialog image border

https://gerrit.wikimedia.org/r/898860

Sorry for confusion, but @Etonkovidova is right that the intention is to have a 1px border (in color Border/Subtle in Codex or color.gray300 if using the old reference) around the image container.

Thanks for specifying! I see the border element can be reached in Figma via the navigation sidebar, sorry I missed that.

Change 898860 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Fix non-suggested postedit dialog image border

https://gerrit.wikimedia.org/r/898860

+2'ed, should be on beta in the next hour or so.

Change 898860 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Fix non-suggested postedit dialog image border

https://gerrit.wikimedia.org/r/898860

Change 905749 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Only show try suggested edits dialog on articles

https://gerrit.wikimedia.org/r/905749

This has been lingering in Design review, but I believe it should be resolved.
@JFernandez-WMF please reopen if needed.