For this entry point, has the instrumentation part be considered as part of the current work or is it preferred to create a separate ticket (to implement or discuss details about it)?

Change 763179 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX recent edit entrypoint: Add EditedSectionFinder service

https://gerrit.wikimedia.org/r/763179

Change 734870 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Add \"cx_significant_edits\" table to support entrypoint

https://gerrit.wikimedia.org/r/734870

Change 740887 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX recent edit entrypoint: Add edit model and store

https://gerrit.wikimedia.org/r/740887

@ngkountas What is pending in this ticket?

Change 763179 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX recent edit entrypoint: Add EditedSectionFinder service

https://gerrit.wikimedia.org/r/763179

Screenshot from latest patch:

Desktop	Mobile

Issues noticed:

1. Should we show this invite in desktop? I dont think so.
2. Alignment issue for the + icon. Looks ok in Mobile though
3. The link target takes to wrong URL(URL has missing title=Special:ContentTranslation part).
4. The Translate button could be a link for accessibility reasons.
5. Dismiss button hides it, but should we hide the message permanently? Remember it atleast in browser session?

I updated the related patch to fix above issues. @Pginer-WMF could you confirm we should not show this invite in desktop as Santhosh mentions in the first (1) issue above? Also, do you think we should add some additional logic to hide the invitation permanently when the close button is clicked (as asked in issue (5) above)?

Regarding the questions:

(1) I think we should not show the invite on desktop for now. Translating sections on desktop is not fully supported. Once desktop support for sections is more stable, we can consider exposing this. I'll create a separate ticket for this.

(5) Disabling "permanently" can have multiple interpretations:

• Different articles. It is ok for the invite even if the user discarded it in a different article previously. A general way to opt-out for this kind of contribution invite (and others) will be provided through a cog icon when T290317 is ready.

• Same article. Ideally, it would be great not to make the same exact suggestion for the same edited section on the same article once users have discarded it. That is, if I discard a suggestion to translate the "Legal status" of the Moon article:
  • It will not be expected to be shown just by refreshing or visiting the same page without any other edit activity.
  • It may be expected to be shown if the source article was edited again by me for the same or other section. In this case the invite would be understood as a suggestion to transfer the new contents. This is less important consideration than the previous one, so we can be flexible depending on technical complexity.

Change 736275 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add after edit hook to create entries in significant-edits table

https://gerrit.wikimedia.org/r/736275

Change 738178 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX recent edit entrypoint: add hook to register JS module

https://gerrit.wikimedia.org/r/738178

Change 738192 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add UI for entrypoint for translating recently edited section

https://gerrit.wikimedia.org/r/738192

Let's get clarity on what's still pending.

@GMikesell-WMF @EChukwukere-WMF Could you help QA this one?

I can take a look at this

Test Status: QA PASS

Article translated: https://test.wikipedia.org/wiki/Chikezie?sx-source-page-title=Chikezie&sx-published-section=The+following+is+a+list+of+the++&sx-source-language=es&sx-target-language=en

Invite was observed for other missing sections

The above QA tested the "Invite after translation" entrypoint, but the task is about the "Invite to translate a section recently edited in another language" entrypoint (recent edit entrypoint).

Confirming that the dashboard translation start events are being logged for this entry point with event source as followup_after_publishing

Event count at the destination table with this event source:

@ngkountas

The above QA tested the "Invite after translation" entrypoint, but the task is about the "Invite to translate a section recently edited in another language" entrypoint (recent edit entrypoint).

What is the event_source for instrumentation?

There are not events with recent_edit as event source at the destination, but there are with recent_translation

Thanks for the data @KCVelaga_WMF! It turns out that the recent_edit entrypoint is not instrumented at all! I'm submitting a patch to fix this.

Change #1165817 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Instrument mobile "recent-edit" entrypoint

https://gerrit.wikimedia.org/r/1165817

Change #1165817 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Instrument mobile "recent-edit" entrypoint

https://gerrit.wikimedia.org/r/1165817

@ngkountas thanks for clarifying, I will check your fix is complete

Is there any way to test this outside editing production wikis? At least the events should be flowing now so @KCVelaga_WMF should see if there are any.

@Nikerabbit I am checking with @ngkountas to find the steps to properly test this outside production wikis

The entrypoint URL uses the mfrecentedit campaign, as it should. That's all that's required for the entrypoint instrumentation to work properly — and it does, as demonstrated in the following screencast (from my local dev environment), where one can easily see the dashboard_open logged with the recent_edit event_source:

Once, @KCVelaga_WMF is back and confirms that the recent_edit event source properly receives events, we can close this task for good.

Tagging @cchen for QA.

I queried the data destination, event.mediawiki_content_translation_event for August. There's 1 event with dashboard_open event type with event source as recent_edit.

This entrypoint is not expected to be much more prominent. At the same time it's impossible to test in production without significantly polluting the main namespace of some wiki. However, given that we receive instrumentation events from this entrypoint and based on the screencast of how the entrypoint looks like from my local dev environment, I think we can close this task as completed.