| TheDJ | |
| Jan 24 2023, 12:35 PM |
| F36521226: Screen Shot 2023-01-26 at 10.23.40 AM.png | |
| Jan 26 2023, 6:26 PM |
| F36487040: Screen Shot 2023-01-24 at 5.02.15 PM.png | |
| Jan 24 2023, 10:08 PM |
| F36457169: Vector-2022-preview-broken.png | |
| Jan 24 2023, 12:35 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Not this ;)
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | ovasileva | T327778 Pagetools: 2017 wikitext editor preview broken | ||
| Resolved | Esanders | T328783 2017 wikitext editor preview should be center aligned when using Vector 2022 |
Change 883198 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/extensions/VisualEditor@master] Fix Wikitext editor preview layout in Vector 2022
Change 883213 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.19] Fix Wikitext editor preview layout in Vector 2022
I see backports, Remember that .20 was already cut yesterday, so youll need two back ports!
Change 883216 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.20] Fix Wikitext editor preview layout in Vector 2022
Change 883198 merged by Jforrester:
[mediawiki/extensions/VisualEditor@master] Fix Wikitext editor preview layout in Vector 2022
Change 883213 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.19] Fix Wikitext editor preview layout in Vector 2022
Change 883216 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.20] Fix Wikitext editor preview layout in Vector 2022
Mentioned in SAL (#wikimedia-operations) [2023-01-24T21:59:01Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:883213|Fix Wikitext editor preview layout in Vector 2022 (T327778)]], [[gerrit:883216|Fix Wikitext editor preview layout in Vector 2022 (T327778)]]
Mentioned in SAL (#wikimedia-operations) [2023-01-24T22:00:48Z] <samtar@deploy1002> samtar and jdrewniak: Backport for [[gerrit:883213|Fix Wikitext editor preview layout in Vector 2022 (T327778)]], [[gerrit:883216|Fix Wikitext editor preview layout in Vector 2022 (T327778)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-01-24T22:08:38Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:883213|Fix Wikitext editor preview layout in Vector 2022 (T327778)]], [[gerrit:883216|Fix Wikitext editor preview layout in Vector 2022 (T327778)]] (duration: 09m 36s)
I guess this is... better? (should've checked on a wider screen) I'll see what we can do to improve it.
This is what I'm seeing today in Safari/macOS at enwiki.
I don't know whether it makes more sense to show full width (like "I" will see it) or narrow width (like "readers" will see it). It's always tempting to arrange the page/images so that it looks good on my screen, without remembering that other people will see it with a different screen size/font size/screen resolution.
Alignment to be tracked in T328783: 2017 wikitext editor preview should be center aligned when using Vector 2022. Resolving this one!