Page MenuHomePhabricator

[L] IP Masking Considerations: MachineVision
Closed, ResolvedPublic


IP Masking means that we create a temporary account for any user that's editing without being logged in. More details on how temporary accounts work here, and more details on what to look for when adapting an extension to handle temporary accounts is here

A quick search for relevant code in the Machine extension is here

ATM Special:SuggestedTags requires a user to be logged in, which suggests that we ought not allow a temp user to use it ... but we should make sure that there's no login required to use the API (so the ISA tool can continue to work). Probably we'll need to replace isAnon with !isNamed, make sure that an anon/temp user can't reach the mw.user.getId code, find where the code checks if a user is logged in, and then test everything to make sure it still works when logged in as a regular user .

To enable temporary accounts in your local dev env, add this to LocalSettings.php

$wgAutoCreateTempUser['enabled'] = true;

Event Timeline

MarkTraceur renamed this task from IP Masking Considerations: MachineVision to [L] IP Masking Considerations: MachineVision.Jun 14 2023, 4:56 PM

Change 934502 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/MachineVision@master] Handle temporary accounts for IP Masking

Change 934502 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] Handle temporary accounts for IP Masking

I'm guessing this can't be tested on beta @Etonkovidova ?

QA notes: temporary accounts are enabled on beta dewiki

MachineVision extenstion is not installed on dewiki beta (and it shouldn't). Can we enable IP masking on commons beta wiki? There are several things to be checked, e.g. a warnings to non-logged users. The current warning message mentions user's IP:

Screen Shot 2023-07-17 at 3.58.27 PM.png (748×834 px, 184 KB)

There might be several places on commons where messages to users include mentioning IP addresses.

Checked on commons beta (IP masking is enabled there - T342067) - no issues are found. Closing the task as Resolved . It will be checked in production as part of T341839: [QA task] IP masking - temp users testing in production.