Page MenuHomePhabricator

IP Masking: Update temporary account icon
Closed, ResolvedPublic

Description

Related: T335694: IP Masking: Create an icon for temporary accounts

User story

As a person who has a temporary account,
I want the temporary account icon to be clearly different from a regular user account icon,
So that there is an easy visual that helps indicate that I'm not logged into a regular account

Proposed design

PNGSVG
image.png (20×20 px, 3 KB)

Previous proposed designs

  1. Existing userAnonymous icon from Codex/OOUI

image.png (86×294 px, 8 KB)

  • Used as a placeholder in early work on IP Masking, but considered not ideal as a misrepresentation of the person being incognito in the same way as browser incognito mode.
  • Can be confusing for the Unregistered/Anonymous editor user type that would still exist in many places during the MVP
  • Stylistically very different from the userAvatar icon
  1. Dotted outline avatar

image.png (306×1 px, 29 KB)

  • Used in Growth usability tests (see figma) with no negative feedback.
  • Dotted line is more indicative of the ephemeral nature of the user account but may be harder to notice at the smaller resolution.

Acceptance criteria:

Given I am logged into a temporary account,
When I view the menu,
Then the icon used to represent my temporary user account is the temporary account icon:

image.png (20×20 px, 3 KB)

Given I receive a message from a temporary user,
When I view the notification.
The the icon used to represent the temporary user account is the temporary account icon

Event Timeline

The temp account icon has been added already in Codex T335694 and in process for OOUI in T338165.

I see the following when I make an edit on dewiki beta as a temp account.

image.png (1×3 px, 413 KB)

Is there any other place where the icon is used? Should we do any other as part of this task?

Hmmm, it looks like another team got to this before we did.
I don't know of any other place where the icon is used, so I'll move to QA.

@RHo @Trizek-WMF - please let us know if you can think of other spots where this icon should be used.

Hmmm, it looks like another team got to this before we did.
I don't know of any other place where the icon is used, so I'll move to QA.

@RHo @Trizek-WMF - please let us know if you can think of other spots where this icon should be used.

Yes, the part that Growth would be responsible for is when the icon appears in Echo Notifications for UserTalk pages.

This icon should be available as SVG on Commons, so that communities can use it for their documentation and other creative usages. (This is overall true for all icons/images WMF produces.)

This icon should be available as SVG on Commons, so that communities can use it for their documentation and other creative usages. (This is overall true for all icons/images WMF produces.)

Good point, there is a gallery on Commons with the Wikimedia OOUI icons which is community maintained: https://commons.wikimedia.org/wiki/OOUI_icons

"Community maintained" is precisely the single point of failure. :)

"Community maintained" is precisely the single point of failure. :)

hah fair enough, this is something that I can file as a request to Design-System-Team + Wikimedia Design Style Guide as they're responsible for the SVG icons in OOUI/Codex.

hah fair enough, this is something that I can file as a request to Design-System-Team + Wikimedia Design Style Guide as they're responsible for the SVG icons in OOUI/Codex.

As you certainly have more influence that tI have there, it would be very nice to have regular updates and upgrades for all icons and design elements we use on wiki. Thank you!

Hmmm, it looks like another team got to this before we did.
I don't know of any other place where the icon is used, so I'll move to QA.

@RHo @Trizek-WMF - please let us know if you can think of other spots where this icon should be used.

Yes, the part that Growth would be responsible for is when the icon appears in Echo Notifications for UserTalk pages.

Do you mean this notification? Or am I misunderstanding the notification type?

image.png (218×1 px, 36 KB)

If this is the correct notification, I think we'd need a separate version of the svg with the temporary user icon for the switch to be possible. In any case, the current icon is available as https://raw.githubusercontent.com/wikimedia/mediawiki-extensions-Echo/master/modules/icons/edit-user-page.svg.

Hmmm, it looks like another team got to this before we did.
I don't know of any other place where the icon is used, so I'll move to QA.

@RHo @Trizek-WMF - please let us know if you can think of other spots where this icon should be used.

Yes, the part that Growth would be responsible for is when the icon appears in Echo Notifications for UserTalk pages.

Do you mean this notification? Or am I misunderstanding the notification type?

image.png (218×1 px, 36 KB)

If this is the correct notification, I think we'd need a separate version of the svg with the temporary user icon for the switch to be possible. In any case, the current icon is available as https://raw.githubusercontent.com/wikimedia/mediawiki-extensions-Echo/master/modules/icons/edit-user-page.svg.

I think we can leave the notification level icon as is, but it would be to replace the user avatar icon with the temp user icon in the "actions" area, ie; next to Martin Urbanec right now, what it is if a temp user left a message on your talk page.

[...]
I think we can leave the notification level icon as is, but it would be to replace the user avatar icon with the temp user icon in the "actions" area, ie; next to Martin Urbanec right now, what it is if a temp user left a message on your talk page.

Ah, that makes sense. Thanks for clarifying!

hah fair enough, this is something that I can file as a request to Design-System-Team + Wikimedia Design Style Guide as they're responsible for the SVG icons in OOUI/Codex.

As you certainly have more influence that tI have there, it would be very nice to have regular updates and upgrades for all icons and design elements we use on wiki. Thank you!

Ahh I found that there is already a task filed for this by one @Trizek-WMF in the DST backlog here T179154 - will update with additional details.

Change 950140 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/Echo@master] EchoEventPresentationModel: Use userTemporary for temp accounts

https://gerrit.wikimedia.org/r/950140

I checked this task and I changed the notification icon as requested, see screenshot (I include all three possible types of actor [anon user/temp user/named user] for reference and comparison):

image.png (744×1 px, 104 KB)

I'm wondering what icon should be used for the anonymous users. In my patch, I kept userAvatar (the one that is used currently in production). That said, MobileFrontend appears to be using userTemporary for temporary accounts, see this diff on cswiki beta as an example.

This might not matter much, as we're effectively phasing out anonymous users, but diffs (and in a limited way, notifications; although it is unlikely someone would want to view old notifications) by anon users will stay with us for longer, I presume.

@RHo @KStoller-WMF Do you have any thoughts on this? Do we want to change the icon for anonymous users as well (and make the two match)? Please feel free to move to Code Review if no further change is needed, or ping me if something is to be changed.

I checked this task and I changed the notification icon as requested, see screenshot (I include all three possible types of actor [anon user/temp user/named user] for reference and comparison):

image.png (744×1 px, 104 KB)

I'm wondering what icon should be used for the anonymous users. In my patch, I kept userAvatar (the one that is used currently in production). That said, MobileFrontend appears to be using userTemporary for temporary accounts, see this diff on cswiki beta as an example.

This might not matter much, as we're effectively phasing out anonymous users, but diffs (and in a limited way, notifications; although it is unlikely someone would want to view old notifications) by anon users will stay with us for longer, I presume.

@RHo @KStoller-WMF Do you have any thoughts on this? Do we want to change the icon for anonymous users as well (and make the two match)? Please feel free to move to Code Review if no further change is needed, or ping me if something is to be changed.

Hi @Urbanecm_WMF, the icon cdxIconUserAnonymous is used for anons/IP editors right now in a bunch of places, but not Echo notifications. It's up to @KStoller-WMF if another task is worth creating to update the icon for anons in Echo, but it would be separate very low prio task so I'm going to move this task to Code Review in the meantime per your suggestion.

In T338912#9101523, @RHo wrote:
It's up to @KStoller-WMF if another task is worth creating to update the icon for anons in Echo, but it would be separate very low prio task so I'm going to move this task to Code Review in the meantime per your suggestion.

I agree this seems very low priority, and I personally don't think it's worth the effort. If anyone disagrees, feel free to create a task for the work and we can discuss further.

Change 950140 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] EchoEventPresentationModel: Use userTemporary for temp accounts

https://gerrit.wikimedia.org/r/950140

Etonkovidova subscribed.

Checked on cswiki betalabs:

a general user picecho notification piccross-wiki echo notification
Screen Shot 2023-09-29 at 10.33.33 AM.png (164×526 px, 8 KB)
Screen Shot 2023-09-29 at 10.37.39 AM.png (612×1 px, 115 KB)
Special:Notifications
Screen Shot 2023-09-29 at 10.49.01 AM.png (576×1 px, 97 KB)
Screen Shot 2023-09-29 at 10.37.26 AM.png (554×1 px, 97 KB)

For a quick check - moving it to Design Review column; if there will be no follow-ups, the task may be closed as Resolved - it was added to T341839: [QA task] IP masking - temp users testing in production for a post-deployment check.

JFernandez-WMF subscribed.

closing this task as resolved - acceptance criteria seems done and I don't see any follow-ups