VisualEditor: ISBN link labels (from magic words) can be changed, but not the underlying links
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Intention:
Change an ISBN.

Steps to Reproduce:

Open a page with a pre-existing ISBN number (using the magic word).

Click in the link and open the link inspector.

Correct the numbers in the ISBN.

Close the link inspector.

Actual Results:
The link label does not change. This is not surprising, given VisualEditor's approach to links, but it is sometimes unfortunate; see https://fr.wikipedia.org/w/index.php?title=Massimo_Introvigne&diff=100272017&oldid=94374615

However, the link itself does not change, and if you have done nothing else, it is not possible to save the page, because you have supposedly made no changes.

Expected Results:
Ideal behavior:

Changing "ISBN 1234567890" to "ISBN 1234567891" simply updates the plain wikitext magic word.

Possibly acceptable behavior:

Changing "ISBN 1234567890" to "ISBN 1234567891" updates the link to [[Special:BookSources/1234567891|ISBN 1234567891]].

Reproducible: Always

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52204

Details

Reference: bz61558

	Subject	Repo	Branch	Lines +/-
	Specialized inspector for ISBN magic links	mediawiki/extensions/VisualEditor	master	+926 -95

Customize query in gerrit

Related Objects

Mentioned In: rEVED7cc23367f6c4: Specialized inspector for ISBN magic links
T54204: Automatically recognise bare links and magic links (ISBN/etc.), and display as a link
T95311: VisualEditor's handling of ISBNs is inconsistent
T56947: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:06 AM

• bzimport added a project: VisualEditor-DataModel.

• bzimport set Reference to bz61558.

• Whatamidoing-WMF created this task.Feb 19 2014, 9:55 PM

Other recent examples of ISBN problems caused by VE (awful syntax, link incoherent with displayed ISBN, nowiki added) :
https://fr.wikipedia.org/w/index.php?title=Bassin_s%C3%A9dimentaire&diff=prev&oldid=104307942
https://fr.wikipedia.org/w/index.php?title=Louis-Jos%C3%A9_Houde&diff=104782988&oldid=104262388

This is a recurring problem on frwiki.

Jdforrester-WMF added a project: VisualEditor.Nov 23 2014, 10:48 PM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 1:24 AM

Jdforrester-WMF added a project: VisualEditor-MediaWiki-Links.Jan 27 2015, 11:52 PM

Aklapper mentioned this in T56947: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too.Feb 19 2015, 6:45 PM

• gpaumier mentioned this in T95311: VisualEditor's handling of ISBNs is inconsistent.Apr 7 2015, 4:37 PM

• gpaumier added a project: VisualEditor 2014/15 Q4 blockers.

• gpaumier set Security to None.

Jdforrester-WMF mentioned this in T54204: Automatically recognise bare links and magic links (ISBN/etc.), and display as a link.Apr 8 2015, 3:24 PM

Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 15 2015, 6:30 PM

Jdforrester-WMF lowered the priority of this task from Medium to Low.Apr 15 2015, 6:52 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF merged a task: T95992: VE detecting ISBN magic word as invalid link.Apr 17 2015, 11:47 PM

Jdforrester-WMF added subscribers: Krenair, Aklapper, Josve05a.

The Parsoid output does not look quite right to me:

<a href="./Special:BookSources/0345318641" rel="mw:ExtLink" data-parsoid='{"stx":"magiclink","dsr":[16,34,0,0]}'>ISBN 0-345-31864-1</a>

ExtLink? That href is for a WikiLink...

ssastry moved this task from Needs Triage to In Progress on the Parsoid board.Apr 28 2015, 6:18 PM

Trizek-WMF subscribed.Jun 1 2015, 9:01 PM

@ssastry, are the problems described in this comment also possibly due to Parsoid? Thank you!

In T63558#1365108, @Elitre wrote:

@ssastry, are the problems described in this comment also possibly due to Parsoid? Thank you!

Looking at [[Special:BookSources/9782981011206|ISBN 978-2-9810112-1-]]<nowiki/>3 .. that looks like VE issues to me. The "3" is not part of the link text so, Parsoid is forced to add a nowiki to preserve HTML semantics. As for editing link text not chaning the underlying link, that is also a VE UX issue.

Jdforrester-WMF edited projects, added VisualEditor 2015/16 Q1 blockers; removed VisualEditor 2014/15 Q4 blockers.Jun 16 2015, 10:21 PM

Jdforrester-WMF moved this task from Freezer to To Triage on the VisualEditor board.Jul 21 2015, 6:18 PM

Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:30 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jul 28 2015, 7:23 PM

@Krenair it's mostly orthogonal to this bug, but we just changed the rel type of ISBN links to mw:WikiLink. I agree that it is more consistent that way.

The VE UX issue still exists: VE should detect edits to ISBN/RFC/PMID links and somehow keep the text and the link in sync. I don't know the best way to do that within the VE codebase.

Krinkle unsubscribed.Aug 20 2015, 7:44 PM

Change 233669 had a related patch set uploaded (by Cscott):
WIP: Specialized inspector for ISBN magic links

https://gerrit.wikimedia.org/r/233669

gerritbot added a project: Patch-For-Review.Aug 25 2015, 8:15 PM

Jdforrester-WMF moved this task from TR1: Releases to TR0: Interrupt on the VisualEditor board.Aug 26 2015, 1:35 AM

Change 233669 had a related patch set uploaded (by Cscott):
Specialized inspector for ISBN magic links

https://gerrit.wikimedia.org/r/233669

Change 233669 merged by jenkins-bot:
Specialized inspector for ISBN magic links

https://gerrit.wikimedia.org/r/233669

cscott mentioned this in rEVED7cc23367f6c4: Specialized inspector for ISBN magic links.Sep 1 2015, 6:35 PM

Jdforrester-WMF closed this task as Resolved.Sep 1 2015, 6:52 PM

Jdforrester-WMF assigned this task to cscott.