Page MenuHomePhabricator
Create Task
Maniphest T92230

Button option to 'choose all/none/reverse' for revdel
Closed, ResolvedPublic
Actions

Description

As an admin, I have to click each buttons when I want to perform revdels. It would be great to have a button to 'choose all/none/reverse' button or such.

Currently Korean Wikipedia is handling this via JavaScript (Screenshot F92777)

Details

SubjectRepoBranchLines +/-
Add toggle checkboxes to action=historymediawiki/coremaster+74 -25
Add links to toggle checkbox selections in Special:Logmediawiki/coremaster+83 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

revi created this task.Mar 10 2015, 5:47 AM
revi raised the priority of this task from to Low.
revi updated the task description. (Show Details)
revi subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2015, 5:47 AM
revi added a project: MediaWiki-Revision-deletion.Mar 10 2015, 5:47 AM
Aklapper renamed this task from Make options to 'choose all' for revdel to Button option to 'choose all/none/reverse' for revdel.Mar 10 2015, 10:57 AM
Aklapper set Security to None.
revi mentioned this in F92777: Implementation of T92230 via JS.Mar 15 2015, 11:45 AM
revi updated the task description. (Show Details)May 31 2015, 6:39 AM
Legoktm added a project: good first task.May 31 2015, 6:42 AM
Legoktm subscribed.

There's already code in the Nuke extension to do this, it should be easy to copy it to core.

TTO subscribed.May 31 2015, 7:17 AM

Isn't the existing shift-click functionality enough, whoughl adding more UI clutter?

IRTC1015 subscribed.May 31 2015, 7:32 AM

There are tablets, smartphones and other devices which don't have shift key.

lfaraone claimed this task.Dec 13 2015, 9:57 PM
lfaraone added a comment.Dec 14 2015, 4:18 AM

Should this be implemented in JS, server-side, or both? (JS default with a server-side fallback)

Legoktm added a comment.Dec 14 2015, 5:14 AM

JS seems fine for now given it's just an enhancement. Server-side would be nice, but that might be non-trivial?

Nemo_bis added a project: Google-Code-In-2015.Jan 7 2016, 9:02 PM
Restricted Application added a subscriber: JEumerus. · View Herald TranscriptJan 7 2016, 9:02 PM
gerritbot subscribed.Jan 14 2016, 8:18 PM

Change 264127 had a related patch set uploaded (by LFaraone):
Add links to toggle checkbox selections in Special:Log

https://gerrit.wikimedia.org/r/264127

gerritbot added a project: Patch-For-Review.Jan 14 2016, 8:18 PM
Legoktm removed a project: Google-Code-In-2015.Jan 14 2016, 8:23 PM
Jdforrester-WMF added a project: Collaboration-Team-Archive-2015-2016.Jan 14 2016, 8:25 PM
gerritbot added a comment.Jan 18 2016, 7:31 AM

Change 264127 merged by jenkins-bot:
Add links to toggle checkbox selections in Special:Log

https://gerrit.wikimedia.org/r/264127

Legoktm added a project: User-notice.Jan 18 2016, 7:34 AM

+user-notice so projects are aware and can remove their JavaScript hacks.

Legoktm closed this task as Resolved.Jan 18 2016, 7:34 AM
revi removed a project: Patch-For-Review.Jan 18 2016, 7:35 AM
Legoktm reopened this task as Open.Jan 18 2016, 7:40 AM

Patch only covered Special:Log, still need something for action=history.

lfaraone added a comment.Jan 18 2016, 7:43 AM
In T92230#1940614, @Legoktm wrote:

Patch only covered Special:Log, still need something for action=history.

Which I'll send out shortly — just wanted to get something small done first :)

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), MW-1.27-release-notes.Jan 18 2016, 8:00 AM
gerritbot added a comment.Jan 19 2016, 1:44 AM

Change 264908 had a related patch set uploaded (by LFaraone):
Add toggle checkboxes to action=history

https://gerrit.wikimedia.org/r/264908

gerritbot added a project: Patch-For-Review.Jan 19 2016, 1:44 AM
Catrope moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Jan 19 2016, 3:07 AM
PeterBowman subscribed.Jan 20 2016, 1:38 AM

@lfaraone: just tested on test.wikipedia.org, I'm seeing these buttons on Special:Log even if no checkboxes are present (which is strange because even if I'm not allowed to revdel I should see the option to add/remove edit tags, now missing - possibly a regression?). BTW I wonder if the buttons could also apply to edit tags on history pages (right now the condition to be met is $user->isAllowed( 'deleterevision' ), this excludes non-sysops).

lfaraone added a comment.Jan 20 2016, 4:22 AM

Hmmm. It doesn't appear when not-logged-in, but does appear when you're a user without administrator rights.

What role on testwiki lets you modify tags besides Admin? Edit Filter Manager doesn't exist on that wiki.

JEumerus added a comment.Jan 20 2016, 7:47 AM

According to https://test.wikipedia.org/wiki/Special:ListGroupRights all users have the ability to change tags there. I know some other main projects also have the ability to tag edits for all users.

Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.Jan 21 2016, 3:00 PM
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Jan 21 2016, 3:50 PM
PeterBowman added a comment.Jan 23 2016, 12:29 AM

It turns out that the change-tags buttons and checkboxes are hidden through CSS on test.wikipedia. Sorry!

MGChecker subscribed.Jan 25 2016, 8:19 PM
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptJan 25 2016, 8:19 PM
Scott subscribed.Jan 27 2016, 3:15 PM
Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Jan 28 2016, 9:45 AM
Johan moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Feb 3 2016, 1:17 PM
SBisson removed a project: Collaboration-Team-Archive-2015-2016.Feb 9 2016, 6:15 PM
gerritbot added a comment.Feb 23 2016, 8:29 AM

Change 264908 merged by jenkins-bot:
Add toggle checkboxes to action=history

https://gerrit.wikimedia.org/r/264908

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 23 2016, 9:00 AM
Krinkle created subtask T131318: Minor issues with 'mediawiki.checkboxtoggle' module.Mar 30 2016, 9:50 PM
• demon closed subtask T131318: Minor issues with 'mediawiki.checkboxtoggle' module as Resolved.Jun 13 2016, 11:17 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 13 2016, 11:17 PM
lfaraone closed this task as Resolved.Jan 29 2017, 10:12 PM
DannyS712 mentioned this in T74544: Invert revision selection on Special:RevisionDelete.Nov 17 2019, 1:49 AM
Ladsgroup edited projects, added User-notice-archive; removed MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), User-notice.Aug 13 2022, 1:55 PM
Restricted Application added a project: User-revi. · View Herald TranscriptAug 13 2022, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL