Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Use new EntityIdValue serialization in JS | mediawiki/extensions/Wikibase | master | +3 -9 | |
Fix mistake in ViewFactory.js | mediawiki/extensions/Wikibase | master | +4 -5 |
Details
Event Timeline
Change 285630 had a related patch set uploaded (by Adrian Heine):
Use new EntityIdValue serialization in JS
Change 300015 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix mistake in ViewFactory.js
I had an other look and as far as I can tell the JavaScript implementation called EntityId was never used. Nowhere.
Selectors/suggesters are using Item and Property objects/stubs, but never an EntityId.
Item and Property are using strings, not EntityIds.
So I suggest to simply merge and release this the moment Wikibase.git depends on DataModel 6.1 (which introduced the "id" key). This can happen any time, somebody just needs to update composer.json to say ~6.1.
EntityId is mentioned by mistake in ViewFactory, which I'm going to fix.
@thiemowmde sound great, thx!
Does that mean we need to do in the following order:
- Use DataModel 6.1 everywhere
- Merge https://github.com/wmde/WikibaseDataModelJavaScript/pull/63 and a release a new version of DataModelJavaScript
- Merge https://gerrit.wikimedia.org/r/#/c/300015/
- Merge https://gerrit.wikimedia.org/r/#/c/285630/
Is that correct?
Yes, except:
- Make sure everything is at least compatible with DataModel 6.1. Since the JavaScript code in question is not used anywhere in our code base, this is to make sure external users (e.g. gadgets) can still deserialize the JSON blobs we provide. The JSON must contain the new "id" key, which requires DataModel 6.1.
- https://gerrit.wikimedia.org/r/300015 is unrelated.
Final steps:
- @Jonas and I decided that https://github.com/wmde/WikibaseDataModelJavaScript/pull/40 will not be in the 3.0 release because it conflicts to much with @adrianheine's patches in Wikibase View.
- https://github.com/wmde/WikibaseDataModelJavaScript/pull/67
- https://github.com/wmde/WikibaseDataModelJavaScript needs a 3.0 release.
- https://github.com/wmde/WikibaseSerializationJavaScript also needs a release.
- https://gerrit.wikimedia.org/r/302253
- https://gerrit.wikimedia.org/r/285630