Page MenuHomePhabricator
Create Task
Maniphest T93172

[Task] Adapt JS Serialization to new EntityIdValue serialization
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Use new EntityIdValue serialization in JSmediawiki/extensions/Wikibasemaster+3 -9
Fix mistake in ViewFactory.jsmediawiki/extensions/Wikibasemaster+4 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT88728 Improve Wikimedia dumping infrastructure
 OpenNoneT88991 improve Wikidata dumps [tracking]
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 InvalidNoneT109969 Wikidata breaking API changes (tracking)
 ResolvedthiemowmdeT56085 [Task] EntityIdValues should be serialized as strings, not type/number structures.
 ResolvedadrianheineT93172 [Task] Adapt JS Serialization to new EntityIdValue serialization

Event Timeline

adrianheine created this task.Mar 19 2015, 8:23 AM
adrianheine raised the priority of this task from to High.
adrianheine updated the task description. (Show Details)
adrianheine added a project: Wikidata.
adrianheine added subscribers: Lucie, Aklapper, Wikidata-bugs and 5 others.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 20 2015, 12:58 PM
Ricordisamoa subscribed.Aug 26 2015, 4:49 PM
Lydia_Pintscher renamed this task from Adapt JS Serialization to new EntityIdValue serialization to [Task] Adapt JS Serialization to new EntityIdValue serialization.Sep 10 2015, 12:32 PM
Lydia_Pintscher set Security to None.
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-04-26.Apr 25 2016, 1:37 PM
thiemowmde moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-04-26 board.Apr 26 2016, 1:10 PM
gerritbot subscribed.Apr 27 2016, 11:41 AM

Change 285630 had a related patch set uploaded (by Adrian Heine):
Use new EntityIdValue serialization in JS

https://gerrit.wikimedia.org/r/285630

gerritbot added a project: Patch-For-Review.Apr 27 2016, 11:41 AM
adrianheine moved this task from Backlog to Review on the Wikidata-Sprint-2016-04-26 board.Apr 27 2016, 11:42 AM
adrianheine claimed this task.Apr 28 2016, 12:56 PM
adrianheine added a comment.May 2 2016, 7:45 AM

https://github.com/wmde/WikibaseDataModelJavaScript/pull/63

Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-05-10.May 10 2016, 11:51 AM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-10 board.May 10 2016, 11:51 AM
Lydia_Pintscher added a project: Wikidata-Sprint-2016-05-24.May 24 2016, 12:40 PM
Addshore moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-24 board.May 24 2016, 12:40 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-05.Jul 5 2016, 12:51 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-07-05 board.Jul 5 2016, 12:53 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-19.Jul 19 2016, 2:30 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-07-19 board.Jul 19 2016, 2:32 PM
gerritbot added a comment.Jul 20 2016, 1:56 PM

Change 300015 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix mistake in ViewFactory.js

https://gerrit.wikimedia.org/r/300015

thiemowmde subscribed.Jul 20 2016, 2:01 PM

I had an other look and as far as I can tell the JavaScript implementation called EntityId was never used. Nowhere.

Selectors/suggesters are using Item and Property objects/stubs, but never an EntityId.

Item and Property are using strings, not EntityIds.

So I suggest to simply merge and release this the moment Wikibase.git depends on DataModel 6.1 (which introduced the "id" key). This can happen any time, somebody just needs to update composer.json to say ~6.1.

EntityId is mentioned by mistake in ViewFactory, which I'm going to fix.

Tobi_WMDE_SW subscribed.Jul 20 2016, 3:08 PM

@thiemowmde sound great, thx!
Does that mean we need to do in the following order:

Is that correct?

thiemowmde added a comment.Jul 21 2016, 1:43 PM

Yes, except:

  • Make sure everything is at least compatible with DataModel 6.1. Since the JavaScript code in question is not used anywhere in our code base, this is to make sure external users (e.g. gadgets) can still deserialize the JSON blobs we provide. The JSON must contain the new "id" key, which requires DataModel 6.1.
  • https://gerrit.wikimedia.org/r/300015 is unrelated.
gerritbot added a comment.Jul 27 2016, 8:26 AM

Change 300015 merged by jenkins-bot:
Fix mistake in ViewFactory.js

https://gerrit.wikimedia.org/r/300015

Lydia_Pintscher moved this task from ready to go to in progress on the Wikidata board.Aug 2 2016, 9:01 AM
thiemowmde added a subscriber: • Jonas.Aug 2 2016, 12:17 PM

Final steps:

thiemowmde added a project: Wikidata-Sprint-2016-08-02.Aug 2 2016, 12:45 PM
thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-08-02 board.Aug 2 2016, 12:46 PM
• Jonas closed this task as Resolved.Aug 3 2016, 10:59 AM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-08-02 board.
gerritbot added a comment.Aug 3 2016, 11:08 AM

Change 285630 merged by jenkins-bot:
Use new EntityIdValue serialization in JS

https://gerrit.wikimedia.org/r/285630

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL