Page MenuHomePhabricator

[Task] Adapt JS Serialization to new EntityIdValue serialization
Closed, ResolvedPublic

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
DuplicateNone
InvalidLydia_Pintscher
OpenNone
OpenNone
StalledNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedthiemowmde
OpenNone
OpenNone
Resolvedthiemowmde
Resolvedadrianheine

Event Timeline

adrianheine raised the priority of this task from to High.
adrianheine updated the task description. (Show Details)
adrianheine added a project: Wikidata.
adrianheine added subscribers: Lucie, Aklapper, Wikidata-bugs and 5 others.
Lydia_Pintscher renamed this task from Adapt JS Serialization to new EntityIdValue serialization to [Task] Adapt JS Serialization to new EntityIdValue serialization.Sep 10 2015, 12:32 PM
Lydia_Pintscher set Security to None.

Change 285630 had a related patch set uploaded (by Adrian Heine):
Use new EntityIdValue serialization in JS

https://gerrit.wikimedia.org/r/285630

Change 300015 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix mistake in ViewFactory.js

https://gerrit.wikimedia.org/r/300015

I had an other look and as far as I can tell the JavaScript implementation called EntityId was never used. Nowhere.

Selectors/suggesters are using Item and Property objects/stubs, but never an EntityId.

Item and Property are using strings, not EntityIds.

So I suggest to simply merge and release this the moment Wikibase.git depends on DataModel 6.1 (which introduced the "id" key). This can happen any time, somebody just needs to update composer.json to say ~6.1.

EntityId is mentioned by mistake in ViewFactory, which I'm going to fix.

@thiemowmde sound great, thx!
Does that mean we need to do in the following order:

Is that correct?

Yes, except:

  • Make sure everything is at least compatible with DataModel 6.1. Since the JavaScript code in question is not used anywhere in our code base, this is to make sure external users (e.g. gadgets) can still deserialize the JSON blobs we provide. The JSON must contain the new "id" key, which requires DataModel 6.1.
  • https://gerrit.wikimedia.org/r/300015 is unrelated.

Change 300015 merged by jenkins-bot:
Fix mistake in ViewFactory.js

https://gerrit.wikimedia.org/r/300015

Jonas closed this task as Resolved.Aug 3 2016, 10:59 AM
Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-08-02 board.

Change 285630 merged by jenkins-bot:
Use new EntityIdValue serialization in JS

https://gerrit.wikimedia.org/r/285630