Page MenuHomePhabricator
Create Task
Maniphest T97758

SVG rendering with marker-element is different between librsvg and Inkscape
Closed, ResolvedPublic
Actions

Description

For details see bug on Gnome Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=476507.

Example: File:Rsvg marker element bug.svg - arrowhead should point in the same direction the curve is going

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedMoritzMuehlenhoffT97758 SVG rendering with marker-element is different between librsvg and Inkscape
 ResolvedMoritzMuehlenhoffT112421 Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues)
 ResolvedKrenairT84950 Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking)
 Resolved• AlexMonk-WMFT64835 Setup a Swift cluster on beta-cluster to match production
 ResolvedfgiunchediT123512 beta swift labs instances requirements
 Resolved• AlexMonk-WMFT140220 "UnderflowException from ... FancyCaptcha.class.php: Ran out of captcha images" at Special:CreateAccount
 ResolvedKrenairT116816 beta cluster missing vips command needed to render tiffs and pngs, pnmtojpeg for DjVus
 ResolvedfgiunchediT142289 Setup deployment-imagescaler host(s) in Beta Cluster
 ResolvedKrenairT142288 Consolidate, remove, and/or downsize Beta Cluster instances to help with [[wikitech:Purge_2016]]
 DeclinedNoneT142255 Move mathoid to deployment-sca* hosts in Beta Cluster
 Resolved• mobrovacT107309 Test Mathoid in Jessie
 ResolvedKrinkleT142152 Move apertium to deployment-sca* hosts in Beta Cluster
 ResolvedKartikMistryT107306 Package apertium (and dependencies) for Jessie
 ResolvedKartikMistryT106385 [Tracker] Move Apertium packaging to Debian
 Resolvedbd808T143065 deployment-sca0[12] puppet failure due to issues involving /srv/deployment directory
 InvalidNoneT142150 Move citoid to deployment-sca* hosts in Beta Cluster
 DeclinedNoneT107302 Package and test Zotero for Jessie
 Resolved• dduvallT138778 Upgrade mariadb in deployment-prep from Precise/MariaDB 5.5 to Jessie/MariaDB 5.10
 Resolved• dduvallT147110 Delete deployment-db1 and deployment-db2

Event Timeline

Menner created this task.May 1 2015, 12:02 PM
Menner raised the priority of this task from to Needs Triage.
Menner updated the task description. (Show Details)
Menner added a project: Wikimedia-SVG-rendering.
Menner subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2015, 12:02 PM
Menner renamed this task from SVG rendering with marker-element different between librsvg and Inkscape to SVG rendering with marker-element is different between librsvg and Inkscape.May 1 2015, 12:02 PM
Menner set Security to None.
Menner added a comment.May 1 2015, 5:41 PM

These libRSVG bugs are that simple to fix. I've patched it myself instead of pressuring someone and explaining me. See bugzilla above.

Menner added a project: Upstream.May 1 2015, 5:43 PM
Perhelion awarded a token.May 9 2015, 4:35 PM
Perhelion subscribed.
Aklapper moved this task from Backlog to Patch merged upstream on the Upstream board.Jul 3 2015, 2:21 PM

Fixed in upstream librsvg; patch will be included in librsvg 2.40.10.

Aklapper changed the task status from Open to Stalled.Aug 9 2015, 3:53 PM

Fix included in version 2.40.10 which got released now. Now need to backport or need to wait for the distribution used on Wikimedia servers to provide that version....

Aklapper mentioned this in T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).Sep 13 2015, 3:15 PM
Ricordisamoa subscribed.Sep 13 2015, 3:33 PM
Krenair subscribed.Sep 13 2015, 6:11 PM
Tgr added a subtask: T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).Sep 13 2015, 9:24 PM
Menner mentioned this in T116824: SVG server-side rendering renders some arrowheads backwards. .Nov 6 2015, 8:32 AM
Menner merged a task: T116824: SVG server-side rendering renders some arrowheads backwards. .Nov 6 2015, 12:14 PM
Menner added subscribers: StudiesWorld, matmarex, Matanya, Nagle.
Tgr subscribed.Dec 2 2015, 8:05 PM

Testcase from the librsvg bug: File:Rsvg marker element bug.svg
Testcase from the merged ticket: File:Adservingsimple.svg (first version of the file)

Tgr updated the task description. (Show Details)Dec 2 2015, 8:09 PM
• DannyH mentioned this in T120746: Improve SVG rendering.Dec 7 2015, 11:08 PM
Aklapper triaged this task as Low priority.Mar 8 2016, 10:39 PM

Was fixed by https://bugzilla.gnome.org/show_bug.cgi?id=476507#c6 for librsvg 2.40.10

MoritzMuehlenhoff subscribed.Jun 22 2016, 1:45 PM

That bug is fixed on the new jessie image scaler using 2.4.16 (tested locally, it's not yet pooled into the set of active scalers in production). I have scaled "Rsvg marker element bug.svg" on the new and the present image scalers and put the results at https://people.wikimedia.org/~jmm/svg/ :

new-arrow.png is the result on the jessie scaler
old-arrow.png is the results with an existing scaler

(The pixel sizes differ slightly to prevent hitting the cached results in favour of a fresh scaler run)

MoritzMuehlenhoff claimed this task.Jun 22 2016, 1:45 PM
MoritzMuehlenhoff added a project: SRE.
MoritzMuehlenhoff closed this task as Resolved.Jul 4 2016, 2:45 PM

The trusty-based image scalers have now been disabled, so I'm marking this task as resolved.

MoritzMuehlenhoff closed subtask T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues) as Resolved.Jul 4 2016, 2:46 PM
Tgr added a comment.Jul 4 2016, 7:21 PM
In T97758#1845685, @Tgr wrote:

Testcase from the librsvg bug: File:Rsvg marker element bug.svg
Testcase from the merged ticket: File:Adservingsimple.svg (first version of the file)

The second is fixed now but the first still seems broken.

Menner added a comment.Jul 4 2016, 7:35 PM

@Tgr: be patient. Now [[File:Rsvg marker element bug.svg]] is borken again too. Although it work fine recently.

MoritzMuehlenhoff added a comment.Jul 7 2016, 7:17 AM

@Menner, @Tgr: Fixed. For confirmation I have re-triggered the generation of File:Rsvg marker element bug.svg five times and it was always rendered correctly. The reason that it partly returned the old version, was an oversight on my side; some of jessie scalers were still using the standard version of librsvg as shipped in Debian jessie, as some of the servers had been installed prior to the upgrade of librsvg. All new image scaler installations will use the new librsvg from the start.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL