Page MenuHomePhabricator
Feed Advanced Search

Dec 16 2020

Isarra added a comment to T256511: Remove SkinTemplateToolboxEnd hook.

Skins don't need to concern themselves with hooks, they just need to use the methods in core.

Dec 16 2020, 8:48 PM · MW-1.37-release, MediaWiki-extensions-Duplicator, Patch-For-Review, MediaWiki-skins-Foreground, WPtouch, MediaWiki-skins-p2wiki, MediaWiki-skins-Erudite, Truglass, Metrolook, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet, Apex, WikiArticleFeeds, BlueSpice, MediaWiki-extensions-CreateRedirect, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T238834: ULS message about changed language goes under the header when language is changed.

(And to check the menu... type, you still need to check for multiple possibilities. The block containing the trigger may be display-noned most of the time. It may just be off the page in some crazy -9999px left or something. Some skins, like timeless, may do both at different resolutions.)

Dec 16 2020, 8:44 PM · Patch-Needs-Improvement, Timeless, UniversalLanguageSelector
Isarra added a comment to T238834: ULS message about changed language goes under the header when language is changed.

So the problem is, this part of ULS isn't going to behave correctly in terms of positioning in any skin that uses a dropdown for the personal menu. This'll happen in any of them. Never even mind the fixed header winding up over it on timeless, the thing showing up behind the menu on hover is actually a bit of a mercy compared to how it always appears, covering up the rest of the menu, when trying to get to the rest of the menu, if the layering is fixed...

Dec 16 2020, 8:39 PM · Patch-Needs-Improvement, Timeless, UniversalLanguageSelector
Isarra removed a project from T266891: Port Splash global nav fixes to all the other skins with the same menu: WoOgLeShades.
Dec 16 2020, 7:42 PM · HasSomeColours, Splash
Isarra added a comment to T256511: Remove SkinTemplateToolboxEnd hook.

Is this the deprecatedHookHack stuff in getPortlet?

Dec 16 2020, 6:01 AM · MW-1.37-release, MediaWiki-extensions-Duplicator, Patch-For-Review, MediaWiki-skins-Foreground, WPtouch, MediaWiki-skins-p2wiki, MediaWiki-skins-Erudite, Truglass, Metrolook, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet, Apex, WikiArticleFeeds, BlueSpice, MediaWiki-extensions-CreateRedirect, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T256511: Remove SkinTemplateToolboxEnd hook.

Gonna be honest, I don't even remotely understand the skin stuff that supports this. So I dunno how to remove it. >.>

Dec 16 2020, 5:09 AM · MW-1.37-release, MediaWiki-extensions-Duplicator, Patch-For-Review, MediaWiki-skins-Foreground, WPtouch, MediaWiki-skins-p2wiki, MediaWiki-skins-Erudite, Truglass, Metrolook, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet, Apex, WikiArticleFeeds, BlueSpice, MediaWiki-extensions-CreateRedirect, MediaWiki-Core-Skin-Architecture

Dec 15 2020

Isarra created T270217: Ensure proper distinctions between links of various types and states.
Dec 15 2020, 9:53 PM · Splash
Isarra added a comment to T269550: Adjust spacing for page status indicators.

Or... three.

Dec 15 2020, 9:01 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra added a comment to T269550: Adjust spacing for page status indicators.

(Reopen if it still seems off in a week or two when deployed, I suppose.)

Dec 15 2020, 9:00 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra closed T269550: Adjust spacing for page status indicators as Resolved.

This doesn't solve the weird ptag template on mw.org, but I gave up on that ever making sense years ago.... should be more accurate for most normal use, though.

Dec 15 2020, 9:00 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra moved T260383: Better dark mode support for action icons in Timeless skin from Backlog to In progress, or perhaps should be on the Timeless board.
Dec 15 2020, 8:56 PM · Timeless
Isarra moved T269550: Adjust spacing for page status indicators from Backlog to In progress, or perhaps should be on the Timeless board.
Dec 15 2020, 8:56 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra moved T269912: New table scroll slight visual "tweaks"? from Backlog to In progress, or perhaps should be on the Timeless board.
Dec 15 2020, 8:55 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra closed T173530: Narrowness issues on wikisource as Invalid.

Okay yeah I'm filing that under user error. >.>

Dec 15 2020, 8:55 PM · Timeless
Isarra moved T131991: Implement theme support and add 'winter' and 'night' variants from Features to In progress, or perhaps should be on the Timeless board.
Dec 15 2020, 8:54 PM · Timeless
Isarra moved T131803: Options to only use a specific layout/not go bigger - single-column with only dropdown menus, or one sidebar-only from Features to In progress, or perhaps should be on the Timeless board.
Dec 15 2020, 8:54 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Timeless
Isarra moved T269913: Table scroll kills collapsing with mw-collapsible-content from Backlog to In progress, or perhaps should be on the Timeless board.
Dec 15 2020, 8:53 PM · Timeless
Isarra moved T238834: ULS message about changed language goes under the header when language is changed from Backlog to Compatibility on the Timeless board.
Dec 15 2020, 8:52 PM · Patch-Needs-Improvement, Timeless, UniversalLanguageSelector
Isarra closed T181177: Hovered links don't distinguish sufficiently from visited links in Timeless as Resolved.
Dec 15 2020, 8:52 PM · Patch-For-Review, Accessibility, Timeless
Isarra moved T253370: Improve collapsible sections styles on m. domain in Timeless and other non-Minerva skins from Backlog to Compatibility on the Timeless board.
Dec 15 2020, 8:52 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), patch-welcome, Timeless
Isarra closed T181192: "External" links hovered over don't have indication of hover in Timeless as Resolved.
Dec 15 2020, 8:52 PM · Patch-For-Review, Accessibility, Timeless
Isarra moved T260842: Special:ContentTranslationStats is mostly blank in Timeless skin from Backlog to Compatibility on the Timeless board.
Dec 15 2020, 8:52 PM · ContentTranslation, Timeless
Isarra moved T253371: Enhanced RC on Timeless with MF does not show expansion arrows from Backlog to Compatibility on the Timeless board.
Dec 15 2020, 8:52 PM · MobileFrontend (Tracking), Timeless
Isarra closed T265205: Mobile: Language toggle visible when no other languages available as Resolved.

Turns out something changed.

Dec 15 2020, 8:51 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Timeless
Isarra closed T270050: Make overflowing table scrollbars sticky at bottom of screen as Resolved.

:DDD

Dec 15 2020, 8:50 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra closed T259136: OOUI *MultiselectWidgets (inputs) have unwanted margin on Timeless as Resolved.
Dec 15 2020, 8:10 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), affects-translatewiki.net, MediaWiki-Blocks, OOUI, Timeless
Isarra closed T234305: WikiLove doesn't have a word in wide mode as Declined.

Given I was seriously considering removing even the option of using a word in timeless in the name of saving space, I'm just gonna decline this one. >.>

Dec 15 2020, 8:06 PM · Timeless
Isarra created T270211: Variants dropdown not properly set up.
Dec 15 2020, 7:39 PM · Timeless
Isarra changed the status of T241508: Graphic bug on template documentation from Open to Stalled.
Dec 15 2020, 7:18 PM · Timeless
Isarra added a comment to T241508: Graphic bug on template documentation .

Can someone verify if this is still an issue? I can't reproduce now, but if it's just been fixed locally, it could still perhaps use adjusting skin-side, depending on what it is...

Dec 15 2020, 7:17 PM · Timeless
Isarra added a comment to T265205: Mobile: Language toggle visible when no other languages available.

The languages menus are only supposed to be showing up like this when no languages are there to support tools like wikibase adding/editing links via the menu.

Dec 15 2020, 6:35 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Timeless
Isarra added a comment to T173240: Make the fixed header optional.

So for our explosion of user settings here, we're potentially looking at:

  • checkbox: enable fixed-position header (this)
  • select: column-layout T131803
  • select: theme T131991
  • checkbox: disable max-width for text pages T231459
Dec 15 2020, 5:43 PM · Timeless
Isarra added a comment to T269912: New table scroll slight visual "tweaks"?.

Hmm, we might be able to change the position of the shadows, and do some horrible hacks to the caption to get it to cooperate after all...

Dec 15 2020, 4:49 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra closed T201734: Wikidata tables overflow content area in Timeless as Resolved.
Dec 15 2020, 4:47 PM · Wikidata, Timeless
Isarra renamed T257717: Wikidata property value styles are not responsive and have massive excess padding/margin across resolutions from Wikidata property values only display one letter per line (Timeless skin/mobile) to Wikidata property value styles are not responsive and have massive excess padding/margin across resolutions.
Dec 15 2020, 4:45 PM · Wikidata, Timeless
Isarra moved T257717: Wikidata property value styles are not responsive and have massive excess padding/margin across resolutions from Backlog to Compatibility on the Timeless board.
Dec 15 2020, 4:39 PM · Wikidata, Timeless
Isarra updated the task description for T232675: Turn sitename in header into navigation dropdown toggle.
Dec 15 2020, 4:36 PM · Timeless
Isarra closed T132003: Column balance seems off as Resolved.

Good enough probably.

Dec 15 2020, 4:33 PM · Timeless
Isarra closed T193523: 'More' page tools dropdown in mobile renders incorrectly on special pages as Resolved.

Pictured issue appears to have been resolved at some point.

Dec 15 2020, 4:08 PM · Timeless
Isarra added a comment to T270050: Make overflowing table scrollbars sticky at bottom of screen .

I was wrong, this turned out to be a lot simpler than I thought. I... think.

Dec 15 2020, 7:32 AM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless

Dec 14 2020

Isarra closed T161479: Timeless and ProofreadPage compatibility as Resolved.

Yeah, seems fine now...

Dec 14 2020, 11:12 PM · ProofreadPage, Timeless
Isarra closed T269970: image embeds failing with Timeless skin as Resolved.
Dec 14 2020, 9:16 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Timeless
Isarra closed T181321: Mobile rules to keep images from overflowing (due to small screens) mess up templates as Resolved.

Yeeeeah. Maybe.

Dec 14 2020, 9:16 PM · Timeless
Isarra updated subscribers of T270050: Make overflowing table scrollbars sticky at bottom of screen .

In T179265#6688944, @1997kB wrote:
Tables like https://en.wikipedia.org/wiki/Wikipedia:Sockpuppet_investigations are no more workable on desktop as one has to go all the way to the bottom for horizontal scroll. Maybe make the table scroll with mouse?

Dec 14 2020, 8:10 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra added a comment to T179265: No scrollbars on mobile tables.

Tables like https://en.wikipedia.org/wiki/Wikipedia:Sockpuppet_investigations are no more workable on desktop as one has to go all the way to the bottom for horizontal scroll. Maybe make the table scroll with mouse?

Dec 14 2020, 8:09 PM · Timeless
Isarra added a comment to T235459: Timeless treatment of <h2> is somewhat different than Vector.

I've done this now for Timeless in the TemplateStyles page as a workaround.

Dec 14 2020, 8:05 PM · Timeless
Isarra added a comment to T269912: New table scroll slight visual "tweaks"?.

Okay maybe 2 is possible but it scares the bejeezers out of me so I'm just gonna pretend it isn't.

Dec 14 2020, 5:22 AM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra closed T265785: Tableaux triables hors cadre / Sorting tables overflowing frame as Resolved.

Eeeeh technically... ish. >.>

Dec 14 2020, 5:18 AM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Timeless
Isarra added a comment to T269913: Table scroll kills collapsing with mw-collapsible-content.

Okay, I have noooo idea if the above will actually fix this or not. Given the stickytableheaders gadget appears totally unaffected (as in, still broken) I'm not hopeful. Then again that might actually be the css not getting along, so maybe cleaned up js will help this?

Dec 14 2020, 4:59 AM · Timeless

Dec 13 2020

Isarra added a comment to T269912: New table scroll slight visual "tweaks"?.
  1. When displaying a standard wiki table with caption, there is a border around the caption that I'm pretty sure was not there before. I don't think the bar should cause that border.
  2. I think the "scroll" bar probably should extend to the top of the tbody rather than the top of the table. Or at least the top of the highest headers rather than the caption. The bar causes otherwise good whitespace to be a sad grayspace extending past what looks to be the visible table, until you realize the caption is there.
Dec 13 2020, 9:39 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra added a comment to T181321: Mobile rules to keep images from overflowing (due to small screens) mess up templates.

Well, the tables exclusion should fix this for infoboxes if other sites' infoboxes are like enwp's, whatever it is. Not that enwp's infoboxes seem affected?

Dec 13 2020, 9:11 PM · Timeless
Isarra moved T266891: Port Splash global nav fixes to all the other skins with the same menu from Backlog to Bugs on the WoOgLeShades board.
Dec 13 2020, 6:25 PM · HasSomeColours, Splash
Isarra moved T257939: Make global links menu appear in all languages based on wiki language default (if not set in others) from Backlog to Bugs on the WoOgLeShades board.
Dec 13 2020, 6:25 PM · WoOgLeShades
Isarra moved T259289: Make box shadows work in safari from Backlog to Bugs on the WoOgLeShades board.
Dec 13 2020, 6:25 PM · WoOgLeShades
Isarra added a comment to T253371: Enhanced RC on Timeless with MF does not show expansion arrows.

I think targeting both mobile and desktop makes sense here

Dec 13 2020, 6:04 PM · MobileFrontend (Tracking), Timeless
Isarra moved T173240: Make the fixed header optional from Features to In progress, or perhaps should be on the Timeless board.
Dec 13 2020, 5:55 PM · Timeless
Isarra created T270050: Make overflowing table scrollbars sticky at bottom of screen .
Dec 13 2020, 5:54 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Timeless
Isarra created T270048: Add jump to top and jump to bottom buttons.
Dec 13 2020, 5:51 PM · Splash
Isarra added a comment to T161953: Incorporate WoOgLeShades global navigation design into Timeless.

Uuuuugh I wanna decline this as the existing layout doesn't lend itself well to it and I don't want to fix it, and just say Timeless isn't a skin targetted at wikifarms, but it's... actually deployed on a couple of pretty big ones?

Dec 13 2020, 5:48 PM · Timeless
Isarra closed T211394: Minimise total height of navigation across all modes, especially single-column desktop as Declined.

I don't care anymore. If anyone has actual problems they can file a new one with the problems. >.>

Dec 13 2020, 5:45 PM · Timeless
Isarra moved T232675: Turn sitename in header into navigation dropdown toggle from In progress, or perhaps should be to Features on the Timeless board.
Dec 13 2020, 5:45 PM · Timeless
Isarra added a comment to T270012: Monobook external link icon has disappeared in responsive version of Monobook.

...okay, because this was nagging at me and weird and I realised what I did wrong the first time, I went and corrently checkout out the deployed core/extensions/whatever pile currently live on wikimedia (rMW340b2be45285), and... nope, still can't replicate locally.

Dec 13 2020, 4:05 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Regression, MonoBook
Isarra added a comment to T270012: Monobook external link icon has disappeared in responsive version of Monobook.

(Don't worry, though, someone with half a brain should look at this at some point and they should be able to figure it out. >.>)

Dec 13 2020, 3:20 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Regression, MonoBook
Isarra added a comment to T270012: Monobook external link icon has disappeared in responsive version of Monobook.

Scratch that I can't get this version of core to work at all because... vendor doesn't appear to be up to date? I dunno, none of this makes any sense to me, I'm at the end of my rope.

Dec 13 2020, 3:15 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Regression, MonoBook
Isarra added a comment to T270012: Monobook external link icon has disappeared in responsive version of Monobook.

Okay, checking out the same commit, I seriously cannot replicate this. The styles are there, locally. They're just plain not there on wikimedia?

Dec 13 2020, 3:07 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Regression, MonoBook
Isarra added a comment to T270012: Monobook external link icon has disappeared in responsive version of Monobook.

Definitely seeing this on enwp and eswp on monobook, but not vector. (And I ain't logged in, this is just with useskin.)

Dec 13 2020, 3:00 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Regression, MonoBook

Dec 12 2020

Isarra removed a project from T269626: Remove deprecated mediawiki.skinning.content.externallinks module: GreyStuff.
Dec 12 2020, 10:18 PM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, good first task, patch-welcome, MW-1.39-release
Isarra added a comment to T269905: Echo badges too high.

Maybe next time I'll actually bother to tag all the skins affected that all need the same fix... that might be more useful.

Dec 12 2020, 10:08 PM · GreyStuff
Isarra closed T269905: Echo badges too high as Resolved.

Okay fixed here.

Dec 12 2020, 10:06 PM · GreyStuff
Isarra added a comment to T269905: Echo badges too high.

Nope, this is just the top: -5px positioning that every skin but vector pretty much has to override back to 0. (Okay, MonoBook did -1px, but it'd be fine at 0.)

Dec 12 2020, 9:31 PM · GreyStuff
Isarra added a comment to T269970: image embeds failing with Timeless skin.

Okay, so trying to duplicate this locally, it looks like it's not that images break in tables with timeless' new styles, but rather that these new styles combined with the wikipedia tmbox (etc) styles break. So I'm really hoping that is still just in tables...

Dec 12 2020, 8:41 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Timeless
Isarra closed T113984: Deal with excess of visible tools in mobile as Resolved.
Dec 12 2020, 8:19 PM · GreyStuff
Isarra closed T162502: GreyStuff link colour blends into text colour, especially visited as Resolved.

Probably.

Dec 12 2020, 8:19 PM · GreyStuff
Isarra closed T132050: Make font sizes consistent as Resolved.
Dec 12 2020, 8:19 PM · GreyStuff
Isarra added a comment to T269970: image embeds failing with Timeless skin.

But seriously, keep the weirdness coming, man. This is really helpful!

Dec 12 2020, 1:25 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Timeless
Isarra added a comment to T269970: image embeds failing with Timeless skin.

The difference with mbox is the text vanishes, not the images.

Dec 12 2020, 1:24 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Timeless

Dec 11 2020

Isarra added a comment to T269970: image embeds failing with Timeless skin.

Specifically can be seen here: https://en.wikipedia.org/wiki/User:Gwenhope?useskin=timeless

Dec 11 2020, 10:26 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Timeless
Isarra closed T165442: Use core BaseTemplate functions where applicable; deprecate duplicate copies as Resolved.
Dec 11 2020, 4:35 AM · GreyStuff
Isarra closed T132052: Add more padding to link bars as Resolved.
Dec 11 2020, 4:35 AM · GreyStuff
Isarra renamed T266891: Port Splash global nav fixes to all the other skins with the same menu from Port global nav fixes to all the other skins with the same menu to Port Splash global nav fixes to all the other skins with the same menu.
Dec 11 2020, 2:13 AM · HasSomeColours, Splash
Isarra added projects to T266891: Port Splash global nav fixes to all the other skins with the same menu: HasSomeColours, WoOgLeShades.
Dec 11 2020, 2:12 AM · HasSomeColours, Splash
Isarra created T269905: Echo badges too high.
Dec 11 2020, 12:23 AM · GreyStuff

Dec 10 2020

Isarra closed T182515: Style sitenotice as Resolved.

This was fixed... at some point.

Dec 10 2020, 11:31 PM · GreyStuff
Isarra created T269892: Hide dropdown menus without removing them from display for screenreader etc support.
Dec 10 2020, 9:25 PM · GreyStuff
Isarra created T269891: Mobile menus need nojs fallback.
Dec 10 2020, 9:24 PM · GreyStuff
Isarra closed T132051: Add $this->getIndicators(); as Resolved.
Dec 10 2020, 6:57 PM · GreyStuff
Isarra closed T165441: Check backwards compatibility of GreyStuff as Declined.

Okay, older versions work fine pre-1.35, current should still work with 1.35, we'll shortly make it 1.36+, I reaaaaally don't even care anymore.

Dec 10 2020, 5:13 AM · GreyStuff
Isarra added a comment to T165441: Check backwards compatibility of GreyStuff.

Okay, I checked. It's not backwards compatible. Good day.

Dec 10 2020, 5:12 AM · GreyStuff
Isarra moved T162502: GreyStuff link colour blends into text colour, especially visited from Backlog to Needs implementing on the GreyStuff board.
Dec 10 2020, 4:50 AM · GreyStuff
Isarra updated the image for GreyStuff from F3272435: profile to F33941417: profile.
Dec 10 2020, 4:18 AM
Isarra closed T132047: Username in header may be a security hole as Invalid.

Yeah okay looks fine.

Dec 10 2020, 3:28 AM · GreyStuff
Isarra merged task T165449: Ensure page status indicators are present in GreyStuff into T132051: Add $this->getIndicators();.
Dec 10 2020, 12:54 AM · GreyStuff
Isarra merged T165449: Ensure page status indicators are present in GreyStuff into T132051: Add $this->getIndicators();.
Dec 10 2020, 12:54 AM · GreyStuff
Isarra closed T132055: ToC bottom border lingers when collapsed as Resolved.

Given there's no top border anymore... this is effectively resolved!

Dec 10 2020, 12:53 AM · GreyStuff
Isarra added a comment to T113986: Mobile missing logo.

Though now that we have wordmarks maybe this is fine?

Dec 10 2020, 12:52 AM · GreyStuff
Isarra closed T132045: Add fallback css for IE8 support as Invalid.

When you wait long enough, problems resolve themselves by becoming irrelevant.

Dec 10 2020, 12:20 AM · Browser-Support-Internet-Explorer, GreyStuff

Dec 9 2020

Isarra added a comment to T213342: Come up with less stupid approach to line svgs.

Pseudoelements! Nevermind svg capabilities, just pseudoelement everything!

Dec 9 2020, 9:21 PM · Anisa
Isarra closed T113988: Re-evaluate if reusing vector etc logo image for this is even a good idea as Declined.

Eeeeh all the skins do this now. Well, all of mine. :P

Dec 9 2020, 9:19 PM · GreyStuff
Isarra moved T221412: Implement content styles from Backlog to Features on the Mask board.
Dec 9 2020, 9:17 PM · Mask
Isarra moved T221415: Put echo icons somewhere reasonable from Backlog to Compatibility on the Mask board.
Dec 9 2020, 9:17 PM · Mask