Page MenuHomePhabricator
Feed Advanced Search

Nov 4 2021

mmodell added a project to T291593: give visibility for "in progress" tasks on a work board: Release-Engineering-Team (Done by Thu 04 Nov 🧟).
Nov 4 2021, 2:09 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell set the point value for T294998: Phabricator Project Reports have inaccurate counts for the age histogram to 1.
Nov 4 2021, 2:06 AM · Phabricator (2024-01-16), Release-Engineering-Team (Priority Backlog 📥)
mmodell created T294998: Phabricator Project Reports have inaccurate counts for the age histogram.
Nov 4 2021, 2:04 AM · Phabricator (2024-01-16), Release-Engineering-Team (Priority Backlog 📥)

Nov 3 2021

mmodell set Final Story Points to 1 on T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters.
Nov 3 2021, 10:22 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell closed T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters as Resolved.
Nov 3 2021, 10:22 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell moved T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters from Waiting for review to Done on the Release-Engineering-Team (Done by Thu 04 Nov 🧟) board.
Nov 3 2021, 10:22 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell awarded P17656 (An Untitled Masterwork) a Love token.
Nov 3 2021, 4:01 PM

Nov 2 2021

mmodell updated subscribers of T292094: Limit GitLab shared runners to trusted contributors.

My current understanding is that only users with Developer-level access to the project are allowed to run jobs:

https://docs.gitlab.com/ee/user/permissions.html#job-permissions

I think, however, I need to build a working example of exactly what happens here. I'll call that out as a next step here.

Nov 2 2021, 4:19 PM · Release-Engineering-Team (Done by Wed 24 Nov 🧟), SecTeam-Processed, Security-Team, User-brennen, GitLab (CI & Job Runners)

Oct 30 2021

mmodell committed rPHTRbb304b5a66aa: Ran `arc liberate` to introduce new translation classes.
Ran `arc liberate` to introduce new translation classes
Oct 30 2021, 9:06 AM

Oct 29 2021

mmodell added a comment to P17637 Fileimporter$ npm run selenium-test error.

It looks like the ffmpeg arguments are wrong for the requested screen size - 1280x1024 is taller than 1366x768 so it can't capture a 1024 pixel height.

Oct 29 2021, 11:53 PM
mmodell committed rPHDEP98f10da1caac: updated submodules.
updated submodules
Oct 29 2021, 12:14 PM
mmodell committed rPHTR2136cad4dd4f: Updated translations and re-exported strings / variable locations.
Updated translations and re-exported strings / variable locations
Oct 29 2021, 8:02 AM
mmodell moved T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters from In progress to Waiting for review on the Release-Engineering-Team (Done by Thu 04 Nov 🧟) board.
Oct 29 2021, 7:53 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell awarded T294594: PHP Notice: Undefined index: error-html a Orange Medal token.
Oct 29 2021, 7:33 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), MediaWiki-extensions-FlaggedRevs, Wikimedia-production-error
mmodell added a comment to T245575: Dockerize our Phabricator development environment.

@Sj I am one of the founding members of the forge project and I've been nominally working with them upstream, though I haven't put a lot of time into it yet.

Oct 29 2021, 7:31 AM · Release-Engineering-Team (Yak Shaving 🐃🪒), User-brennen, Phabricator

Oct 28 2021

mmodell created T294594: PHP Notice: Undefined index: error-html.
Oct 28 2021, 8:00 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), MediaWiki-extensions-FlaggedRevs, Wikimedia-production-error
mmodell added a comment to T294544: FlaggedRevs does not work in german wiktionary.

Thanks for the confirmation!

Oct 28 2021, 7:58 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), User-xSavitar, MediaWiki-extensions-FlaggedRevs
mmodell awarded T294544: FlaggedRevs does not work in german wiktionary a Orange Medal token.
Oct 28 2021, 7:57 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), User-xSavitar, MediaWiki-extensions-FlaggedRevs
mmodell added a comment to T294544: FlaggedRevs does not work in german wiktionary.

Can anyone confirm if this is still happening?

Oct 28 2021, 7:56 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), User-xSavitar, MediaWiki-extensions-FlaggedRevs
mmodell reassigned T294559: Editing page ending with :number or going to such page via a namespace alias results in redirect to address with :number used as port from mmodell to Urbanecm.
Oct 28 2021, 7:56 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Urbanecm, Platform Engineering, WMF-General-or-Unknown, Regression, Wikimedia-production-error, MediaWiki-General
mmodell closed T294559: Editing page ending with :number or going to such page via a namespace alias results in redirect to address with :number used as port as Resolved.
Oct 28 2021, 7:56 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Urbanecm, Platform Engineering, WMF-General-or-Unknown, Regression, Wikimedia-production-error, MediaWiki-General
mmodell added a comment to T294559: Editing page ending with :number or going to such page via a namespace alias results in redirect to address with :number used as port.

The revert seems to have resolved this issue.

Oct 28 2021, 7:55 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Urbanecm, Platform Engineering, WMF-General-or-Unknown, Regression, Wikimedia-production-error, MediaWiki-General
mmodell closed T294559: Editing page ending with :number or going to such page via a namespace alias results in redirect to address with :number used as port, a subtask of T293947: 1.38.0-wmf.6 deployment blockers, as Resolved.
Oct 28 2021, 7:55 PM · Patch-For-Review, Release-Engineering-Team (Done by Thu 04 Nov 🧟), Release, Train Deployments
mmodell added a comment to T293947: 1.38.0-wmf.6 deployment blockers.

Indeed it's blocked but getting unblocked soon I hope?

Oct 28 2021, 7:32 PM · Patch-For-Review, Release-Engineering-Team (Done by Thu 04 Nov 🧟), Release, Train Deployments
mmodell updated TrainSubscriberBot.
Oct 28 2021, 4:42 PM
mmodell moved T294559: Editing page ending with :number or going to such page via a namespace alias results in redirect to address with :number used as port from Untriaged to Oct 2021 on the Wikimedia-production-error board.
Oct 28 2021, 1:54 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Urbanecm, Platform Engineering, WMF-General-or-Unknown, Regression, Wikimedia-production-error, MediaWiki-General

Oct 27 2021

mmodell moved T294336: Mentor dashboard: TypeError: Cannot read properties of null (reading 'getIcon') from Untriaged to Oct 2021 on the Wikimedia-production-error board.
Oct 27 2021, 6:48 PM · GrowthExperiments-Mentorship, MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), JavaScript, Wikimedia-production-error, Growth-Team, GrowthExperiments-MentorDashboard
mmodell moved T294401: [minor] "User is no longer logged in" when attempting to publish add link edits from Untriaged to Oct 2021 on the Wikimedia-production-error board.
Oct 27 2021, 6:47 PM · Growth-Team, GrowthExperiments, Wikimedia-production-error
mmodell moved T294411: undefined is not an object (evaluating 'this.tabs[tabName].disabled') from Untriaged to Oct 2021 on the Wikimedia-production-error board.
Oct 27 2021, 6:46 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), SDAW-MediaSearch, Structured-Data-Backlog (Current Work), Wikimedia-production-error
mmodell moved T293295: PHP Warning: The locally stored wiki page '[page]' has unsupported content model (from Dashiki) from Untriaged to Oct 2021 on the Wikimedia-production-error board.
Oct 27 2021, 6:46 PM · Data-Engineering, Product-Infrastructure-Team-Backlog-Deprecated, JsonConfig, Wikimedia-production-error
mmodell created T294467: Error: Call to a member function insertBefore() on null in ImageMap class.
Oct 27 2021, 6:18 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), ImageMap, Wikimedia-production-error

Oct 20 2021

mmodell moved T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters from Backlog to In progress on the Release-Engineering-Team (Done by Thu 04 Nov 🧟) board.
Oct 20 2021, 7:10 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell added a comment to T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters.

This is a straightforward and simple bugfix.

Oct 20 2021, 5:41 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell claimed T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters.
Oct 20 2021, 5:39 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator

Oct 19 2021

mmodell moved T291978: Limit GitLab shared runners to images from Wikimedia Docker registry from Done by Wed 06 Oct to Priority Backlog 📥 on the Release-Engineering-Team board.
Oct 19 2021, 7:18 PM · Release-Engineering-Team (GitLab-a-thon 🦊), Security-Team, User-brennen, GitLab (CI & Job Runners), Security
mmodell awarded T293604: Puppet failure on phabricator-prod-1001.devtools.eqiad1.wikimedia.cloud a Mountain of Wealth token.
Oct 19 2021, 11:43 AM · Patch-For-Review, Phabricator
mmodell closed T293604: Puppet failure on phabricator-prod-1001.devtools.eqiad1.wikimedia.cloud as Resolved.

Thanks for the fix!

Oct 19 2021, 11:43 AM · Patch-For-Review, Phabricator
mmodell added a comment to T191865: Deploy "Due Dates" / Deadlines feature.

More than a year too late but...

Oct 19 2021, 11:37 AM · Release-Engineering-Team (Kanban), Phabricator
mmodell added a project to T293734: Make assignees or setters of a past Due Date on a non-closed task more aware of that task: Release-Engineering-Team (Next).
Oct 19 2021, 11:34 AM · Release-Engineering-Team (Priority Backlog 📥), Phabricator
mmodell archived Phabricator (2021-03-24).
Oct 19 2021, 11:32 AM
mmodell added a comment to T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters.

the link is missing the project phid.. Example the 5 weeks link should look like:

Oct 19 2021, 11:13 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell triaged T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters as High priority.
Oct 19 2021, 11:08 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell changed the subtype of T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters from "Task" to "Bug Report".
Oct 19 2021, 11:08 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell moved T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters from INBOX to Priority Backlog 📥 on the Release-Engineering-Team board.
Oct 19 2021, 11:07 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell edited projects for T265617: Experiment with GitLab-Phabricator integration, added: Release-Engineering-Team (Next); removed Release-Engineering-Team (Done by Wed 06 Oct).
Oct 19 2021, 11:04 AM · Release-Engineering-Team (Priority Backlog 📥), serviceops-radar, GitLab (Integrations), Phabricator, User-brennen, GitLab-Test
mmodell edited projects for T288381: Connect WikiBugs IRC bot to Wikimedia GitLab, added: Release-Engineering-Team (Next); removed Release-Engineering-Team (Done by Wed 06 Oct).
Oct 19 2021, 11:04 AM · User-bd808, Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs
mmodell placed T288381: Connect WikiBugs IRC bot to Wikimedia GitLab up for grabs.
Oct 19 2021, 11:02 AM · User-bd808, Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs

Oct 14 2021

mmodell updated the task description for T89945: Merge to deployed branches instead of cutting a new deployment branch every week..
Oct 14 2021, 11:36 PM · RelEng-Archive-FY201718-Q2, Release-Engineering-Team (Long-Lived-Branches), releng-201617-q1, Deployments, Epic

Oct 13 2021

mmodell added a project to T148805: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards: Release-Engineering-Team (Priority Backlog 📥).
Oct 13 2021, 4:57 PM · Release-Engineering-Team (Priority Backlog 📥), Data³, Phabricator

Oct 8 2021

mmodell added a comment to T265617: Experiment with GitLab-Phabricator integration.

So one thing I think that we need is the equivalent to the "gerrit patches" table that shows up in phabricator for any gerrit patches tagged with Bug: Tnnn I suppose we could use the exact same convention, we just need a way to query gitlab for matching MRs...

Oct 8 2021, 6:21 PM · Release-Engineering-Team (Priority Backlog 📥), serviceops-radar, GitLab (Integrations), Phabricator, User-brennen, GitLab-Test
mmodell added a comment to T291978: Limit GitLab shared runners to images from Wikimedia Docker registry.

So the containers will be running in a VM environment, no? And we can ensure that they restore to a snapshot or known-good baseline before testing a new patch? If we limit the absolute resource usage of the virtual machine and ensure a clean wipe/reset after each run then I think that root escape would have minimal real impact? Am I missing something?

Oct 8 2021, 6:15 PM · Release-Engineering-Team (GitLab-a-thon 🦊), Security-Team, User-brennen, GitLab (CI & Job Runners), Security

Oct 6 2021

mmodell moved T211904: Set up data storage to collect loosely structured data from CI from Next to Priority Backlog 📥 on the Release-Engineering-Team board.
Oct 6 2021, 4:32 PM · Release-Engineering-Team (Priority Backlog 📥), Elasticsearch, Continuous-Integration-Infrastructure

Oct 5 2021

mmodell awarded Blog Post: Blog Post Writing Club a Love token.
Oct 5 2021, 6:06 PM

Sep 29 2021

mmodell added a comment to T292094: Limit GitLab shared runners to trusted contributors.

If there’s an error or the request times out, the pipeline is accepted.

Sep 29 2021, 11:34 PM · Release-Engineering-Team (Done by Wed 24 Nov 🧟), SecTeam-Processed, Security-Team, User-brennen, GitLab (CI & Job Runners)
mmodell added a comment to T263166: Convert static mediawiki configuration to form more suitable for containers.

I plan to submit a more detailed proposal to the Tech Decision Forum shortly.

Sep 29 2021, 10:49 PM · User-Daniel, Platform Engineering Roadmap, Release-Engineering-Team (Seen), MW-on-K8s
mmodell added a comment to T292094: Limit GitLab shared runners to trusted contributors.

Mark all new users as "External" and have a process for unchecking the box. In some ways this may be simplest, but don't really like it - it's just a bad user experience, as you can't create new projects even under your own user when marked external, and last I tried this it wasn't at all obvious why.

Sep 29 2021, 10:37 PM · Release-Engineering-Team (Done by Wed 24 Nov 🧟), SecTeam-Processed, Security-Team, User-brennen, GitLab (CI & Job Runners)
mmodell added a comment to T212016: Create a repository for sharing ad-hoc local development tools.

This might be a good candidate for early adoption / migration to gitlab?

Sep 29 2021, 6:26 PM · mwcli, Developer Productivity
mmodell removed a watcher for Toolhub: mmodell.
Sep 29 2021, 6:17 PM
mmodell added a comment to T291978: Limit GitLab shared runners to images from Wikimedia Docker registry.

I think that many of the upstream docker images should be fine, for instance, images maintained by trustworthy organizations / open source projects. I don't know if there is a way to allow a list of blessed images / orgs with some kind of allow-list but that would also require extra maintenance work.

Sep 29 2021, 6:09 PM · Release-Engineering-Team (GitLab-a-thon 🦊), Security-Team, User-brennen, GitLab (CI & Job Runners), Security
mmodell added a comment to T263166: Convert static mediawiki configuration to form more suitable for containers.

Broadly:

  • SRE-level stuff, like server hostnames should be in etcd for ease of automation
  • releng-level stuff, like which wiki is in which group or which wiki is on which release, which extensions are loaded: probably Git, so it goes through CI and can be diffed and blamed
  • basic wiki configuration tasks, currently by sysadmins or trusted users but really should and can be managed through on-wiki interfaces and stored in MySQL.

I think we should also try to move away from loading all configuration during initialization, and defer stuff that's needed only for specific features or endpoints until it's actually needed.

Sep 29 2021, 5:55 PM · User-Daniel, Platform Engineering Roadmap, Release-Engineering-Team (Seen), MW-on-K8s

Sep 28 2021

mmodell awarded Blog Post: How we deploy code a Love token.
Sep 28 2021, 9:25 AM
mmodell added a comment to T291593: give visibility for "in progress" tasks on a work board.

Will there be a pop-up what these symbols mean when hovering with a mouse? (I'd like to reduce the amount of potential confusion / support questions.)

Sep 28 2021, 8:18 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell closed T291881: Get CI working on ddd repo in gitlab as Resolved.

build is now green: https://gitlab.wikimedia.org/releng/ddd/-/pipelines

Sep 28 2021, 6:11 AM · Data³

Sep 27 2021

mmodell added a comment to T291593: give visibility for "in progress" tasks on a work board.

@Jpita: It's not deployed yet.

Sep 27 2021, 10:52 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell updated the task description for T291881: Get CI working on ddd repo in gitlab.
Sep 27 2021, 7:48 PM · Data³
mmodell moved T291881: Get CI working on ddd repo in gitlab from MVP to Extra credit on the Data³ board.
Sep 27 2021, 7:45 PM · Data³
mmodell created T291881: Get CI working on ddd repo in gitlab.
Sep 27 2021, 7:43 PM · Data³

Sep 25 2021

mmodell placed T258803: Searching shorter terms ("gerrit", "cors") in global Phabricator search leads to upstream request timeout (too many results?) up for grabs.
Sep 25 2021, 6:24 AM · Upstream, Phabricator (Upstream)
mmodell lowered the priority of T258803: Searching shorter terms ("gerrit", "cors") in global Phabricator search leads to upstream request timeout (too many results?) from Medium to Low.
Sep 25 2021, 6:24 AM · Upstream, Phabricator (Upstream)
mmodell added a comment to T291593: give visibility for "in progress" tasks on a work board.

Screenshot from 2021-09-25 01-13-45.png (552×800 px, 88 KB)

Sep 25 2021, 6:18 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell triaged T291593: give visibility for "in progress" tasks on a work board as Medium priority.
Sep 25 2021, 6:16 AM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator

Sep 24 2021

mmodell changed the status of T148805: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards from Open to In Progress.
Sep 24 2021, 7:03 PM · Release-Engineering-Team (Priority Backlog 📥), Data³, Phabricator
mmodell awarded T208257: stop using mod_php anywhere a 100 token.
Sep 24 2021, 7:02 PM · Puppet-Core, Infrastructure-Foundations
mmodell changed the status of T291593: give visibility for "in progress" tasks on a work board, a subtask of T288956: Evaluate adding "In progress" status to Phabricator., from Open to In Progress.
Sep 24 2021, 6:59 PM · Phabricator
mmodell changed the status of T291593: give visibility for "in progress" tasks on a work board from Open to In Progress.
Sep 24 2021, 6:59 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator

Sep 23 2021

mmodell added a subtask for T288956: Evaluate adding "In progress" status to Phabricator.: T291593: give visibility for "in progress" tasks on a work board.
Sep 23 2021, 9:37 PM · Phabricator
mmodell added a parent task for T291593: give visibility for "in progress" tasks on a work board: T288956: Evaluate adding "In progress" status to Phabricator..
Sep 23 2021, 9:37 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator
mmodell claimed T291593: give visibility for "in progress" tasks on a work board.
Sep 23 2021, 9:37 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Phabricator

Sep 20 2021

mmodell changed the Default Edit Policy policy for application Projects from All Users to Trusted-Contributors (Project).
Sep 20 2021, 8:37 PM
mmodell moved T274228: Phabricator should cache tasks for a few minutes for logged-out users from To Triage to Needs code (in Phab or bot) on the Phabricator board.
Sep 20 2021, 8:30 PM · SRE, Traffic, Phabricator
mmodell added a comment to T266328: Some task notifications include a @mention entry in the X-Phabricator-Stamps mail header for no obvious reason.

I can't make much sense of what that specific event would trigger an @mention but there are other @mentions in the thread, perhaps it's just an off-by-one error?

Sep 20 2021, 8:29 PM · Phabricator (Upstream), Upstream

Sep 16 2021

mmodell added a comment to T290959: Phabricator failed to generate thumbnails for some 800-900KB files.

Hmm, perhaps it's hitting a memory limit or something? The limit shouldn't be a problem with such a small file though (unless it's doing something incredibly inefficient.)

Sep 16 2021, 2:12 PM · Phabricator

Sep 15 2021

mmodell added a comment to T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.

Deployed https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/721312

Sep 15 2021, 7:50 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell closed T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107, a subtask of T281164: 1.37.0-wmf.23 deployment blockers, as Resolved.
Sep 15 2021, 7:50 PM · Release-Engineering-Team (Doing), Release, Train Deployments
mmodell closed T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107 as Resolved.
Sep 15 2021, 7:50 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell added a comment to T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.

I can attest to seeing a huge spike in errors.

Sep 15 2021, 7:24 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell added a subtask for T281164: 1.37.0-wmf.23 deployment blockers: T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.
Sep 15 2021, 7:13 PM · Release-Engineering-Team (Doing), Release, Train Deployments
mmodell removed a subtask for T291097: [testwiki-wmf.23] Disable MediaSearch on testwiki: T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.
Sep 15 2021, 7:13 PM · Structured-Data-Backlog, SDAW-MediaSearch
mmodell edited parent tasks for T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107, added: T281164: 1.37.0-wmf.23 deployment blockers; removed: T291097: [testwiki-wmf.23] Disable MediaSearch on testwiki.
Sep 15 2021, 7:13 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell added a parent task for T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107: T291097: [testwiki-wmf.23] Disable MediaSearch on testwiki.
Sep 15 2021, 7:13 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell added a subtask for T291097: [testwiki-wmf.23] Disable MediaSearch on testwiki: T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.
Sep 15 2021, 7:13 PM · Structured-Data-Backlog, SDAW-MediaSearch
mmodell created T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.
Sep 15 2021, 7:11 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell created T291108: PHP Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete].
Sep 15 2021, 6:17 PM · MW-1.37-release, Platform Engineering, Wikimedia-production-error
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

Maybe we should notify wikitech-l about this? I would tag as user-notice but this isn't for tech news

Sep 15 2021, 5:05 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

I've disabled the herald rule.

Sep 15 2021, 5:05 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

hmmm, well needs triage is the highest possible priority besides unbreak now. Medium is the same as "no prioritization" in my mind, but maybe others think of it differently.

Sep 15 2021, 4:51 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

@DannyS712: sure, I'll write a quick notice to the list.

Sep 15 2021, 4:49 PM · Phabricator
mmodell added a comment to T285232: The restricted/mediawiki-webserver image should include skins and resources.

at the end of the day it seems to me that we only have these symlinks for historical reasons and we don't really want people to use them anymore.

Sep 15 2021, 4:47 PM · Performance-Team (Radar), Patch-For-Review, SRE, serviceops, Release-Engineering-Team (Radar), MW-on-K8s
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

I don't think it makes sense that in-progress tasks would "need triage." therefore I added the above herald rule: If setting a task to in progress without setting the priority, it'll get set to medium priority automatically. Should that be high priority or is that a bad idea to have the herald rule prioritize it?

Sep 15 2021, 4:45 PM · Phabricator
mmodell changed the status of T288956: Evaluate adding "In progress" status to Phabricator. from Open to In Progress.
Sep 15 2021, 4:43 PM · Phabricator