SVG attachments are not displayed
Open, LowestPublic
Actions

Assigned To

None

Authored By

	Quiddity
	Oct 31 2014, 9:53 PM

Description

Reported upstream: https://secure.phabricator.com/T6445

In T1005#17606 the 2 attached svg files are not (easily/at all?) accessible in my browser. The only way I can find to view those files, is to download them first.

(possibly related to https://secure.phabricator.com/T4412 ? I do understand that svg is more complicated than png/gif/jpg... :/ )

Wikimedia-logo.svg692 BDownload

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled	Feature	None	T76096 Phabricator avatar SVG support
		Open		None	T1016 SVG attachments are not displayed

Event Timeline

Quiddity created this task.Oct 31 2014, 9:53 PM

Quiddity raised the priority of this task from to Needs Triage.

Quiddity updated the task description. (Show Details)

Quiddity added a project: Phabricator.

Quiddity changed Security from none to None.

Quiddity subscribed.

Quiddity merged a task: T1019: Phabricator is unable to preview SVGs in-line.Oct 31 2014, 10:39 PM

Quiddity added a subscriber: • Jaredzimmerman-WMF.

Qgil updated the task description. (Show Details)Oct 31 2014, 11:04 PM

<qgil> SVGs not rendering in Phabricator, this is a surprise. Is there a task already reported? https://secure.phabricator.com/M1410
<epriestley> qgil: add the applicable MIME types to files.image-mime-types
<epriestley> We can probably bring that upstream if you want to figure out what they are and confirm they work.

Normal priority only because we have so much in our plate right now. I agree this is important.

If someone wants to investigate and try out a solution in phab-01...

<epriestley> We also probably can't thumbnail them because GD doesn't support that.
<epriestley> I'm not sure how to thumbnail an SVG, there may be some easy approach.
<epriestley> Or some easy-but-inconvenient approach, like "use width/height on the same file".

I added image/svg to https://phab-01.wmflabs.org/config/group/files/ but SVGs are still not rendered.

How does MediaWiki render SVG + thumbnails? Being Phabricator and MediaWiki PHP, is there a possibility to share some code or method?

Qgil edited projects, added Project-Management; removed Phabricator.Oct 31 2014, 11:24 PM

Qgil updated the task description. (Show Details)Oct 31 2014, 11:33 PM

Qgil moved this task from Backlog to Wikimedia requests on the Phabricator (Upstream) board.

In T1016#17699, @Qgil wrote:

I added image/svg to https://phab-01.wmflabs.org/config/group/files/

... and removed just in case.

MediaWiki thumbnails SVGs using these external applications https://github.com/wikimedia/mediawiki/blob/master/includes/DefaultSettings.php#L934-L957. The default ImageMagick version seems to be what is used on the WMF production cluster today.

We also have a lot of code in UploadBase that scans svg content when it is submitted to exclude some of the nastier things that are possible to embed in an svg image.

Some progress at https://secure.phabricator.com/T6445

The upstream instance now renders full size SVGs in the files pages. Thumbnailing is still missing. Example: https://secure.phabricator.com/M1410

This means that we have saved some clicks to users but there is still some work to do. Not bad for a few hours in a Halloween's Friday night. :)

Thank you @bd808, I have posted your comments upstream.

Qgil lowered the priority of this task from Medium to Low.Nov 7 2014, 10:49 AM

Qgil mentioned this in T76096: Phabricator avatar SVG support.Nov 27 2014, 7:18 AM

• MZMcBride subscribed.Nov 28 2014, 3:53 AM

Qgil merged a task: T76444: Time consuming to get files out of phabricator into correct place.Dec 2 2014, 9:29 AM

Qgil added a subscriber: Nikerabbit.

great progress!

Jdforrester-WMF subscribed.Dec 6 2014, 11:00 PM

Qgil edited projects, added Phabricator; removed Project-Management.Dec 23 2014, 9:11 PM