In 1.26wmf21[1] we moved gallery styles into a separate resourceloader module. We double load the styles for cached pages. This task tracks ensuring that those styles are removed.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | • Jhernandez | T104432 [EPIC]: Improve mobile site performance | |||
| Resolved | Jdlrobson | T98986 [EPIC] Improve the status quo of mobile web performance | |||
| Duplicate | None | T98397 Main menu and notification css should be loaded via JavaScript | |||
| Duplicate | None | T98987 Epic: Make mobile web more performant | |||
| Resolved | Jdlrobson | T97289 Trim down CSS loaded in the head for anonymous users on mobile | |||
| Resolved | Release | dancy | T281161 1.37.0-wmf.20 deployment blockers | ||
| Resolved | Jdlrobson | T89981 Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature | |||
| Resolved | Jdlrobson | T98878 Gallery styles should only be loaded on pages that need them (desktop and mobile) | |||
| Resolved | Jdlrobson | T110709 Stop double loading mediawiki.page.gallery.styles | |||
| Resolved | Florian | T113511 Category media styles broken in 1.26wmf24 | |||
| Invalid | Florian | T113522 Reconcile category and gallery code to be generated via the same mechanism |
Event Timeline
Comment Actions
Change 234592 had a related patch set uploaded (by Jdlrobson):
Don't double load gallery css
Comment Actions
Change 233085 had a related patch set uploaded (by Jdlrobson):
Do not double load gallery styles now cache has expired
Comment Actions
Desktop change can be merged now. https://gerrit.wikimedia.org/r/233085
Mobile will need to be merged after Monday (it got merged a week later). I'll move this back to dev when the desktop change is done.
Comment Actions
Change 233085 merged by jenkins-bot:
Do not double load gallery styles now cache has expired
Comment Actions
Just need to merge the code for https://gerrit.wikimedia.org/r/#/c/234592/
I just realised we can load this as due to the core change the module will be present anyhow so caching rules are the same as desktop
Comment Actions
Remember, that the @Umherirrender's change will arrive wmf wikis with 1.27.0-wmf.1, not with 1.26wmf24 :)
Comment Actions
If category pages gets cached, you have to wait 30 days from the last patch.
If not, you can wait 30 days from the first patch, because both patches adding the module to the parser cache, if <gallery> was used.
Special pages not cached, so there is no problem.
Comment Actions
1.27.0-wmf.3 seems like a good branch to merge into. 3 weeks is more than enough for most of the category pages to have caught up and the fact that these styles are loaded on pages unnecessarily is more concerning right now.
Someone should feel to free to +2 https://gerrit.wikimedia.org/r/240567 in time for Monday's cut off