It seems since galleries are invoked by the parser it would make sense to only load the associated styles when a gallery is on the page, given that numerous pages do not have galleries rather than loading them all in the head.
This will help reduce firstPaint time.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | • Jhernandez | T104432 [EPIC]: Improve mobile site performance | |||
| Resolved | Jdlrobson | T98986 [EPIC] Improve the status quo of mobile web performance | |||
| Duplicate | None | T98397 Main menu and notification css should be loaded via JavaScript | |||
| Duplicate | None | T98987 Epic: Make mobile web more performant | |||
| Resolved | Jdlrobson | T97289 Trim down CSS loaded in the head for anonymous users on mobile | |||
| Resolved | Release | dancy | T281161 1.37.0-wmf.20 deployment blockers | ||
| Resolved | Jdlrobson | T89981 Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature | |||
| Resolved | Jdlrobson | T98878 Gallery styles should only be loaded on pages that need them (desktop and mobile) | |||
| Resolved | Jdlrobson | T110709 Stop double loading mediawiki.page.gallery.styles | |||
| Resolved | Florian | T113511 Category media styles broken in 1.26wmf24 | |||
| Invalid | Florian | T113522 Reconcile category and gallery code to be generated via the same mechanism |
Removing ResourceLoader component. The ability to add modules to a page already exists.
For example "mediawiki.toc" (in core) and ext.cite (Cite extension) both make use of this
EDIT: In fact, this has already been done in 2013. Module "mediawiki.page.gallery" is only loaded if the a gallery has been encountered in the page. The TraditionalImageGallery class deals with tracking the needed modules and adding them to the parser output.
So we need to move styles from legacy code to a new module mediawiki.page.gallery.styles which gets loaded at same time as mediawiki.page.gallery
MobileFrontend could then define a skinStyles for that module.
Change 233083 had a related patch set uploaded (by Jdlrobson):
Only load gallery styles when needed
Change 233084 had a related patch set uploaded (by Jdlrobson):
Only load gallery styling rules when gallerys are on the page
Change 233085 had a related patch set uploaded (by Jdlrobson):
Do not double load gallery styles now cache has expired
I hope this trend is not pushing towards other (generic) classes, such as thumbs. Those are used by templates, and this may apply to galleries as well.
It's not about the <gallery> tag. It's about templates generating HTML that uses the same css class names as used by the MediaWiki parser for <gallery>, and image thumbnails. This is used in constructs such as Template:Panorama.
Got it thanks for clarification. This seems like a general problem we need to solve. In mean time couldn't a blank gallery tag be added to these templates?
Change 233084 merged by jenkins-bot:
Only load gallery styling rules when galleries are on the page
https://gerrit.wikimedia.org/r/#/c/233083/2 is ready for review now the upstream has happened. Thanks again @matmarex.
Right, now we wait 30 days to merge https://gerrit.wikimedia.org/r/233085, and we're done.
/me marks calendar
@Jhernandez: I recommend this gets dropped to low priority while we wait the next 30 days out.
@phuedx so... we still need to merge the mobile patch with high priority.
Without https://gerrit.wikimedia.org/r/#/c/233083/2 we will start loading desktop styles on the mobile site for galleries (which will not work)
A side effect of this patch is that currently cached HTML featuring galleries will not load the css... I can however make it double load if we want.
Change 236053 had a related patch set uploaded (by Alex Monk):
Load new gallery styles module
Change 240563 had a related patch set uploaded (by Florianschmidtwelzow):
Load gallery styles on Category pages, too
Change 240563 abandoned by Florianschmidtwelzow:
Load gallery styles on Category pages, too
Reason:
See I32697c2c65824d7622c.