Page MenuHomePhabricator
Create Task
Maniphest T112290

Echo notification icons should be properly themed in MonoBook
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
NordNordWest
Sep 11 2015, 4:45 PM
Tags
Referenced Files
F2955440: Screen Shot 2015-11-11 at 2.43.41 PM.png
Nov 11 2015, 10:49 PM
F2955438: Screen Shot 2015-11-11 at 2.44.10 PM.png
Nov 11 2015, 10:49 PM
F2952632: pasted_file
Nov 11 2015, 1:57 AM
F2914222: pasted_file
Nov 4 2015, 2:50 PM
F2914227: pasted_file
Nov 4 2015, 2:50 PM
F2675359: pasted_file
Oct 9 2015, 6:20 PM
Subscribers
Aklapper
Catrope
Esanders
Etonkovidova
gerritbot
Jdforrester-WMF
Legoktm
View All 12 Subscribers
Tokens
"Love" token, awarded by matmarex.

Description

In MonoBook the notification icons are black because the apex theme does not support inverted icons. It should be possible to make them white, but last time they were flashing (T111821: Echo flyout icon flashes color change from white to black in MonoBook skin)

Details

SubjectRepoBranchLines +/-
Separate skin specific styles and improve Monobook appearancemediawiki/extensions/Echomaster+104 -29
Customize query in gerrit

Related Objects

Event Timeline

NordNordWest created this task.Sep 11 2015, 4:45 PM
NordNordWest raised the priority of this task from to Needs Triage.
NordNordWest updated the task description. (Show Details)
NordNordWest added a project: Notifications.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 11 2015, 4:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper closed this task as a duplicate of T111821: Echo flyout icon flashes color change from white to black in MonoBook skin.Sep 11 2015, 8:50 PM
Aklapper added a subscriber: NordNordWest.

Hi @NordNordWest. Thanks for taking the time to report this!
This particular problem has already been reported into our bug tracking system as T111821, but please feel free to report any further issues you find.

Legoktm reopened this task as Open.Sep 11 2015, 9:47 PM
Legoktm subscribed.

I don't think this a dupe...

Legoktm renamed this task from Echo notification icons in Monobook to Echo notification icons should be white in MonoBook to match Vector.Sep 11 2015, 9:48 PM
Legoktm updated the task description. (Show Details)
Legoktm set Security to None.
Legoktm moved this task from Backlog to Needs code on the Notifications board.Sep 16 2015, 11:13 PM
Legoktm added a project: UI-Standardization.Sep 16 2015, 11:54 PM
Legoktm added subscribers: • violetto, Volker_E.
Legoktm added a comment.Sep 16 2015, 11:57 PM

Open questions for UI-Standardization:

  • Should apex support inverted icons?
  • Should OOUI PHP output black icons for apex (Echo is currently hacking around this)
Catrope triaged this task as High priority.Sep 23 2015, 11:43 PM
Catrope subscribed.
• DannyH moved this task from Untriaged to Near-Term Interest on the Collaboration-Team-Triage board.Sep 23 2015, 11:43 PM
• violetto added a comment.Sep 30 2015, 9:16 PM

cc @Volker_E

Volker_E moved this task from Unsorted to Current Quarterly Goals on the UI-Standardization board.Oct 1 2015, 6:55 PM
Esanders subscribed.Oct 9 2015, 6:20 PM

Or we can make the text black/dark grey to match the icon. Here I've also removed the background and reduced the font size to match:

pasted_file (131×454 px, 26 KB)

Catrope added a comment.Oct 9 2015, 7:27 PM
In T112290#1715908, @Esanders wrote:

Or we can make the text black/dark grey to match the icon. Here I've also removed the background and reduced the font size to match:

pasted_file (131×454 px, 26 KB)

That looks nice! What's the CSS you used for that?

Legoktm added a comment.Oct 10 2015, 4:28 AM
In T112290#1716082, @Catrope wrote:
In T112290#1715908, @Esanders wrote:

Or we can make the text black/dark grey to match the icon. Here I've also removed the background and reduced the font size to match:
F2675359

That looks nice! What's the CSS you used for that?

+1

Esanders added a comment.Oct 15 2015, 8:07 PM

I just set the background to transparent, color to back, the font size back to 1em, and opacity to 0.7 ish.

Esanders renamed this task from Echo notification icons should be white in MonoBook to match Vector to Echo notification icons should be properly themed in MonoBook .Nov 4 2015, 2:11 PM
Esanders updated the task description. (Show Details)
gerritbot subscribed.Nov 4 2015, 2:48 PM

Change 250969 had a related patch set uploaded (by Esanders):
Separate skin specific styles and improve Monobook appearance

https://gerrit.wikimedia.org/r/250969

gerritbot added a project: Patch-For-Review.Nov 4 2015, 2:48 PM
Esanders added a comment.Nov 4 2015, 2:50 PM
BeforeAfter
pasted_file (230×474 px, 24 KB)
pasted_file (229×479 px, 24 KB)
matmarex awarded a token.Nov 4 2015, 5:58 PM
Catrope added a comment.Nov 5 2015, 7:09 PM
In T112290#1781832, @Esanders wrote:
BeforeAfter
pasted_file (230×474 px, 24 KB)
pasted_file (229×479 px, 24 KB)

In this design it's really difficult to see the difference between having unseen messages (blue background in vector) and not having unseen messages (grey background)

Catrope added a comment.Nov 5 2015, 7:09 PM
This comment was removed by Catrope.
Esanders added a comment.Nov 11 2015, 1:57 AM

After V2:

pasted_file (179×557 px, 32 KB)

Jdforrester-WMF subscribed.Nov 11 2015, 2:14 AM

Nice.

gerritbot added a comment.Nov 11 2015, 2:19 AM

Change 250969 merged by jenkins-bot:
Separate skin specific styles and improve Monobook appearance

https://gerrit.wikimedia.org/r/250969

Catrope assigned this task to Esanders.Nov 11 2015, 2:25 AM
Catrope edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)).Nov 11 2015, 3:00 AM
Pginer-WMF subscribed.Nov 11 2015, 8:25 AM

Related to this, there is a proposal for changing the notification badges which do not require inverted icons: T115845
The proposed approach worked well in our research sessions, but we have not checked if there would be some Monobook-related limitation. Feel free to comment on the ticket if you think there may be any.

Legoktm added a project: User-notice.Nov 11 2015, 4:42 PM
Etonkovidova subscribed.Nov 11 2015, 10:49 PM

Checked in betalabs:

Screen Shot 2015-11-11 at 2.44.10 PM.png (129×577 px, 25 KB)

Screen Shot 2015-11-11 at 2.43.41 PM.png (139×639 px, 27 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Nov 11 2015, 10:49 PM
Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.Nov 12 2015, 12:43 PM
Liuxinyu970226 subscribed.Nov 14 2015, 3:36 AM
Legoktm closed this task as Resolved.Nov 19 2015, 10:16 PM
• Quiddity moved this task from Announce in next Tech/News to Already announced/Archive on the User-notice board.Nov 20 2015, 12:49 AM
Liuxinyu970226 unsubscribed.Nov 21 2015, 11:43 AM
WhatamIdoing subscribed.Nov 23 2015, 8:40 PM

A problem in the Modern skin has been reported: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Notification_look_change

Based upon timing, it might be related to this. Does anyone know whether Modern uses the same Notification icons as Monobook?

Danny_B moved this task from Current Quarterly Goals to Unsorted on the UI-Standardization board.May 20 2016, 8:43 PM
WhatamIdoing unsubscribed.May 24 2016, 3:04 PM
• Whatamidoing-WMF subscribed.May 24 2016, 3:05 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits