A translatable subpage page should not be messed while moving subpages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Base
	Oct 3 2015, 9:19 PM

Description

If a translatable page A/B is a subpage of a page A, and the page A is being moved with its subpages to C, A/B gets moved to C/B but its translations A/B/en, A/B/foo, A/B/bar as well as unit pages Translations:A/B/1/en, Translations:A/B/2/bar and so on do not get moved. They can't be moved after it manually as well. So the translatable page now C/B needs to be moved back to A/B and then moved to C/B along with its satelites.

Thus when moving pages like A pages like A/B should either be moved the same way as when you move them directly or not moved at all.

(I'm sorry for kinda messy desc, didn't find right words to explain it without "variables")

Details

	Subject	Repo	Branch	Lines +/-
	Don't move translatable subpages when moving parent	mediawiki/extensions/Translate	master	+37 -17

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T195760 Language Annual Plan 2018-2019
Resolved	Nikerabbit	T204818 Language tools maintenance intervention: Improve the quality of translations for Translate extension
Resolved	Nikerabbit	T114592 A translatable subpage page should not be messed while moving subpages

Event Timeline

Base created this task.Oct 3 2015, 9:19 PM

Base raised the priority of this task from to Needs Triage.

Base updated the task description. (Show Details)

Base added projects: MediaWiki-extensions-Translate, MediaWiki-General.

Base subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2015, 9:19 PM

Base mentioned this in T114588: Fix the wikicode templates at Outreach:Wikimedia:Starting an education program so new education program plans are not created as subpages of Education Portal/Program Plans/ but rather as subpages of Education/Program plans/ and move existing plan pages created prior to this domain also.Oct 3 2015, 9:31 PM

• AKoval_WMF subscribed.Oct 3 2015, 9:39 PM

I thought this is already checked, at least you can choose whether to move non-translatable subpages or not. Maybe it's confused if there is another translatable page under translatable page.

Nikerabbit triaged this task as Medium priority.Nov 3 2015, 3:52 PM

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.

I was able to confirm this while testing another move-related patch today. This is actually quite a severe bug, imo, and would cause large scale disruption and lots of work for users if done on translatable pages with lots of translations so increasing priority.

Glaisher mentioned this in T126376: Translations of subpages aren't moved when a translatable page is moved.Aug 9 2016, 5:11 AM

Glaisher merged a task: T126376: Translations of subpages aren't moved when a translatable page is moved.

Glaisher added subscribers: Mike_Peel, Krenair, Matanya and 2 others.

Glaisher claimed this task.Aug 9 2016, 5:34 AM

Ata added a project: Language-Team.Oct 14 2016, 10:42 AM

Ata subscribed.

Nemo_bis removed a project: Language-Team.Oct 14 2016, 12:44 PM

Harej mentioned this in T168591: Complex page move leaves some translation-related pages behind.Jun 27 2017, 9:25 PM

I wanted to start a new task but then found this one:

@Lea_Lacroix_WMDE moved WD:Wiktionary to WD:Lexicographical data on Wikidata, which was a translatable page. This successfully triggered FuzzyBot, which started moving the page and its subpages. However, some of those subpages were not translations but other translatable pages. Those were moved as well but not their translations.

This had to be repaired by hand by removing those pages from translation, moving back to the old title, re-marking for translation (which attached translations) and then moving again to the new title.

Unless @Glaisher disagrees, I'd like to fix this bug as soon as possible.

Change 415084 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/Translate@master] Don't move translatable subpages when moving parent

https://gerrit.wikimedia.org/r/415084

gerritbot added a project: Patch-For-Review.Feb 27 2018, 7:51 PM

matej_suchanek claimed this task.Feb 27 2018, 7:57 PM

Lea_Lacroix_WMDE awarded a token.Feb 28 2018, 11:29 AM

Base updated the task description. (Show Details)Mar 11 2018, 9:16 PM

Liuxinyu970226 subscribed.Apr 27 2018, 10:01 AM

Perhelion subscribed.Jul 26 2018, 9:03 AM

Sorry to be here for an live example, but I deleted https://commons.wikimedia.org/wiki/Template:Mozilla_Public_License/i18n (in fact ./en got deleted) to be able to move subpages per hand from https://commons.wikimedia.org/wiki/Special:PrefixIndex?prefix=MPL%2F&namespace=10 (which got not moved due the move bug by @Jarekt 2018-03-22) which seems a very bad idea from me.
As now (FuzzyBot) deleted all subpages without warning. And I restored all pages, but now the template is not translatable anymore.

Trizek-WMF subscribed.Aug 20 2018, 8:08 AM

Pginer-WMF added a parent task: T204818: Language tools maintenance intervention: Improve the quality of translations for Translate extension.Sep 19 2018, 12:11 PM

Pginer-WMF added a project: Language-Team (Language-2018-October-December).Oct 29 2018, 11:21 AM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2018-October-December) board.

xSavitar subscribed.Oct 29 2018, 1:36 PM

• Quiddity mentioned this in T208536: Support for new Access Policy/Confidentiality Agreement rollout.Nov 1 2018, 8:28 PM

Nikerabbit moved this task from Priority backlog to In Review on the Language-Team (Language-2018-October-December) board.Nov 6 2018, 7:53 AM

Change 415084 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Don't move translatable subpages when moving parent

https://gerrit.wikimedia.org/r/415084

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 12 2018, 4:00 PM

Nikerabbit removed a project: Patch-For-Review.Nov 13 2018, 7:29 AM

Nikerabbit moved this task from In Review to QA on the Language-Team (Language-2018-October-December) board.

Nikerabbit added a subscriber: Johan.

Trizek-WMF awarded a token.Nov 14 2018, 11:32 AM

Suggestion for Tech/News:

On groups of pages using Extension:Translate, it will not be possible to move translatable subpages when moving their parent page.

Please check (and thank you for the fix)! :)

Perhaps someone using these tools in their workflows could comment, but I feel the proposed message highlights the wrong part: it was moving of those pages that was causing an issue by creating an unexpected mess. So the highlight is that it is now safe(r) to move translatable pages having translatable subpages.

Makes sense.

Do you know when this will go into production?

It's in 1.33.0-wmf.4 which, I assume, is deployed already.

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Nov 22 2018, 4:22 PM

matej_suchanek closed this task as Resolved.Nov 24 2018, 1:16 PM

matej_suchanek reassigned this task from matej_suchanek to Nikerabbit.

matej_suchanek unsubscribed.Nov 24 2018, 1:21 PM

• Quiddity awarded a token.Nov 24 2018, 6:32 PM