Page MenuHomePhabricator

Convert Special:WhatLinksHere to OOUI
Open, MediumPublic

Description

I thought we already had a task for Special:WhatLinksHere, but I haven't found it (so maybe it doesn't really exist).

Before:


Details

Related Gerrit Patches:

Event Timeline

Florian created this task.Nov 4 2015, 5:46 PM
Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian added a project: UI-Standardization.

Change 276966 had a related patch set uploaded (by Ajayrahulp):
Convert Special:WhatLinksHere from XML form to OOUI form

https://gerrit.wikimedia.org/r/276966

Change 276966 merged by jenkins-bot:
Convert Special:WhatLinksHere from XML form to OOUI form

https://gerrit.wikimedia.org/r/276966

Sethakill closed this task as Resolved.May 10 2016, 8:30 PM
Sethakill claimed this task.
Sethakill removed a project: Patch-For-Review.
TheDJ added a subscriber: TheDJ.May 19 2016, 9:16 PM

Did anyone test this ?

Two actionable (and hopefully doable) suggestions:

  • The "Namespace" and "Invert selection" fields should be on the same line (and behave like a single field).
    • Something I had in mind for a while was a 'namespacemultiselect' field type in HTMLForm, that would display these two fields (plus an "Include associated namespace" one, optionally) and return an array of namespace ids as its data (a bit like HTMLMultiSelectField). Please note that this is not a polished idea and I never tried implementing it :D
    • I did, however, implement MediaWiki\Widget\ComplexNamespaceInputWidget for the OOUI version. It was briefly used on Watchlist (before that OOUI conversion was reverted too, T99256).
  • The "Hide blah" checkboxes should also be on the same line and behave like a single field.
    • You can probably use 'multiselect' field type easily here, for a start.
    • We had some other OOUI HTMLForm special page which used a little bit of custom CSS to display similar checkboxes inline, I can't remember which one now.

Quick mockup (edit of the screenshot above):

Danny_B added a subscriber: Danny_B.

Needs design team's eyes obviously...

Danny_B added a subscriber: Dereckson.EditedMay 20 2016, 12:43 AM

@Ajayrahul We've a little issue reverting the localisation of your code: your repurposed messages to give them a new meaning.
This choice makes it's not straighforward to revert: we need to track on TranslateWiki translations update, revert them, prepare a change.
When you change the meaning of an element interface, please create a new message instead of amend existing ones.

Quick mockup (edit of the screenshot above):

Better than the reverted stuff, but still so much unnecessarily space consuming.
Can't the original layout be kept as much as possible?
Why are labels above controls?
Why is ns selector x-times wider than the widest item in it?
Etc...

Dvorapa removed a subscriber: Dvorapa.May 20 2016, 2:39 PM
Volker_E added a subscriber: Volker_E.EditedApr 3 2018, 8:10 PM

Even if I might repeat myself. To @Danny_B's points above:

Why are labels above controls?

Because there's lesser cognitive workload when labels are above controls. People are quicker when fulfilling their tasks on forms with labels above fields. See for example https://www.uxmatters.com/mt/archives/2006/07/label-placement-in-forms.php

Why is ns selector x-times wider than the widest item in it?

What is the problem with this?

Volker_E updated the task description. (Show Details)Apr 3 2018, 8:21 PM
Volker_E updated the task description. (Show Details)Apr 3 2018, 8:23 PM
Amorymeltzer added a subscriber: Amorymeltzer.

The mobile version of this page should be converted as well.

Jdlrobson added a subscriber: Jdlrobson.

The mobile version of this page should be converted as well.

The mobile version of this page is the same as the desktop version.

matej_suchanek removed Sethakill as the assignee of this task.Oct 5 2019, 12:17 PM
matej_suchanek edited subscribers, added: Sethakill; removed: wikibugs-l-list.