Page MenuHomePhabricator
Create Task
Maniphest T128191

Wikibase Scribunto tests are failing, with the tests depending on configuration
Closed, ResolvedPublic
Actions

Description

Wikibase Scribunto tests are failing suddenly since yesterday:

the tests now expect luasandbox, and seem to depend on configuration.

14:35:38 There were 4 failures:
14:35:38 
14:35:38 1) LuaSandbox: Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibraryTest::testRegister
14:35:38 Failed asserting that LuaSandboxFunction Object () is an instance of class "Scribunto_LuaStandaloneInterpreterFunction".
14:35:38 
14:35:38 /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php:77
14:35:38 /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/MediaWikiTestCase.php:147
14:35:38 
14:35:38 2) LuaStandalone: Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibraryTest::testRegister
14:35:38 Failed asserting that LuaSandboxFunction Object () is an instance of class "Scribunto_LuaStandaloneInterpreterFunction".
14:35:38 
14:35:38 /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php:77
14:35:38 /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/MediaWikiTestCase.php:147
14:35:38 
14:35:38 3) LuaSandbox: Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseLibraryTest::testRegister
14:35:38 Failed asserting that LuaSandboxFunction Object () is an instance of class "Scribunto_LuaStandaloneInterpreterFunction".
14:35:38 
14:35:38 /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTest.php:88
14:35:38 /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/MediaWikiTestCase.php:147
14:35:38 
14:35:38 4) LuaStandalone: Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseLibraryTest::testRegister
14:35:38 Failed asserting that LuaSandboxFunction Object () is an instance of class "Scribunto_LuaStandaloneInterpreterFunction".
14:35:38 
14:35:38 /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTest.php:88
14:35:38 /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/MediaWikiTestCase.php:147
14:35:38 
14:35:38 --

I think http://git.wikimedia.org/commitdiff/integration%2Fjenkins.git/d7bdc8f1a77eec58832bad3684b6c01e6720a639 is what has triggered the failures. That change is good, but we need to improve the tests so they don't depend on configuration like this.

Details

SubjectRepoBranchLines +/-
Revert "mediawiki.conf: Set $wgScribuntoDefaultEngine for speed"integration/jenkinsmaster+0 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

aude created this task.Feb 26 2016, 3:08 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 26 2016, 3:08 PM
aude triaged this task as Unbreak Now! priority.Feb 26 2016, 3:08 PM

this is causing anything depending on the wikidata build to fail, such as ContentTranslation, and is causing Wikibase tests to also fail

gerritbot subscribed.Feb 26 2016, 3:10 PM

Change 273460 had a related patch set uploaded (by Aude):
Revert "mediawiki.conf: Set $wgScribuntoDefaultEngine for speed"

https://gerrit.wikimedia.org/r/273460

gerritbot added a project: Patch-For-Review.Feb 26 2016, 3:10 PM

Change 273460 merged by jenkins-bot:
Revert "mediawiki.conf: Set $wgScribuntoDefaultEngine for speed"

https://gerrit.wikimedia.org/r/273460

Stashbot subscribed.Feb 26 2016, 3:14 PM

Mentioned in SAL [2016-02-26T15:14:19Z] <jzerebecki> salt -v --show-timeout '*slave*' cmd.run "bash -c 'cd /srv/deployment/integration/slave-scripts; git pull'" T128191

JanZerebecki added a parent task: T126670: Have CI set `$wgScribuntoDefaultEngine = 'luasandbox` to speed up parser tests.Feb 26 2016, 3:32 PM
Jdforrester-WMF awarded a token.Feb 26 2016, 4:05 PM
Anomie subscribed.Feb 26 2016, 6:40 PM

That change is good, but we need to improve the tests so they don't depend on configuration like this.

+1.

Why are you calling Scribunto::newDefaultEngine() in Scribunto_LuaWikibaseLibraryTest.php and Scribunto_LuaWikibaseEntityLibraryTest.php instead of using $this->getEngine()? That's bypassing all the work that Scribunto_LuaEngineTestBase does to have your code tested with both engines.

JanZerebecki subscribed.Feb 26 2016, 7:15 PM

Fix for the instanceof problem: https://gerrit.wikimedia.org/r/#/c/273494/ .

JanZerebecki added a subscriber: hoo.Feb 26 2016, 7:55 PM
Legoktm subscribed.Feb 27 2016, 12:08 AM

So...are we ready to try again? :)

Stashbot added a comment.Feb 27 2016, 12:51 AM

Mentioned in SAL [2016-02-27T00:51:41Z] <jzerebecki> salt -v --show-timeout '*slave*' cmd.run "bash -c 'cd /srv/deployment/integration/slave-scripts; git pull'" T128191

JanZerebecki closed this task as Resolved.Feb 27 2016, 1:13 AM

Checked on https://gerrit.wikimedia.org/r/#/c/273458/ that the problem is now gone.

JanZerebecki created subtask T128245: Use $this->getEngine() instead of Scribunto::newDefaultEngine() .Feb 27 2016, 1:15 AM
JanZerebecki closed subtask T128245: Use $this->getEngine() instead of Scribunto::newDefaultEngine() as Resolved.Feb 29 2016, 4:45 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL