Page MenuHomePhabricator

Have dependencies of gated extensions in the gate
Open, MediumPublic

Description

A part of Wikimedia deployed extensions are tested together when a patch is sent to either of them, mediawiki/core or mediawiki/vendor. That is done by the Jenkins jobs prefixed with wmf-quibble-.

The list of gated extensions is defined in zuul/layout.yaml by having the template extension-gate and we also have to set them as a build parameters via zuul/parameter_functions.py (see the list gatedextensions).

As of 9 April 2020 they are:

gatedextensions = [
    'AbuseFilter',
    'AntiSpoof',
    'Babel',
    'CheckUser',
    'CirrusSearch',
    'cldr',
    'ContentTranslation',
    'Echo',
    'Elastica',
    'EventLogging',
    'EventStreamConfig',
    'FileImporter',
    'Flow',
    'GeoData',
    'GlobalCssJs',
    'GlobalPreferences',
    'GuidedTour',
    'JsonConfig',
    'Kartographer',
    'MobileApp',
    'MobileFrontend',
    'NavigationTiming',
    'SandboxLink',
    'SiteMatrix',
    'TemplateData',
    'Thanks',
    'TimedMediaHandler',
    'Translate',
    'UniversalLanguageSelector',
    'VisualEditor',
    'Wikibase',
    'WikibaseCirrusSearch',
    'WikibaseMediaInfo',
    'WikimediaMessages',
]
gatedskins = [
    'MinervaNeue',
    'Vector',
]

We have various cases of breakage because their dependencies are not necessarily in the gate. T204065 is Wikibase that got broken by a patch in mediawiki/core which broke WikibaseLexeme. The patch to mediawiki/core did not run the WikibaseLexeme tests since it is not in the gate, although it is a dependency of Wikibase.

I wrote a test to check that the dependencies are in the gate with https://gerrit.wikimedia.org/r/460080 It is run daily via the Jenkins job integration-config-qa.

The test result is available at:
https://integration.wikimedia.org/ci/job/integration-config-qa/lastBuild/testReport/(root)/test_zuul_gate_and_dependencies/

Which yields:
! Extension ! Status ! Depended on by… ! Task !

ArticlePlaceholder FailedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfoT204153
BetaFeatures FailedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
CentralAuth FailedAbuseFilter, CheckUser, CirrusSearch, ContentTranslation, Echo, FileImporter, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
Cite FailedCirrusSearch, ContentTranslation, Flow, GeoData, JsonConfig, MobileApp, MobileFrontend, Thanks, VisualEditor, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
CodeEditor FailedAbuseFilter, CirrusSearch, ContentTranslation, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
ConfirmEdit FailedCirrusSearch, ContentTranslation, Flow, GeoData, JsonConfig, MobileApp, MobileFrontend, Thanks, VisualEditor, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
FlaggedRevs FailedCirrusSearch, ContentTranslation, Flow, GeoData, JsonConfig, MobileApp, MobileFrontend, Thanks, VisualEditor, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
GuidedTour FailedWikimediaMessages
ORES FailedWikimediaMessages
ParserFunctions FailedCirrusSearch, ContentTranslation, Flow, GeoData, JsonConfig, MobileApp, MobileFrontend, Thanks, VisualEditor, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
PdfHandler FailedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
PropertySuggester FailedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfoT204153
Renameuser FailedAbuseFilter, CheckUser, CirrusSearch, ContentTranslation, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
Scribunto FailedCirrusSearch, ContentTranslation, Flow, GeoData, JsonConfig, MobileApp, MobileFrontend, Thanks, VisualEditor, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfoT125050
SyntaxHighlight_GeSHi FailedCirrusSearch, ContentTranslation, Flow, GeoData, JsonConfig, MobileApp, MobileFrontend, Thanks, VisualEditor, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
WikibaseLexeme FailedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfoT204153
WikibaseQualityConstraints FailedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfoT204153
WikiEditor FailedAbuseFilter, CirrusSearch, ContentTranslation, FileImporter, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
WikimediaBadges FailedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfoT204153
WikimediaEvents FailedAbuseFilter, CirrusSearch, ContentTranslation, FileImporter, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo

! Extension ! Status ! Depended on by… !

AbuseFilter PassedCirrusSearch, ContentTranslation, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
AntiSpoof PassedAbuseFilter, CirrusSearch, ContentTranslation, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
CheckUser PassedAbuseFilter, CirrusSearch, ContentTranslation, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
CirrusSearch PassedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
cldr PassedCirrusSearch, GeoData, Translate, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
Echo PassedCirrusSearch, ContentTranslation, Flow, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
Elastica PassedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
EventLogging PassedAbuseFilter, CirrusSearch, ContentTranslation, Echo, FileImporter, Flow, GeoData, GuidedTour, MobileApp, MobileFrontend, NavigationTiming, Thanks, Translate, UniversalLanguageSelector, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
EventStreamConfig PassedAbuseFilter, CirrusSearch, ContentTranslation, Echo, EventLogging, FileImporter, Flow, GeoData, GuidedTour, MobileApp, MobileFrontend, NavigationTiming, Thanks, Translate, UniversalLanguageSelector, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
Flow PassedThanks
GeoData PassedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
JsonConfig PassedJsonConfig
Kartographer PassedJsonConfig
MobileApp PassedCirrusSearch, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
MobileFrontend PassedCirrusSearch, GeoData, MobileApp, MobileFrontend, Thanks, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
SiteMatrix PassedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
TemplateData PassedCirrusSearch, ContentTranslation, Flow, GeoData, JsonConfig, MobileApp, MobileFrontend, Thanks, VisualEditor, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
TimedMediaHandler PassedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
UniversalLanguageSelector PassedCirrusSearch, ContentTranslation, GeoData, Translate, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
VisualEditor PassedCirrusSearch, ContentTranslation, Flow, GeoData, JsonConfig, MobileApp, MobileFrontend, Thanks, VisualEditor, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
Wikibase PassedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
WikibaseCirrusSearch PassedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
WikibaseMediaInfo PassedCirrusSearch, GeoData, Wikibase, WikibaseCirrusSearch, WikibaseMediaInfo
WikimediaMessages PassedKartographer, JsonConfig

Related Objects

Event Timeline

hashar created this task.Sep 13 2018, 3:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2018, 3:19 PM
hashar updated the task description. (Show Details)Sep 13 2018, 3:27 PM
hashar updated the task description. (Show Details)Sep 13 2018, 3:36 PM

@hashar, would you please triage priority and placement on the RelEng Kanban board? Thanks!

greg triaged this task as Medium priority.Nov 21 2018, 12:18 AM
greg added a subscriber: greg.

@hashar, would you please triage priority and placement on the RelEng Kanban board? Thanks!

further grooming still needed (next steps etc)

From T204153:

I have created a dummy test that tracks whether dependencies of gated extensions are also in the gate https://gerrit.wikimedia.org/r/#/c/integration/config/+/460080/

The test is run daily and the test report is at https://integration.wikimedia.org/ci/job/integration-config-qa/lastBuild/testReport/ , that gives me failures such as:

Dependency of gated project is in gate: AbuseFilter ... ok
Dependency of gated project is in gate: AntiSpoof ... FAIL
Dependency of gated project is in gate: BetaFeatures ... FAIL
Dependency of gated project is in gate: Capiunto ... FAIL
Dependency of gated project is in gate: CentralAuth ... FAIL
Dependency of gated project is in gate: CheckUser ... ok
Dependency of gated project is in gate: CirrusSearch ... ok
Dependency of gated project is in gate: Cite ... FAIL
Dependency of gated project is in gate: CodeEditor ... FAIL
Dependency of gated project is in gate: Echo ... ok
Dependency of gated project is in gate: EducationProgram ... FAIL
Dependency of gated project is in gate: Elastica ... ok
Dependency of gated project is in gate: EventLogging ... ok
Dependency of gated project is in gate: Flow ... ok
Dependency of gated project is in gate: GeoData ... ok
Dependency of gated project is in gate: JsonConfig ... ok
Dependency of gated project is in gate: MobileApp ... ok
Dependency of gated project is in gate: MobileFrontend ... ok
Dependency of gated project is in gate: PdfHandler ... FAIL
Dependency of gated project is in gate: PropertySuggester ... FAIL
Dependency of gated project is in gate: Scribunto ... FAIL
Dependency of gated project is in gate: SiteMatrix ... ok
Dependency of gated project is in gate: SyntaxHighlight_GeSHi ... FAIL
Dependency of gated project is in gate: TimedMediaHandler ... ok
Dependency of gated project is in gate: UniversalLanguageSelector ... ok
Dependency of gated project is in gate: VisualEditor ... ok
Dependency of gated project is in gate: WikiEditor ... FAIL
Dependency of gated project is in gate: Wikibase ... ok
Dependency of gated project is in gate: WikibaseLexeme ... FAIL
Dependency of gated project is in gate: WikibaseMediaInfo ... FAIL
Dependency of gated project is in gate: WikibaseQuality ... FAIL
Dependency of gated project is in gate: WikibaseQualityConstraints ... FAIL
Dependency of gated project is in gate: WikimediaBadges ... FAIL
Dependency of gated project is in gate: ZeroBanner ... ok
Dependency of gated project is in gate: ZeroPortal ... ok
Dependency of gated project is in gate: cldr ... ok
Dependency of gated project is in gate: skins/MinervaNeue ... FAIL

Change 587848 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Add Kartographer to the gate

https://gerrit.wikimedia.org/r/587848

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptApr 9 2020, 7:01 PM

Change 587848 merged by jenkins-bot:
[integration/config@master] layout: Add Kartographer to the gate

https://gerrit.wikimedia.org/r/587848

Change 587858 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Add WikimediaMessages to the gate

https://gerrit.wikimedia.org/r/587858

Change 587858 merged by jenkins-bot:
[integration/config@master] layout: Add WikimediaMessages to the gate

https://gerrit.wikimedia.org/r/587858

Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)