That needs to be done in integration/jenkins.git under mediawiki/conf.d/.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
mediawiki.conf: Set $wgScribuntoDefaultEngine for speed | integration/jenkins | master | +10 -0 |
Event Timeline
BTW, if you don't already have the php-luasandbox or hhvm-luasandbox packages installed (matching whichever PHP you're running) on the CI hosts, you'll need to do that too.
The CI slaves are provisioned via the Puppet classes mediawiki::packages which also provision the Wikimedia production application servers.
I have verified, we have:
hhvm-luasandbox | 2.0.11 |
php-luasandbox | 2.0.11 |
@Anomie isn't Scribunto smart enough to detect whether luasandbox is available? I am just wondering :-}
It'll throw an exception with the message "The luasandbox extension is not present, this engine cannot be used." if you try to use that engine without the extension being present. There's no auto-detection in the default for $wgScribuntoDefaultEngine.
Sounds like we want to change it to do autodetection instead of adding special configuration to our CI.
Change 273405 had a related patch set uploaded (by Jforrester):
mediawiki.conf: Set $wgScribuntoDefaultEngine for speed
No, let's not wait for T128144: Auto-detection the default for $wgScribuntoDefaultEngine to get fixed when it's so disruptive right now.
Change 273405 merged by jenkins-bot:
mediawiki.conf: Set $wgScribuntoDefaultEngine for speed
When is now? Just little while ago I had a test for CX take ~20 minutes: https://integration.wikimedia.org/ci/job/mwext-testextension-php55/3137/
I have noticed that since we added https://gerrit.wikimedia.org/r/#/c/273405/ the php test extension has been taking longer and hvvm has gotten quicker.
It is applied for every job started since 2016-02-27T00:53 UTC ( https://phabricator.wikimedia.org/T128191#2068439 ).
Meanwhile the wikibase tests were updated to support this.
rEWBA56122b4a98ed: Use Scribunto_LuaEngineTestBase::getEngine instead of Scribunto…
Since then, the Jenkins mediawiki config patch has been re-applied.
rCIJEf3516f7e51fa: Revert "Revert "mediawiki.conf: Set $wgScribuntoDefaultEngine for speed""