Page MenuHomePhabricator
Create Task
Maniphest T132964

Allow EntityFactory to work in Wikibase for more entity types
Closed, ResolvedPublic
Actions

Description

In Wikibase Repo, EntityFactory is constructed with a hard-coded map of entity types -> class names.

Then, EntityFactory::newEmpty calls methods on the entity that might not exist for all entity types.

Details

SubjectRepoBranchLines +/-
Clean-up EntityFactory implementation and documentationmediawiki/extensions/Wikibasemaster+12 -26
Reduce EntityFactory implementation and usage to an absolute minimummediawiki/extensions/Wikibasemaster+11 -36
Take entity instantiator callbacks from WikibaseRepo.entitytypes.phpmediawiki/extensions/Wikibasemaster+37 -15
Let EntityFactory take callbacks instead of class names.mediawiki/extensions/Wikibasemaster+54 -30
Remove unused EntityFactory code and non-informational commentsmediawiki/extensions/Wikibasemaster+10 -103
Adjust EntityFactory::newEmpty to work for more entity typesmediawiki/extensions/Wikibasemaster+2 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidNoneT73781 Add support for a "Multi-Part" content model for use with MediaInfo / structured meta-data
 InvalidNoneT76006 code cleanup and refactoring of the mediawiki file page to be able to store structured data in it
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 ResolveddanielT134473 Create MediaInfo / Linking multimedia files to their mediainfo entity (second prototype)
 ResolvedTobi_WMDE_SWT125822 [Epic] Basic first prototype for structured data support for Commons
 ResolvedadrianheineT133767 Add EntityFactory callback to MediaInfo entity type definition
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolveddanielT129348 Inject entity services via callback definitions
 ResolveddanielT132964 Allow EntityFactory to work in Wikibase for more entity types

Event Timeline

aude created this task.Apr 18 2016, 8:27 PM
gerritbot subscribed.Apr 18 2016, 8:31 PM

Change 284070 had a related patch set uploaded (by Aude):
Adjust EntityFactory::newEmpty to work for more entity types

https://gerrit.wikimedia.org/r/284070

gerritbot added a project: Patch-For-Review.Apr 18 2016, 8:31 PM
aude added a comment.EditedApr 18 2016, 8:35 PM

also, do we still want EntityFactory to be deprecated? It is still problematic in many ways, but we can remove some of the assumptions if having this factory is important and useful.

only thing it appears used for is wbeditentity api module for creating a ne w empty entity when given some entity type.

gerritbot added a comment.Apr 19 2016, 3:29 PM

Change 284205 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Reduce EntityFactory implementation and usage to an absolute minimum

https://gerrit.wikimedia.org/r/284205

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 3:29 PM
gerritbot added a comment.Apr 19 2016, 3:41 PM

Change 284070 merged by jenkins-bot:
Adjust EntityFactory::newEmpty to work for more entity types

https://gerrit.wikimedia.org/r/284070

JeanFred unsubscribed.Apr 19 2016, 3:42 PM
gerritbot added a comment.Apr 20 2016, 4:55 PM

Change 284482 had a related patch set (by Daniel Kinzler) published:
Let EntityFactory take callbacks instead of class names.

https://gerrit.wikimedia.org/r/284482

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Apr 21 2016, 11:14 AM
gerritbot added a comment.Apr 24 2016, 7:30 AM

Change 285060 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused EntityFactory code and non-informational comments

https://gerrit.wikimedia.org/r/285060

Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-04-26.Apr 25 2016, 1:49 PM
thiemowmde added a parent task: T129348: Inject entity services via callback definitions.Apr 25 2016, 2:43 PM
thiemowmde merged a task: T133043: [Task] EntityFactory::newEmpty does not work for MediaInfo.
thiemowmde added a subscriber: JeanFred.
Tobi_WMDE_SW removed a project: Epic.Apr 26 2016, 1:05 PM
thiemowmde moved this task from Proposed to Doing on the Wikidata-Sprint-2016-04-26 board.Apr 26 2016, 1:05 PM
Tobi_WMDE_SW assigned this task to daniel.Apr 26 2016, 1:06 PM
gerritbot added a comment.Apr 26 2016, 5:48 PM

Change 285060 merged by jenkins-bot:
Remove unused EntityFactory code and non-informational comments

https://gerrit.wikimedia.org/r/285060

gerritbot added a comment.Apr 26 2016, 7:12 PM

Change 285446 had a related patch set uploaded (by Daniel Kinzler):
Take entity instantiator callbacks from WikibaseRepo.entitytypes.php

https://gerrit.wikimedia.org/r/285446

adrianheine moved this task from Doing to Review on the Wikidata-Sprint-2016-04-26 board.Apr 27 2016, 8:57 AM
adrianheine added a parent task: T133767: Add EntityFactory callback to MediaInfo entity type definition.
gerritbot added a comment.Apr 27 2016, 10:29 AM

Change 284482 merged by jenkins-bot:
Let EntityFactory take callbacks instead of class names.

https://gerrit.wikimedia.org/r/284482

gerritbot added a comment.Apr 27 2016, 10:45 AM

Change 285446 merged by jenkins-bot:
Take entity instantiator callbacks from WikibaseRepo.entitytypes.php

https://gerrit.wikimedia.org/r/285446

gerritbot added a comment.Apr 27 2016, 11:20 AM

Change 285626 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Clean-up EntityFactory implementation and documentation

https://gerrit.wikimedia.org/r/285626

gerritbot added a comment.Apr 27 2016, 11:22 AM

Change 284205 abandoned by Thiemo Mättig (WMDE):
Reduce EntityFactory implementation and usage to an absolute minimum

Reason:
Iee84df3 got merged instead.

https://gerrit.wikimedia.org/r/284205

adrianheine closed this task as Resolved.Apr 27 2016, 11:29 AM

Thanks, you two :)

adrianheine moved this task from Review to Done on the Wikidata-Sprint-2016-04-26 board.Apr 27 2016, 11:29 AM
JeanFred unsubscribed.Apr 27 2016, 11:36 AM
gerritbot added a comment.May 11 2016, 5:46 PM

Change 285626 merged by jenkins-bot:
Clean-up EntityFactory implementation and documentation

https://gerrit.wikimedia.org/r/285626

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL