Page MenuHomePhabricator

MediaViewer throws error after save in VisualEditor
Closed, ResolvedPublic1 Story Points

Description

Given that I have edited an article
And I have used VisualEditor
When I try to save
Then I expect the page to be saved
And that I will be returned to the new version

What happen is that I /sometimes/ will stay on the edited page, and get a new empty save dialog.

One page where this happen is no:Vassfaret

There is an error report in Firebug. This is from editing Vassfaret with VisualEditor and debug=true

TypeError: title.getExtension(...) is null
https://no.wikipedia.org/w/extensions/MultimediaViewer/resources/mmv/mmv.bootstrap.js?66f09
Line 183

Note that this interferes with the editors on nowiki, but not in a destructive manner. It is only annoying. It is not clear whether the bug is in VisualEditor and gets reported in MediaViewer, or if it is MediaViewer that interfers with VisualEditor.

Event Timeline

jeblad created this task.Jul 17 2016, 4:38 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 17 2016, 4:38 PM
jeblad triaged this task as High priority.Jul 17 2016, 4:40 PM
jeblad added projects: VisualEditor, MediaViewer.
jeblad updated the task description. (Show Details)
Elitre added a subscriber: Elitre.Jul 17 2016, 4:55 PM

Change 299514 had a related patch set uploaded (by Esanders):
Make Parsoid HTML selectors more specific

https://gerrit.wikimedia.org/r/299514

Change 299515 had a related patch set uploaded (by Esanders):
Limit image search to content firing event

https://gerrit.wikimedia.org/r/299515

This comment was removed by Esanders.

Change 299531 had a related patch set uploaded (by Esanders):
Check Title.newFromImg produced a valid title with an extension

https://gerrit.wikimedia.org/r/299531

Any of the above patches will fix this. At least one should be back-ported immediately.

Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.Jul 18 2016, 3:32 PM
Restricted Application added subscribers: Luke081515, TerraCodes. · View Herald TranscriptJul 18 2016, 3:32 PM
Esanders renamed this task from Fail on action after save in VisualEditor to MediaViewer throws error after save in VisualEditor.Jul 18 2016, 3:44 PM

Change 299531 merged by jenkins-bot:
Check Title.newFromImg produced a valid title with an extension

https://gerrit.wikimedia.org/r/299531

Change 299560 had a related patch set uploaded (by Jforrester):
Check Title.newFromImg produced a valid title with an extension

https://gerrit.wikimedia.org/r/299560

Change 299514 merged by jenkins-bot:
Make Parsoid HTML selectors more specific

https://gerrit.wikimedia.org/r/299514

Tgr added a subscriber: Tgr.Jul 18 2016, 11:00 PM

Thanks for fixing this! The same selector would for Flow (T64594: Media Viewer doesn't trigger on Flow-enabled talk pages) as well, right?

Change 299560 merged by jenkins-bot:
Check Title.newFromImg produced a valid title with an extension

https://gerrit.wikimedia.org/r/299560

Thanks for fixing this! The same selector would for Flow (T64594: Media Viewer doesn't trigger on Flow-enabled talk pages) as well, right?

Theoretically, but it doesn't seem to activate on http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow

Jdforrester-WMF closed this task as Resolved.Jul 18 2016, 11:05 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.

Now deployed to wmf.10 too.

Change 299515 merged by jenkins-bot:
Limit image search to content firing event

https://gerrit.wikimedia.org/r/299515

Thanks! Seems like my test article works now! :)

Restricted Application added a subscriber: Danmichaelo. · View Herald Transcript