@gerritbot not active anymore in Phabricator since Gerrit 2.12 upgrade
Closed, ResolvedPublic

Description

It looks like since the 2.12 upgrade, @gerritbot does not add Patch-For-Review and a comment including a link to the patch URL anymore. See https://phabricator.wikimedia.org/p/gerritbot/

Examples: https://phabricator.wikimedia.org/T139491#2491161 or https://phabricator.wikimedia.org/T140458#2491159 (the patches do include Bug: T9876543 in the commit message).

Aklapper created this task.Jul 25 2016, 7:15 AM
Aklapper triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Luke081515, TerraCodes. · View Herald TranscriptJul 25 2016, 7:15 AM
Aklapper assigned this task to demon.Jul 25 2016, 7:43 AM
Aklapper added a subscriber: demon.

(I just saw the email where @demon said that he's going to look at this after some sleep.)

Paladox edited projects, added GerritBot, Phabricator; removed Gerrit.Jul 25 2016, 8:18 AM

Added gerritbot and phabricator projects since the problem affects gerritbot but requires us to do something on phabricator end.

Paladox edited projects, added Gerrit; removed GerritBot.Jul 25 2016, 8:20 AM
Paladox edited projects, added GerritBot; removed Gerrit.

It seems there is a bug in phabricator.

It wont let me have both gerritbot and gerrit project.

[offtopic]

It seems there is a bug in phabricator.
It wont let me have both gerritbot and gerrit project.

That is intentional - Gerritbot is a subproject of Gerrit.

[offtopic]

Oh sorry, I didn't know that.

The token is already set, in the secret file.

Maybe it could be because we are on a new host that we forgot to move ~/.arcrc with it.

demon closed this task as Resolved.Jul 25 2016, 3:04 PM

Fixed.

@demon: Just for the record :P I assume it was the missing .arcrc file for the user, yes? :)

@Florian nope it was that a config in the all-project had to be set.

<ostriches> qchris: I turned the its plugin to true in All-Projects.

demon added a subscriber: QChris.Jul 25 2016, 3:11 PM

Nope! The phabricator-its plugin doesn't use .arcrc. Gerrit required it be set to "enabled" in the All-Projects repository. This is counter-intuitive! If you install a plugin, wouldn't you want it installed?! Anyway, one second fix once I was pointed in the right direction. Thanks @QChris :)

Ah, great, good to know :) Thanks for the prompt answer :P