It looks like since the 2.12 upgrade, @gerritbot does not add Patch-For-Review and a comment including a link to the patch URL anymore. See https://phabricator.wikimedia.org/p/gerritbot/
Examples: https://phabricator.wikimedia.org/T139491#2491161 or https://phabricator.wikimedia.org/T140458#2491159 (the patches do include Bug: T9876543 in the commit message).
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • demon | T141241 @gerritbot not active anymore in Phabricator since Gerrit 2.12 upgrade | |||
| Resolved | • demon | T70271 Upgrade gerrit to 2.12 | |||
| Declined | Bawolff | T106666 Consider changing gerrit default change screen to CHANGE_SCREEN2 | |||
| Resolved | • jcrespo | T139755 Need snapshot of 'reviewdb' on spare machine to test gerrit schema upgrades | |||
| Resolved | • demon | T131903 Update gerrit sshkey in role::ci::slave::labs when upgrade to Jessie happens | |||
| Resolved | Dzahn | T125018 replace gerrit server (ytterbium) with jessie server (lead) | |||
| Resolved | RobH | T123132 Need spare server to upgrade/migrate gerrit | |||
| Resolved | • Cmjohnson | T123531 check for memory upgrade for lead | |||
| Resolved | • demon | T126794 setup/deploy server lead as jessie gerrit server | |||
| Resolved | • Cmjohnson | T141415 decom ytterbium (datacenter) |
(I just saw the email where @demon said that he's going to look at this after some sleep.)
Added gerritbot and phabricator projects since the problem affects gerritbot but requires us to do something on phabricator end.
It seems there is a bug in phabricator.
It wont let me have both gerritbot and gerrit project.
The token is already set, in the secret file.
Maybe it could be because we are on a new host that we forgot to move ~/.arcrc with it.
@demon: Just for the record :P I assume it was the missing .arcrc file for the user, yes? :)
@Florian nope it was that a config in the all-project had to be set.
<ostriches> qchris: I turned the its plugin to true in All-Projects.
Nope! The phabricator-its plugin doesn't use .arcrc. Gerrit required it be set to "enabled" in the All-Projects repository. This is counter-intuitive! If you install a plugin, wouldn't you want it installed?! Anyway, one second fix once I was pointed in the right direction. Thanks @QChris :)
There still seem to be issues, e.g. yesterday's https://gerrit.wikimedia.org/r/#/c/302198/ in https://phabricator.wikimedia.org/T141743 ; or in https://phabricator.wikimedia.org/T138186
(Moved my last comment to T141887: GerritBot not always commenting on changes in Phabricator tasks)