Page MenuHomePhabricator
Create Task
Maniphest T141386

onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

onResourceLoaderGetConfigVars can not depend (indirectly) on isBetaGroupMember .

onResourceLoaderGetConfigVars must be 100% static. It can not depend on:

  • Current page
  • Current user
  • Current request

(This should probably be clarified in onResourceLoaderGetConfigVars and getWikibaseStaticConfigVars docs. Also, "vary with the html" does not sound right to me. It should not depend on which page and thus which HTML is requested.)

In this case, you can just check client-side using wgMFMode .

Trace is:

2016-07-26 17:34:20 [V5efHApEEaoAAHgCVmoAAAAH] deployment-mediawiki01 cawiki 1.28.0-alpha exception ERROR: [V5efHApEEaoAAHgCVmoAAAAH] /w/load.php?debug=false&lang=ca&modules=startup&only=scripts&skin=vector   BadMethodCallException from line 1025 of /srv/mediawiki/php-master/includes/session/SessionManager.php: Sessions are disabled for this entry point {"exception_id":"V5efHApEEaoAAHgCVmoAAAAH"} 
[Exception BadMethodCallException] (/srv/mediawiki/php-master/includes/session/SessionManager.php:1025) Sessions are disabled for this entry point
  #0 /srv/mediawiki/php-master/includes/session/SessionManager.php(187): MediaWiki\Session\SessionManager->getSessionFromInfo(MediaWiki\Session\SessionInfo, WebRequest)
  #1 /srv/mediawiki/php-master/includes/WebRequest.php(699): MediaWiki\Session\SessionManager->getSessionForRequest(WebRequest)
  #2 /srv/mediawiki/php-master/includes/user/User.php(1197): WebRequest->getSession()
  #3 /srv/mediawiki/php-master/includes/user/User.php(403): User->loadFromSession()
  #4 /srv/mediawiki/php-master/includes/user/User.php(2082): User->load()
  #5 /srv/mediawiki/php-master/includes/user/User.php(3476): User->getId()
  #6 /srv/mediawiki/php-master/includes/user/User.php(3484): User->isLoggedIn()
  #7 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/MobileContext.php(327): User->isAnon()
  #8 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/MobileContext.php(379): MobileContext->getMobileMode()
  #9 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/MobileContext.php(1207): MobileContext->isBetaGroupMember()
  #10 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/MobileFrontend.hooks.php(473): MobileContext->shouldShowWikibaseDescriptions(string)
  #11 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/MobileFrontend.hooks.php(458): MobileFrontendHooks::getWikibaseStaticConfigVars(MobileContext)
  #12 /srv/mediawiki/php-master/includes/Hooks.php(195): MobileFrontendHooks::onResourceLoaderGetConfigVars(array)
  #13 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderStartUpModule.php(117): Hooks::run(string, array)
  #14 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderStartUpModule.php(375): ResourceLoaderStartUpModule->getConfigSettings(DerivativeResourceLoaderContext)
  #15 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(713): ResourceLoaderStartUpModule->getDefinitionSummary(DerivativeResourceLoaderContext)
  #16 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(621): ResourceLoaderModule->getVersionHash(DerivativeResourceLoaderContext)
  #17 [internal function]: Closure$ResourceLoader::getCombinedVersion(string)
  #18 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(622): array_map(Closure$ResourceLoader::getCombinedVersion;1768148240, array)
  #19 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(674): ResourceLoader->getCombinedVersion(ResourceLoaderContext, array)
  #20 /srv/mediawiki/php-master/load.php(46): ResourceLoader->respond(ResourceLoaderContext)
  #21 /srv/mediawiki/w/load.php(3): include(string)
  #22 {main}

Caused by rEMFR880bc9644a75: Always show Wikidata descriptions in beta mode.

See also T127860: MobileFrontend using ResourceLoaderGetConfigVars hook with User dependent data.

Details

SubjectRepoBranchLines +/-
Revert "Always show Wikidata descriptions in beta mode"mediawiki/extensions/MobileFrontendmaster+2 -2
Revert "Always show Wikidata descriptions in beta mode"mediawiki/extensions/MobileFrontendwmf/1.28.0-wmf.12+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mattflaschen-WMF created this task.Jul 26 2016, 5:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2016, 5:58 PM
• Mattflaschen-WMF updated the task description. (Show Details)Jul 26 2016, 5:58 PM
• Mattflaschen-WMF updated the task description. (Show Details)Jul 26 2016, 6:01 PM
• bmansurov added subscribers: • Jhernandez, Jdlrobson, • jhobs, phuedx.Jul 26 2016, 6:48 PM
gerritbot subscribed.Jul 26 2016, 11:09 PM

Change 301310 had a related patch set uploaded (by Jdlrobson):
Revert "Always show Wikidata descriptions in beta mode"

https://gerrit.wikimedia.org/r/301310

Jdlrobson added a comment.Jul 26 2016, 11:10 PM

This is clarified in MobileFrontend's documentation:
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L399

Jdlrobson added a comment.Jul 26 2016, 11:11 PM

@Mattflaschen-WMF do we need to SWAT deploy the above fix?

Jdlrobson mentioned this in T141067: Wikidata descriptions are not showing in beta unless enabled in stable.Jul 26 2016, 11:11 PM
Krinkle subscribed.Jul 26 2016, 11:27 PM

This is also documented on https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetConfigVars and in hooks.txt. Including about using MakeGlobalVariablesScript instead if it is request-specific (user or page).

The underlying reason is that they come from a separate (static) web request. As such, aside from not being able to very by page, they are also not cached with the page they will update immediately and "affect" older pages).

Likewise, the request-specific export is cached in the page, and as such will not retroactively affect older pages. If the exported data is used by pre-existing modules, the newer version of that module must also support the older pages.

gerritbot added a comment.Jul 26 2016, 11:47 PM

Change 301312 had a related patch set uploaded (by Reedy):
Revert "Always show Wikidata descriptions in beta mode"

https://gerrit.wikimedia.org/r/301312

Jdforrester-WMF added a parent task: T139214: MW-1.28.0-wmf.12 deployment blockers.Jul 26 2016, 11:49 PM
• Mattflaschen-WMF added a subscriber: Reedy.Jul 26 2016, 11:53 PM
In T141386#2497297, @Jdlrobson wrote:

This is clarified in MobileFrontend's documentation:
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L399

Yes, the "isBetaGroupMember" part, but see my note in the original report about "vary with the html". That doesn't sound right.

In T141386#2497299, @Jdlrobson wrote:

@Mattflaschen-WMF do we need to SWAT deploy the above fix?

@Reedy is deploying it now.

gerritbot added a comment.Jul 26 2016, 11:56 PM

Change 301312 merged by jenkins-bot:
Revert "Always show Wikidata descriptions in beta mode"

https://gerrit.wikimedia.org/r/301312

Stashbot subscribed.Jul 26 2016, 11:59 PM

Mentioned in SAL [2016-07-26T23:59:04Z] <reedy@tin> Synchronized php-1.28.0-wmf.12/extensions/MobileFrontend/: Deploy revert for group0 for T141386 (duration: 00m 30s)

gerritbot added a comment.Jul 26 2016, 11:59 PM

Change 301310 merged by jenkins-bot:
Revert "Always show Wikidata descriptions in beta mode"

https://gerrit.wikimedia.org/r/301310

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)), MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)).Jul 27 2016, 12:01 AM
phuedx triaged this task as Unbreak Now! priority.Jul 27 2016, 12:24 PM
phuedx added a project: Reading-Web-Sprint-77-Segmentation-fault.
Restricted Application added subscribers: Luke081515, TerraCodes. · View Herald TranscriptJul 27 2016, 12:24 PM
phuedx assigned this task to dr0ptp4kt.Jul 27 2016, 12:25 PM
phuedx moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-77-Segmentation-fault board.
phuedx added a project: Unplanned-Sprint-Work.Jul 27 2016, 5:10 PM
MBinder_WMF set the point value for this task to 0.5.Jul 27 2016, 5:13 PM
MBinder_WMF removed the point value for this task.
• jhobs added a project: Web-Team-Backlog.Jul 27 2016, 5:24 PM
greg subscribed.Jul 27 2016, 7:06 PM
In T141386#2497414, @Mattflaschen-WMF wrote:
In T141386#2497299, @Jdlrobson wrote:

@Mattflaschen-WMF do we need to SWAT deploy the above fix?

@Reedy is deploying it now.

Just for recording keeping: because of ^^ that means this should no longer block the wmf.12 release rolling to group1 (non-wikipedias) today, right?

thcipriani subscribed.Jul 27 2016, 7:07 PM

Since the revert has been merged and deployed is this still blocking the train?

Reedy added a comment.Jul 27 2016, 7:53 PM

No reason it should block

Krinkle added a parent task: T139215: MW-1.28.0-wmf.13 deployment blockers.Jul 27 2016, 8:25 PM
greg added a comment.Jul 27 2016, 8:35 PM

@Krinkle: do you disagree that this shouldn't block the deployment (iow: do you think it should)?

Krinkle added a comment.Jul 27 2016, 8:39 PM
In T141386#2500120, @greg wrote:

@Krinkle: do you disagree that this shouldn't block the deployment (iow: do you think it should)?

My mistake. I thought it was only reverted in wmf.12 and not in master. I meant to agree on this weeks unblock and added to next week, but undone now.

Krinkle removed a parent task: T139215: MW-1.28.0-wmf.13 deployment blockers.Jul 27 2016, 8:39 PM
greg added a comment.Jul 27 2016, 8:41 PM

np :)

MBinder_WMF moved this task from Incoming to 2016-17 Q1 on the Web-Team-Backlog board.Jul 28 2016, 8:04 PM
phuedx closed this task as Resolved.Jul 29 2016, 10:19 AM

(Per the conversation above.)

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Aklapper removed subscribers: • jhobs, Anomie, • Mattflaschen-WMF.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL