Page MenuHomePhabricator

Consider not using icons in Modern and CologneBlue skins for notifications
Open, LowestPublic

Description

echo_cologneblue_new.png (321×187 px, 15 KB)

echo_modern_new.png (81×571 px, 9 KB)

In general these suck. I propose that instead of using icons we simply use text labels like "Alerts: #" and "Notices: #". I don't think we should even bother opening the flyout on these skins, and just send them to Special:notifications directly since it no longer sucks (it's awesome!)

I think this will reduce the amount of work we need to do to properly support these skins in the long run.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I don't think we're going to get rid of those icons. We might consider not displaying them for non-vector, I guess. Input from @Catrope, @jmatazzoni and @Pginer-WMF ?

Right, keeping the icons in MonoBook-based skins (Vector and MonoBook), but get rid of them in everything else (CologneBlue and Modern effectively)

The proposal sounds good to me.

My only question is: if we are sending people to the Notification page where alerts and notices are presented together, do we need two separate badges in this case?

On the one hand, it feels weird to provide two separate entry points targeting the same exact destination. On the other hand, providing one single entry point won't facilitate the user decision process on whether to interrupt the current activities to check urgent notifications or read them at her own pace for less urgent notifications.

Change 345969 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/extensions/Echo@master] Do not use fancy styled badge on Modern and CologneBlue

https://gerrit.wikimedia.org/r/345969

The patch above keeps the flyout and the two links, but it makes them simple text instead of icons.

Some of the flyout styles are a bit messed up, but it's not a new issue, and the flyout is functional.

BeforeBefore (with flyout)AfterAfter (with flyout)
CologneBlue
pasted_file (951×1 px, 220 KB)
pasted_file (951×1 px, 243 KB)
pasted_file (951×1 px, 221 KB)
pasted_file (951×1 px, 244 KB)
Modern
pasted_file (951×1 px, 199 KB)
pasted_file (951×1 px, 202 KB)
pasted_file (951×1 px, 199 KB)
pasted_file (951×1 px, 202 KB)

Change 345969 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Do not use fancy styled badge on Modern and CologneBlue

https://gerrit.wikimedia.org/r/345969

Change 346343 had a related patch set uploaded (by Mooeypoo):
[mediawiki/extensions/Echo@master] Use formatted text label for echo badge icons in different skins

https://gerrit.wikimedia.org/r/346343

Change 346343 abandoned by Mooeypoo:
[wip] Use formatted text label for echo badge icons in different skins

Reason:
Deprioritized; if anyone wants to pick this back up (and see how to also fix the bug that the code is blocked on) feel free.

https://gerrit.wikimedia.org/r/346343

matmarex lowered the priority of this task from Low to Lowest.May 29 2017, 1:47 PM
matmarex removed a project: Patch-For-Review.

Patch was reverted due to T162173.

matmarex added a subscriber: matmarex.

T226503 (and its outcome T226594) are probably another reason to consider this.

Probably the best way to do this is to just add an option skins can enable (or just a very specific thing to override/kill) to make it all text-based. I doubt this would actually make sense as a thing to make default for all skins, as many other third-party skins do indeed use icons, and a lot more heavily than, say, MonoBook or Vector, but having it as an option for these specific ones (and any others people make like them) would be good...

And while we're at it could we add an option to make it a single icon/link? As text there'd not be much use having them separate since they both just go to the same place in the end, and holy crap is having two icons bad for mobile in a lot of cases.

I checked how icons in CologneBlue and Modern look like (comparing it with the screenshots in https://phabricator.wikimedia.org/T141944#3148178.

CologneBlue
Screen Shot 2019-07-24 at 3.16.39 PM.png (312×728 px, 71 KB)
Screen Shot 2019-07-24 at 3.16.50 PM.png (581×559 px, 89 KB)
"You have new messages" is partially obscured
Screen Shot 2019-07-24 at 3.17.10 PM.png (249×256 px, 29 KB)
Modern
Screen Shot 2019-07-24 at 3.17.53 PM.png (390×617 px, 105 KB)
Screen Shot 2019-07-24 at 3.18.07 PM.png (488×583 px, 75 KB)
somewhat hard to see blue (active) color for Notices against blue background
Screen Shot 2019-07-24 at 3.19.22 PM.png (269×696 px, 69 KB)

Giving that this task has been of exploratory kind and that CologneBlue and Modern skins are not actively supported, I mark the task as 'External'.

Jdlrobson edited projects, added Modern (Tracking); removed Modern.