Page MenuHomePhabricator

Consider not using icons in Modern and CologneBlue skins for notifications
Open, LowestPublic

Description

In general these suck. I propose that instead of using icons we simply use text labels like "Alerts: #" and "Notices: #". I don't think we should even bother opening the flyout on these skins, and just send them to Special:notifications directly since it no longer sucks (it's awesome!)

I think this will reduce the amount of work we need to do to properly support these skins in the long run.

Event Timeline

Legoktm created this task.Aug 2 2016, 10:40 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 2 2016, 10:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I don't think we're going to get rid of those icons. We might consider not displaying them for non-vector, I guess. Input from @Catrope, @jmatazzoni and @Pginer-WMF ?

Right, keeping the icons in MonoBook-based skins (Vector and MonoBook), but get rid of them in everything else (CologneBlue and Modern effectively)

The proposal sounds good to me.

My only question is: if we are sending people to the Notification page where alerts and notices are presented together, do we need two separate badges in this case?

On the one hand, it feels weird to provide two separate entry points targeting the same exact destination. On the other hand, providing one single entry point won't facilitate the user decision process on whether to interrupt the current activities to check urgent notifications or read them at her own pace for less urgent notifications.

matmarex claimed this task.Apr 1 2017, 12:52 PM
matmarex added a subscriber: Esanders.

Change 345969 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/extensions/Echo@master] Do not use fancy styled badge on Modern and CologneBlue

https://gerrit.wikimedia.org/r/345969

The patch above keeps the flyout and the two links, but it makes them simple text instead of icons.

Some of the flyout styles are a bit messed up, but it's not a new issue, and the flyout is functional.

BeforeBefore (with flyout)AfterAfter (with flyout)
CologneBlue
Modern

Change 345969 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Do not use fancy styled badge on Modern and CologneBlue

https://gerrit.wikimedia.org/r/345969

Change 346343 had a related patch set uploaded (by Mooeypoo):
[mediawiki/extensions/Echo@master] Use formatted text label for echo badge icons in different skins

https://gerrit.wikimedia.org/r/346343

matmarex triaged this task as Low priority.Apr 5 2017, 3:29 PM

Change 346343 abandoned by Mooeypoo:
[wip] Use formatted text label for echo badge icons in different skins

Reason:
Deprioritized; if anyone wants to pick this back up (and see how to also fix the bug that the code is blocked on) feel free.

https://gerrit.wikimedia.org/r/346343

matmarex lowered the priority of this task from Low to Lowest.May 29 2017, 1:47 PM
matmarex removed a project: Patch-For-Review.

Patch was reverted due to T162173.

matmarex removed matmarex as the assignee of this task.Feb 8 2018, 10:08 PM
matmarex added a subscriber: matmarex.
Restricted Application added a project: Growth-Team. · View Herald TranscriptWed, Jun 26, 9:25 AM

T226503 (and its outcome T226594) are probably another reason to consider this.