Page MenuHomePhabricator

Fix bug with Froms' statements always switching to edit mode on page load
Closed, ResolvedPublic

Description

Currently, when you open a Lexeme page, Form's statements rendered correctly, but switch to edit mode as soon as page is loaded.

They should stay in view mode unless user clicked an Edit button.

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseLexeme : masterJS LexemeDeserializer also deserializes statements on forms
mediawiki/extensions/WikibaseLexeme : masterLexemeSerializer also serializes statements on forms
mediawiki/extensions/WikibaseLexeme : masterLexeme can find statements on LexemeForms by GUID
mediawiki/extensions/WikibaseLexeme : masterMove example data from LexemeView to LexemeContent to make it "visible" to serializers
mediawiki/extensions/Wikibase : masterOptional statement data embedding

Related Objects

StatusAssignedTask
OpenNone
ResolvedAddshore
ResolvedAddshore
ResolvedAddshore
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
Resolveddaniel
ResolvedNone
Resolvedthiemowmde
ResolvedNone
Resolved Jonas
ResolvedLydia_Pintscher
Resolveddaniel
ResolvedNone
Resolvedthiemowmde
ResolvedJakob_WMDE
ResolvedJakob_WMDE
ResolvedWMDE-leszek
ResolvedWMDE-leszek
ResolvedWMDE-leszek
DuplicateNone
ResolvedWMDE-leszek
ResolvedLydia_Pintscher
ResolvedNone
ResolvedLucas_Werkmeister_WMDE
ResolvedLydia_Pintscher
Resolved Aleksey_WMDE
ResolvedWMDE-leszek
Resolved Jonas
Resolved Jonas
ResolvedJakob_WMDE
Resolved Jonas
InvalidNone
ResolvedLydia_Pintscher
ResolvedNone
Resolved Aleksey_WMDE
ResolvedWMDE-leszek
ResolvedLydia_Pintscher
ResolvedNone
ResolvedLydia_Pintscher
ResolvedNone
ResolvedLadsgroup
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
Resolved Aleksey_WMDE
ResolvedJakob_WMDE

Event Timeline

Change 353337 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Optional statement data embedding

https://gerrit.wikimedia.org/r/353337

Aleksey_WMDE renamed this task from Bix bug with Froms' statements always switching to edit mode on page load to Fix bug with Froms' statements always switching to edit mode on page load.May 16 2017, 11:17 AM

Change 353337 abandoned by Aleksey Bekh-Ivanov (WMDE):
Optional statement data embedding

Reason:
Abandoned in favor of Iaf14bbb4df9ec0af0879aa206a28a77bb52db671

https://gerrit.wikimedia.org/r/353337

Change 354239 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Move example data from LexemeView to LexemeContent to make it "visible" to serializers

https://gerrit.wikimedia.org/r/354239

Change 354219 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeSerializer also serializes statements on forms

https://gerrit.wikimedia.org/r/354219

Change 354231 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] JS LexemeDeserializer also serializes statements on forms

https://gerrit.wikimedia.org/r/354231

Change 354022 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Lexeme can find statements on LexemeForms by GUID

https://gerrit.wikimedia.org/r/354022

Change 354239 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Move example data from LexemeView to LexemeContent to make it "visible" to serializers

https://gerrit.wikimedia.org/r/354239

Change 354022 abandoned by Aleksey Bekh-Ivanov (WMDE):
Lexeme can find statements on LexemeForms by GUID

Reason:
Not needed anymore

https://gerrit.wikimedia.org/r/354022

Change 354219 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LexemeSerializer also serializes statements on forms

https://gerrit.wikimedia.org/r/354219

Change 354231 merged by WMDE-leszek:
[mediawiki/extensions/WikibaseLexeme@master] JS LexemeDeserializer also deserializes statements on forms

https://gerrit.wikimedia.org/r/354231

Aleksey_WMDE closed this task as Resolved.Jun 6 2017, 12:53 PM