Page MenuHomePhabricator
Create Task
Maniphest T165482

When save a Form's statement it should be persisted on the client and rendered correctly
Closed, ResolvedPublic
Actions

Description

Currently, when you change and save statement on the Lexeme Form it is persisted as Lexeme's statement (also, sometimes error message appears and nothing is persisted)

How it should work: when I click save on changed (or newly added) Form's statement no request is sent to the server (request is mocked) and statement list displays this statement as if it was persisted correctly.
On page reload it is expected to disappear.

Details

SubjectRepoBranchLines +/-
Fake saving statements on Formsmediawiki/extensions/WikibaseLexememaster+18 -1
Create form with correct lexeme IDmediawiki/extensions/WikibaseLexememaster+33 -13
Don't let statements to be created until the Form is savedmediawiki/extensions/WikibaseLexememaster+32 -19
Initialize statements for Lexeme and Forms independentlymediawiki/extensions/WikibaseLexememaster+18 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata
 ResolvedAddshoreT168260 Deploy WikibaseLexeme extension on Wikimedia cluster
 ResolvedAddshoreT191457 Deploy WikibaseLexeme on www.wikidata.org
 ResolvedAddshoreT191458 Deploy WikibaseLexeme on test.wikidata.org
 ResolvedLydia_PintscherT168263 WikibaseLexeme functional baseline
 ResolvedLydia_PintscherT159703 [Tracking] Support for Forms and Senses
 ResolvedLydia_PintscherT150178 Wikidata 2017 Q2 goals
 ResolvedLydia_PintscherT169708 Wikidata 2017 Q3 goals
 ResolvedLydia_PintscherT160052 [Epic] Support for Forms
 ResolveddanielT160521 [Epic] Forms of a Lexeme (UI)
 ResolvedNoneT160520 [Story] Section header for Forms
 ResolvedthiemowmdeT161092 Create LexemeFormsView and use it in LexemeView
 ResolvedNoneT161093 Create browser tests for section header for forms
 Resolved• JonasT161201 Run browser tests in CI
 ResolvedLydia_PintscherT160522 [Story] List of Forms (UI)
 ResolveddanielT164743 [Story] Add Form to list of Forms (UI)
 ResolvedNoneT160524 [Story] Add Form to list of Forms (non-persistent)
 ResolvedthiemowmdeT161789 [Task] Introduce HTML templates infrastructure for Wikibase Lexeme
 ResolvedJakob_WMDET162254 [Task] Move existing HTML from views to templates.php
 ResolvedJakob_WMDET162338 Add browsertests for 'Add Form to list of Forms'
 ResolvedWMDE-leszekT162339 Create "formlist" widget for list of Forms
 ResolvedWMDE-leszekT162340 Implement Form widget
 ResolvedWMDE-leszekT162341 Create an "add" button to add a Form to a list of Forms and wire it to display "add Form"
 DuplicateNoneT162342 Make the "add" button display the "add Form" form
 ResolvedWMDE-leszekT162343 Make the "save" button add the new form to the list widget
ResolvedLydia_PintscherT173743 [Story] Representations of a Form
 ResolvedNoneT173744 persistently addable/editable/removable Representations of a Form via the UI (M)
 Resolved• Lucas_Werkmeister_WMDET178389 Create API for updating Form descriptions
 ResolvedLydia_PintscherT160525 [Story] Grammatical Feature of a Form
 Resolved• Aleksey_WMDET162788 [Story] basic non-editable list of Grammatical Features of a Form
 ResolvedWMDE-leszekT162790 [Story] basic editable list of Grammatical Features of a Form
 Resolved• JonasT163971 Investigate what widget could be used to render the editable list of Grammatical Features of a Form
 Resolved• JonasT164361 Create MenuTagMultiselectWidget for Grammatical Feature List
 ResolvedJakob_WMDET163972 Create browser test for the editing the list of Grammatical Features of a Form feature
 Resolved• JonasT164471 Create jquery ui widget for Grammatical Feature List
 InvalidNoneT162797 [Story] Grammatical Forms look like faked statements
 ResolvedLydia_PintscherT163785 [Story] UX design for a Form's list of grammatical features
ResolvedNoneT173742 persistently editable Grammatical Feature of a Form via the UI (M)
 Resolved• Aleksey_WMDET176473 [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer
 ResolvedWMDE-leszekT184409 Create the API module allowing editing the representation, and the grammatical features of a Form (days: 4)
 ResolvedLydia_PintscherT184411 UI: Use the API to save edits of grammatical features of the form (days: 1)
 ResolvedNoneT184702 Set the edit summary when editing the representation and/or grammatical features of the form
 ResolvedLydia_PintscherT160526 [Story] List of Statements for a Form
 ResolvedNoneT164742 [Story] Add Form to list of Forms (persistent)
 ResolvedLadsgroupT182424 Diffs for statements, grammatical features and representations of a form (M) (days: 9)
 ResolvedLydia_PintscherT165588 tasks for lexicographical data support until Wikimania 2017
 ResolvedLydia_PintscherT163723 [Story] non-persistently editable statements on a Form
 Resolved• Aleksey_WMDET165482 When save a Form's statement it should be persisted on the client and rendered correctly
 ResolvedJakob_WMDET165575 [Story] Multi-variant Representations (UI)

Event Timeline

• Aleksey_WMDE created this task.May 16 2017, 11:06 AM
• Aleksey_WMDE updated the task description. (Show Details)May 16 2017, 11:16 AM
gerritbot subscribed.May 22 2017, 12:33 PM

Change 355102 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Don't let statements to be created until the Form is saved

https://gerrit.wikimedia.org/r/355102

gerritbot added a project: Patch-For-Review.May 22 2017, 12:33 PM
• Aleksey_WMDE mentioned this in rEWLE223b287f790d: Don't let statements to be created until the Form is saved.May 22 2017, 12:34 PM
gerritbot added a comment.May 22 2017, 4:25 PM

Change 355127 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Initialize statements for Lexeme and Forms independently

https://gerrit.wikimedia.org/r/355127

• Aleksey_WMDE mentioned this in rEWLE19c70958cb31: Initialize statements for Lexeme and Forms independently.May 22 2017, 4:25 PM
gerritbot added a comment.May 22 2017, 5:39 PM

Change 355135 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Create form with correct lexeme ID

https://gerrit.wikimedia.org/r/355135

gerritbot added a comment.May 22 2017, 5:39 PM

Change 355136 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fake saving statements on Forms

https://gerrit.wikimedia.org/r/355136

• Aleksey_WMDE mentioned this in rEWLE86bb0aa9160b: Create form with correct lexeme ID.May 22 2017, 5:40 PM
• Aleksey_WMDE mentioned this in rEWLE5930b15dc883: Fake saving statements on Forms.
• Aleksey_WMDE claimed this task.May 22 2017, 5:51 PM
• Aleksey_WMDE moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
• Aleksey_WMDE added a comment.May 24 2017, 11:20 AM

Add a browser test!

gerritbot added a comment.May 25 2017, 9:30 AM

Change 355127 abandoned by Aleksey Bekh-Ivanov (WMDE):
Initialize statements for Lexeme and Forms independently

Reason:
In favor of Ib69f803c492d7e8521523ef876d67d1517e836f6

https://gerrit.wikimedia.org/r/355127

• Aleksey_WMDE mentioned this in rEWLEa0b4690bc826: Don't let statements to be created until the Form is saved.May 25 2017, 6:22 PM
• Aleksey_WMDE mentioned this in rEWLEb22cd74a9808: Create form with correct lexeme ID.May 25 2017, 6:28 PM
• Aleksey_WMDE mentioned this in rEWLE6661dd681c16: Fake saving statements on Forms.
• Aleksey_WMDE mentioned this in rEWLEfc188f573c43: Create form with correct lexeme ID.May 25 2017, 7:35 PM
• Aleksey_WMDE mentioned this in rEWLEd1afb1de28f2: Fake saving statements on Forms.
• Aleksey_WMDE mentioned this in rEWLEd51f0362efba: Fake saving statements on Forms.May 25 2017, 7:38 PM
• Aleksey_WMDE mentioned this in rEWLEe3df795f826c: Don't let statements to be created until the Form is saved.May 29 2017, 9:22 AM
WMDE-leszek mentioned this in rEWLE8b4d431a83d2: Create form with correct lexeme ID.May 29 2017, 3:23 PM
WMDE-leszek mentioned this in rEWLEce6fdbe6d87e: Create form with correct lexeme ID.
• Aleksey_WMDE mentioned this in rEWLE7c4b40696fff: Fake saving statements on Forms.May 29 2017, 3:54 PM
gerritbot added a comment.May 29 2017, 4:40 PM

Change 355102 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Don't let statements to be created until the Form is saved

https://gerrit.wikimedia.org/r/355102

WMDE-leszek mentioned this in rEWLEae4669726f70: Create form with correct lexeme ID.May 30 2017, 8:23 AM
gerritbot added a comment.May 30 2017, 8:48 AM

Change 355135 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Create form with correct lexeme ID

https://gerrit.wikimedia.org/r/355135

WMDE-leszek mentioned this in rEWLEcad27b1d86d1: Fake saving statements on Forms.May 30 2017, 8:51 AM
gerritbot added a comment.May 30 2017, 9:22 AM

Change 355136 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fake saving statements on Forms

https://gerrit.wikimedia.org/r/355136

• Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.May 31 2017, 10:00 AM
• Aleksey_WMDE closed this task as Resolved.Jun 6 2017, 12:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL