Page MenuHomePhabricator

When save a Form's statement it should be persisted on the client and rendered correctly
Closed, ResolvedPublic

Description

Currently, when you change and save statement on the Lexeme Form it is persisted as Lexeme's statement (also, sometimes error message appears and nothing is persisted)

How it should work: when I click save on changed (or newly added) Form's statement no request is sent to the server (request is mocked) and statement list displays this statement as if it was persisted correctly.
On page reload it is expected to disappear.

Related Objects

StatusAssignedTask
OpenNone
Resolved Addshore
Resolved Addshore
Resolved Addshore
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
Resolveddaniel
ResolvedNone
Resolvedthiemowmde
ResolvedNone
Resolved Jonas
ResolvedLydia_Pintscher
Resolveddaniel
ResolvedNone
Resolvedthiemowmde
ResolvedJakob_WMDE
ResolvedJakob_WMDE
ResolvedWMDE-leszek
ResolvedWMDE-leszek
ResolvedWMDE-leszek
DuplicateNone
ResolvedWMDE-leszek
ResolvedLydia_Pintscher
ResolvedNone
ResolvedLucas_Werkmeister_WMDE
ResolvedLydia_Pintscher
Resolved Aleksey_WMDE
ResolvedWMDE-leszek
Resolved Jonas
Resolved Jonas
ResolvedJakob_WMDE
Resolved Jonas
InvalidNone
ResolvedLydia_Pintscher
ResolvedNone
Resolved Aleksey_WMDE
ResolvedWMDE-leszek
ResolvedLydia_Pintscher
ResolvedNone
ResolvedLydia_Pintscher
ResolvedNone
ResolvedLadsgroup
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
Resolved Aleksey_WMDE
ResolvedJakob_WMDE

Event Timeline

Change 355102 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Don't let statements to be created until the Form is saved

https://gerrit.wikimedia.org/r/355102

Change 355127 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Initialize statements for Lexeme and Forms independently

https://gerrit.wikimedia.org/r/355127

Change 355135 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Create form with correct lexeme ID

https://gerrit.wikimedia.org/r/355135

Change 355136 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fake saving statements on Forms

https://gerrit.wikimedia.org/r/355136

Add a browser test!

Change 355127 abandoned by Aleksey Bekh-Ivanov (WMDE):
Initialize statements for Lexeme and Forms independently

Reason:
In favor of Ib69f803c492d7e8521523ef876d67d1517e836f6

https://gerrit.wikimedia.org/r/355127

Change 355102 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Don't let statements to be created until the Form is saved

https://gerrit.wikimedia.org/r/355102

Change 355135 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Create form with correct lexeme ID

https://gerrit.wikimedia.org/r/355135

Change 355136 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fake saving statements on Forms

https://gerrit.wikimedia.org/r/355136

Aleksey_WMDE closed this task as Resolved.Jun 6 2017, 12:53 PM