Maniphest T195244

Investigate and make improvements to the extension review process
Open, MediumPublic
Actions

Assigned To

None

Authored By

	greg
	May 21 2018, 10:53 AM

Description

Context

Two of the most recent causes for this topic to come up:

Greg had a conversation at the Hackathon that reiterated the issue with discoverability and clarity of getting new code/extensions/services into production at WMF.
During the post-mortem meeting of a recent ORES related incident, the extension submittal review process was discussed and we decided that it would be worth reviewing it for completeness.

Initial brain dump

Can we make it obviously clear to outsiders (volunteer developers or even WMDE developers) who they need to talk to and what process they should follow?

First obvious questions:

Why is the wiki page named "Review queue"?
Why is that page on mw.org?

Existing/historical relevant pages

Related Objects
Search...

Status	Assigned	Task
Open	None	T203703 Create production code deployment management process
Open	None	T195244 Investigate and make improvements to the extension review process
Open	None	T203698 Add Code Stewardship review to Review Queue process
Open	None	T203701 Add Services (and other non-extensions) to the deployment review process

Event Timeline

greg triaged this task as Medium priority.May 21 2018, 10:53 AM

greg created this task.

Restricted Application added a project: User-greg. · View Herald TranscriptMay 21 2018, 10:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Why is the wiki page named "Review queue"?

Not an answer, but for historical context: I merged two existing pages in T142081: Merge Wikimedia's "Deployment checklist for new extensions" doc pages.

Can we make it obviously clear to outsiders (volunteer developers or even WMDE developers) who they need to talk to and what process they should follow?

...or WMSE, on my list in T190076: Investigate potential process improvements how to get (third party maintained) software deployed on Wikimedia sites but not sure when I'm going to get to it and I won't be unhappy if you're faster.
@greg: Shall T190076 and T195244 get merged, if I interpret the task scopes correctly?

greg moved this task from Backlog to Next on the User-greg board.Jun 12 2018, 11:05 PM

In T195244#4235175, @Aklapper wrote:

@greg: Shall T190076 and T195244 get merged, if I interpret the task scopes correctly?

Sure :)

Aklapper mentioned this in T190076: Investigate potential process improvements how to get (third party maintained) software deployed on Wikimedia sites.Jun 25 2018, 11:58 AM

Aklapper merged a task: T190076: Investigate potential process improvements how to get (third party maintained) software deployed on Wikimedia sites.

Aklapper added subscribers: Quiddity, Lokal_Profil, Sebastian_Berlin-WMSE and 2 others.

• Vvjjkkii renamed this task from Re-think/factor [[mw:Review queue]] and generally the process of getting new code into production to vjcaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii removed greg as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from vjcaaaaaaa to Re-think/factor [[mw:Review queue]] and generally the process of getting new code into production.Jul 2 2018, 4:44 AM

CommunityTechBot assigned this task to greg.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Sebastian_Berlin-WMSE awarded a token.Jul 4 2018, 8:33 AM

bd808 awarded a token.Jul 10 2018, 6:03 PM

bd808 subscribed.

Flipping this redirect around the other direction would be a start -- https://www.mediawiki.org/w/index.php?title=Writing_an_extension_for_deployment&redirect=no

I knew what I was looking for on mediawiki.org and it still took me 4 searches to land on [[Review_queue]].

I've added some relevant (I think) links to the description, to aid in discussion.

Comments from the duplicate I'm merging in:

In T182731#3861293, @Jrbranaa wrote:

Reached out to Daniel for more info. Also reached out to Marko regarding the review process for services.

In T182731#4002912, @Jrbranaa wrote:

Moved to blocked as I am waiting for response from Daniel on my request.

greg merged a task: T182731: Investigate the Extension Submittal Review process.Jul 13 2018, 10:28 PM

greg added a subscriber: Peachey88.

Aklapper mentioned this in T203697: Refresh the Production Deployment Review Process (aka Review Queue).Sep 7 2018, 11:02 AM

Jrbranaa added a parent task: T203703: Create production code deployment management process.Sep 13 2018, 5:53 PM

Jrbranaa added a subtask: T203698: Add Code Stewardship review to Review Queue process.

Jrbranaa added a subtask: T203701: Add Services (and other non-extensions) to the deployment review process.Sep 13 2018, 5:55 PM

Jrbranaa merged a task: T203697: Refresh the Production Deployment Review Process (aka Review Queue).Sep 13 2018, 5:57 PM

Jrbranaa moved this task from Blocked (externally) to In-progress on the Release-Engineering-Team (Kanban) board.Oct 22 2018, 4:37 PM

• Mholloway subscribed.Mar 21 2019, 4:44 PM

greg claimed this task.Mar 21 2019, 6:38 PM

Restricted Application added a project: User-greg. · View Herald TranscriptMar 21 2019, 6:38 PM

greg edited projects, added Release-Engineering-Team-TODO (201907); removed Release-Engineering-Team (Kanban).Jul 1 2019, 9:20 PM

greg moved this task from INBOX to Doing on the Release-Engineering-Team-TODO (201907) board.Jul 1 2019, 9:21 PM

greg edited projects, added Release-Engineering-Team-TODO (201908); removed Release-Engineering-Team-TODO (201907).Jul 29 2019, 4:37 PM

greg moved this task from INBOX to Ready on the Release-Engineering-Team-TODO (201908) board.Jul 29 2019, 4:40 PM

Jopparn unsubscribed.Jul 30 2019, 8:46 AM

greg edited projects, added Release-Engineering-Team-TODO (201909); removed Release-Engineering-Team-TODO (201908).Sep 11 2019, 5:10 PM

@greg, is this still actively waiting to be done or should we move this up to TODO?

Jdforrester-WMF edited projects, added Release-Engineering-Team-TODO (201911); removed Release-Engineering-Team-TODO (201910).Nov 6 2019, 4:24 PM

Jdforrester-WMF edited projects, added Release-Engineering-Team-TODO (201912); removed Release-Engineering-Team-TODO (201911).Dec 2 2019, 7:31 PM

In T195244#4413456, @bd808 wrote:

Flipping this redirect around the other direction would be a start -- https://www.mediawiki.org/w/index.php?title=Writing_an_extension_for_deployment&redirect=no

I knew what I was looking for on mediawiki.org and it still took me 4 searches to land on [[Review_queue]].

Done.

In T195244#5713614, @Mholloway wrote:

In T195244#4413456, @bd808 wrote:

Flipping this redirect around the other direction would be a start -- https://www.mediawiki.org/w/index.php?title=Writing_an_extension_for_deployment&redirect=no

I knew what I was looking for on mediawiki.org and it still took me 4 searches to land on [[Review_queue]].

Done.