Page MenuHomePhabricator

'Potential Issues' flagged in Page Curation Toolbar Page Info flyout
Open, NormalPublicFeature


Current behavior:

The Page Curation tool flags Potential issues in the Page info tab of the page curation toolbar.
These include: Blocked user, Orphan, No categories, No citations etc. There is also a red number on the tab icon indicating the number of potential issues.

Desired behavior:

  • In addition to the existing potential issues, include the "new" potential issues that were added by the Growth team to the feed. These include Spam, Vandalism, Attack and Copyvio. These are currently available in the NPP feed but are not displayed in the curation toolbar. You can see them here flagged under the "Review" buttons:


Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 24 2018, 1:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Insertcleverphrasehere updated the task description. (Show Details)

Change 492474 had a related patch set uploaded (by FR30799386; owner: FR30799386):
[mediawiki/extensions/PageTriage@master] Unbreaking old functionality of Potential issues flyout

The "Possible issues" functionality is already present in the code but is broken. It was possibly broken by a dev in this commit. It already has support for the 'Blocked user', 'Orphaned', 'No categories' and 'No references' flags. I have submitted a patch which should fix this feature.

Force_Radical added a comment.EditedFeb 26 2019, 3:29 PM

@Niharika would it be possible to get a code review of the patch ? It would be great if this interim fix could be deployed in the next MediaWiki release. Pinging @Insertcleverphrasehere in case they prefer a later release with all the features requested .

@Force_Radical My team doesn't intend to start working on this project for another few weeks. @MMiller_WMF Can someone from Growth do a code review on this?

MMiller_WMF added a subscriber: Catrope.

@Force_Radical -- thanks for working on this code! Yes, I can put this in the queue for Growth team engineers to look at.

@Catrope -- this is going in our code review column.

MMiller_WMF added subscribers: kostajh, SBisson.

Moving volunteer patch into code review column.

kostajh changed the subtype of this task from "Task" to "Bug Report".

I have made the changes to the patch.

Change 492474 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Unbreak potential issues flyout

@Insertcleverphrasehere @Force_Radical This change has rolled out last week. Can you confirm if it is works as expected now?

The feature appears to be working as expected yes! I have seen flags for 'Orphan', 'No categories' and 'Blocked Users' are working (the stuff that was originally intended to be implemented). And it is pulling up a red number next to the 'I' symbol related to the number of issues, which is perfect.

It still needs to add the ORES issues that are flagged in the New Pages Feed (Vandalism, Spam, Attack, Copyvio) as well as the others requested in related Phab tasks of the 'additional Tie ins' listed above, so this task should remain open, but great work so far! Thanks, @Force_Radical!

Checked in betalabs - the flag is present and the issues are listed.

To note (besides the issues with missing ORES scores by @Insertcleverphrasehere).

(1) Articles that have ORES "Potential issues: None" may still have Potential issues flagged in flyout (cause Potential issues scoring is independent). Reviewed pages will display Potential issues too.
(2) On Special:NewPagesFeed is not possible to filter e.g. just for pages that 'Are orphaned'. The returned result set will have the pages that are orphaned and orphaned pages that have other problems.

Returning for additional work to Communty-Tech.

Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 18 2019, 10:49 PM

On a side note, we did notice that the 'no references' flag doesn't look for alternate citation styles, only </ref> tags. So it will flag an article that uses an alternate citation style (such as as having 'no references'. Thought it worth reporting the bug, even if it is a relatively uncommon occurrence.

Thanks for the thorough QA, Elena! I'll pull it on the Community-Tech board when we get started on the project.

JTannerWMF moved this task from Inbox to External on the Growth-Team board.Mar 19 2019, 5:44 PM
Niharika updated the task description. (Show Details)Mar 20 2019, 4:34 PM
Niharika updated the task description. (Show Details)
Niharika triaged this task as Normal priority.
Niharika changed the subtype of this task from "Bug Report" to "Feature Request".