Page MenuHomePhabricator

Can't select across block images in Firefox
Closed, ResolvedPublic

Description

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2019, 6:03 PM

I can't even select as much as you.
When I draw a selection with the mouse past a reference or a "reference needed", the current selection collapses and starts as a new selection after the reference.
If I use the keyboard with "cursor right", the same happens.
Only if I use the keyboard with "cursor down", I have a chance to select something including references.

JTannerWMF moved this task from To Triage to Q4 on the VisualEditor board.Feb 12 2019, 4:41 PM
Esanders moved this task from Q4 to Up next on the VisualEditor board.Feb 20 2019, 6:59 PM
Esanders added a subscriber: Esanders.EditedFeb 20 2019, 7:09 PM

This issue appears to be selecting across block images. Bisect blames this commit from 4 years ago: https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/+/201357/.

Esanders renamed this task from Can't select all the content that I want to Can't select across block images in Firefox.Feb 20 2019, 7:28 PM
Esanders added a subscriber: dchan.Feb 20 2019, 8:05 PM
JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.

Removing the following CSS seems to fix the issue, though it will probably break something else:

.ve-ce-focusableNode * {
 -moz-user-select: none;
}
Esanders added a comment.EditedFeb 25 2019, 1:27 PM

This doesn't fix it for me, testing on the core demo page "Image".

This works when selecting across a single block image, but not when selecting across a paragraph slug.

Also discovered this: T217047

It appears that the moz-user-select-none hack (T70537) causes Firefox to generate multi-range selections, which we explicitly try to avoid:
https://github.com/wikimedia/VisualEditor/blob/wmf/1.33.0-wmf.18/src/ce/ve.ce.Surface.js#L3205
Supporting these would be a nightmare, so we probably have to avoid the user-select-not hack.

Change 492698 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Remove -moz-user-select:none from hack and buttonElement

https://gerrit.wikimedia.org/r/492698

Change 492698 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove -moz-user-select:none from hack and buttonElement

https://gerrit.wikimedia.org/r/492698

Change 493507 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (226ff19e5)

https://gerrit.wikimedia.org/r/493507

Change 493507 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (226ff19e5)

https://gerrit.wikimedia.org/r/493507

Cirdan added a subscriber: Cirdan.Mar 3 2019, 10:00 AM
Trizek-WMF added a project: User-notice.
Trizek-WMF added subscribers: Trizek-WMF, Ifygal3.

Adding user notice, since it has affected most FF users using VE.

Suggestion of text:

It was not possible for Firefox users using the visual editor to select text across footnotes, templates or block images. This is now fixed.

ppelberg closed this task as Resolved.Apr 1 2019, 11:18 PM