Render property names the same way in PHP & JS
Closed, ResolvedPublic
Actions

Description

JS currently used i18n messages for the property names (in dropdown and in read mode), whereas PHP renders the actual property's formatted text.
JS should probably do the same thing, and use formatValue() (and then get rid of those i18n messages), it's just a little "annoying" that formatValue is a slow API call...
Maybe we should fetch all supported property names in PHP & output the formatted text somewhere for JS to pick it up? IDK :)

Details

	Subject	Repo	Branch	Lines +/-
	Render property names the same way in PHP & JS	mediawiki/extensions/WikibaseMediaInfo	master	+231 -196

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Resolved		• Ramsey-WMF	T199352 Deploy Structured Data on Commons with arbitrary Statements
Resolved		Cparle	T204264 "Depicts crawling": Add displaying/editing statements to File page
Resolved		matthiasmullie	T215958 Render property names the same way in PHP & JS

Event Timeline

matthiasmullie triaged this task as High priority.Feb 12 2019, 7:56 PM

matthiasmullie created this task.

MarkTraceur edited projects, added Structured Data Engineering (Depicts-Crawling); removed Structured Data Engineering.Feb 19 2019, 8:25 PM

matthiasmullie claimed this task.Feb 20 2019, 4:23 PM

Change 492004 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Render property names the same way in PHP & JS

https://gerrit.wikimedia.org/r/492004

gerritbot added a project: Patch-For-Review.Feb 21 2019, 5:17 PM

matthiasmullie mentioned this in rEWBI17add653c382: Render property names the same way in PHP & JS.Feb 21 2019, 5:21 PM

matthiasmullie mentioned this in rEWBI8f22cf778770: Render property names the same way in PHP & JS.Feb 21 2019, 5:48 PM

matthiasmullie mentioned this in rEWBI75b9354b5f3a: Render property names the same way in PHP & JS.Feb 21 2019, 5:51 PM

matthiasmullie mentioned this in rEWBI6c317ec0af07: Render property names the same way in PHP & JS.Feb 22 2019, 8:40 AM

matthiasmullie moved this task from To Do to Doing on the Structured Data Engineering (Depicts-Crawling) board.Feb 22 2019, 8:46 AM

matthiasmullie mentioned this in rEWBI64ad5d419634: Render property names the same way in PHP & JS.Feb 25 2019, 11:53 AM

matthiasmullie mentioned this in rEWBI2c88636807ef: Render property names the same way in PHP & JS.

matthiasmullie mentioned this in rEWBI81456cf701f0: Render property names the same way in PHP & JS.Feb 25 2019, 12:40 PM

matthiasmullie mentioned this in rEWBId697d6a781d9: Render property names the same way in PHP & JS.Feb 25 2019, 12:48 PM

matthiasmullie mentioned this in rEWBI691e3977b6af: Render property names the same way in PHP & JS.Feb 26 2019, 9:50 AM