Page MenuHomePhabricator

Render property names the same way in PHP & JS
Closed, ResolvedPublic

Description

JS currently used i18n messages for the property names (in dropdown and in read mode), whereas PHP renders the actual property's formatted text.
JS should probably do the same thing, and use formatValue() (and then get rid of those i18n messages), it's just a little "annoying" that formatValue is a slow API call...
Maybe we should fetch all supported property names in PHP & output the formatted text somewhere for JS to pick it up? IDK :)

Related Objects

Event Timeline

matthiasmullie triaged this task as High priority.

Change 492004 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Render property names the same way in PHP & JS

https://gerrit.wikimedia.org/r/492004

Change 492004 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Render property names the same way in PHP & JS

https://gerrit.wikimedia.org/r/492004

Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Mar 8 2019, 4:50 PM
matthiasmullie closed this task as Resolved.Apr 24 2019, 4:06 PM

Works in production