VE shuffles the order of template parameters in template dialog
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dvorapa
	Feb 22 2019, 10:53 AM

Description

Steps to reproduce

Open any page on cswiki
Open template dialog to add Citace monografie template, well documented template in TemplateData
Notice author name and surname (jméno, příjmení) are not the first two parameters in that dialog

Expected behavior
The order of parameters in template dialog should not be alphabetical, but it should be the one specified in TemplateData and also used in the wikicode finally.

Current behavior
The order of the parameters in template dialog is alphabetical and not the one specified in TemplateData. Into the wikicode the correct order from TemplateData is used, which is correct.

Reported
many complaints on cswiki Facebook and tech village pump this week

Details

	Subject	Repo	Branch	Lines +/-
	ve.dm.MWTemplateModel: Preserve parameter ordering when no paramOrder exists	mediawiki/extensions/VisualEditor	master	+68 -27

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	WMDE-Fisch	T306967 Deploy VE template dialog improvements to enwiki
Resolved	Lena_WMDE	T296759 Deploy VE template dialog improvements to more wikis
Resolved	Lena_WMDE	T286992 Deploy VE template dialog improvements to small set of wikis
Resolved	WMDE-Fisch	T272487 New input for undocumented parameters
Resolved	WMDE-Fisch	T272482 Show/hide advanced toolbar when multi-part content is present
Resolved	ECohen_WMDE	T272368 Add checkboxes to param list sidebar in VE TemplateDialog
Resolved	None	T274548 VisualEditor template "required" parameter handling
Invalid	None	T274549 Handle "no parameter" templates
Resolved	thiemowmde	T274551 "deprecated" parameter handling
Resolved	Andrew-WMDE	T275761 Remove the trash icons which show next to the parameter name when it's "in focus"
Resolved	None	T274547 Handle checkbox clicks in VisualEditor template dialog sidebar
Resolved	None	T272481 Add parameter search to sidebar of VE TemplateDialog
Resolved	thiemowmde	T274544 Support multiple transclusions (i.e. templates) in the new template dialog sidebar
Resolved	Andrew-WMDE	T274550 Handle undocumented template parameters
Resolved	WMDE-Fisch	T274545 Wire template parameters into the checkbox list view
Resolved	awight	T216808 VE shuffles the order of template parameters in template dialog
Resolved	ECohen_WMDE	T285869 Add error handling for the undocumented parameter input
Invalid	None	T291059 [DRAFT] Adjust messages for special alias edge cases

Event Timeline

Dvorapa created this task.Feb 22 2019, 10:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2019, 10:53 AM

Dvorapa updated the task description. (Show Details)Feb 22 2019, 10:53 AM

Dvorapa updated the task description. (Show Details)

Dvorapa updated the task description. (Show Details)Feb 22 2019, 11:00 AM

Dvorapa updated the task description. (Show Details)

We will investigate.

Dvorapa updated the task description. (Show Details)Feb 26 2019, 7:50 PM

Dvorapa updated the task description. (Show Details)

Utar subscribed.Sep 1 2019, 8:57 PM

Stryn subscribed.Oct 21 2019, 7:17 AM

TK-999 subscribed.Mar 25 2021, 7:03 PM

Change 674970 had a related patch set uploaded (by TK-999; author: TK-999):
[mediawiki/extensions/VisualEditor@master] ve.dm.MWTemplateModel: Preserve parameter ordering when no paramOrder exists

https://gerrit.wikimedia.org/r/674970

gerritbot added a project: Patch-For-Review.Mar 25 2021, 9:15 PM

TK-999 added a project: VisualEditor-MediaWiki-Templates.Apr 22 2021, 12:11 PM

awight added subscribers: Lena_WMDE, ECohen_WMDE.Jun 24 2021, 2:08 PM

Winston_Sung subscribed.Aug 16 2021, 11:37 AM

Change 674970 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] ve.dm.MWTemplateModel: Preserve parameter ordering when no paramOrder exists

Reason:

This happens since If831578.

https://gerrit.wikimedia.org/r/674970