Handle new Vega 3.0+ graphs. Note that Vega 3.0+ should be loadable in parallel with Vega 2.0, thus it should be possible to have both versions at the same time.
P.S. Now I'm developing with Vega 4.3 because Vega 5 uses async methods in its code and that may lead to incompatible.
@Xiaoyanghaitao if you want to target Vega 5.4.0 initially, you might as well put that version in the subject (or you could just say "latest production version")
Change 509613 had a related patch set uploaded (by Xiaoyanghaitao; owner: Xiaoyanghaitao):
[mediawiki/extensions/Graph@master] 1. add Vega5 min js to lib/ 2. copy the graph2.js to initialize a graph3.js 3. modify extension.json and package.json 4. ParserTag.php: change version related sections to deal with Vega3+ and VegaLite
Vega is already 5.4.0, isn't it?
Besides, graph are no longer working in wikipedias ...
If there is some bug somewhere, then please follow https://www.mediawiki.org/wiki/How_to_report_a_bug and provide clear steps to reproduce in a separate task. Thanks.
Hello, so are Mediawikis Graph still on Vega 2.0 syntax ? Pinging {{user|Shirayuki}} ;)
@Bouzinac: This task is still open, so: yes. (Plus local MediaWiki template syntax won't work in Phab.)
As of May 2019, the glue repo has been updated to support Vega 3 and 4: https://github.com/nyurik/mw-graph-shared/pull/2
Several additional steps are mentioned in the PR discussion:
Well done!!! Thank you for following through on all the changes! Next steps:
update mediawiki to use the new version (wrapper v1 only)
update graphoid service to use the new version (wrapper v1 only)
add wrapper v2 support to graphoid
add wrapper v2 support to mediawiki
Change 755823 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/Graph@master] Update to mw-graph-shared 5.0.0
Change 509613 had a related patch set uploaded (by Aklapper; author: Xiaoyanghaitao):
[mediawiki/extensions/Graph@master] Add Vega 5 support to MediaWiki
Change 755823 abandoned by TheDJ:
[mediawiki/extensions/Graph@master] Update to mw-graph-shared 5.0.0
Reason:
I have tried to add the graph to calculate Pi using the Montecarlo method to https://eu.wikipedia.org/wiki/Txantiloi:Graph:Pi_Montecarlo. But it doesn't seem to work because the last version of Vega is not deployed.
I understand correctly that this task is not subtask and it is a duplicate of T165118? :)
I renamed the task because it seems completely counter-intuitive to downgrade to an older version that was last updated a few years ago.
Change 909761 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/extensions/Graph@master] Add Vega5 with Vega 2 to 5 compatibility layer
Do we need to create security review task for Vega5 lib? This task is in the plan T165118, I want to understand whether to delete it or not.
Change 910585 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/extensions/PageViewInfo@master] Use new graph API
Change 909761 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Add Vega5 with Vega 2 to 5 compatibility layer with tests
Change 509613 abandoned by Jdlrobson:
[mediawiki/extensions/Graph@master] Add Vega 5 support to MediaWiki
Reason:
This is now partially done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Graph/+/909761. Thanks for the patch Xiaoyanghaitao - it was a helpful reference!
Change 910585 merged by jenkins-bot:
[mediawiki/extensions/PageViewInfo@master] Use new graph API
I'm going to call this resolved, but deployment of this is dependent on the security review (subscribe to T335051 for updates)
Graphs written in Vega 2 should continue to work thanks to a compatibility layer.
The work to help the community migrate existing graphs will be tracked in T335048.
The work to update Vega to the very latest build will be tracked in T335068.
Please see T165118 for an overview.