"PHP Warning: A non-numeric value encountered" from NamespaceInfo.php via SpecialRecentChanges.php - NamespaceInfo::isTalk called with non-integer (string) namespace '-1'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Wiki: ltwiki
User impact: unknown
Frequency: 15000+
Origin: Logstash

[XsM77wpAAEUAAJ0oZ-sAAACB] /w/index.php?invert=1&associated=1&tagfilter=1&title=Specialus%3ANaujausi%20keitimai&namespace=arachni_name   ErrorException from line 175 of /srv/mediawiki/php-1.35.0-wmf.31/includes/title/NamespaceInfo.php: PHP Warning: A non-numeric value encountered
#0 /srv/mediawiki/php-1.35.0-wmf.31/includes/title/NamespaceInfo.php(175): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.31/includes/title/NamespaceInfo.php(269): NamespaceInfo->getTalk(string)
#2 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/ChangesListSpecialPage.php(1538): NamespaceInfo->getAssociated(string)
#3 [internal function]: ChangesListSpecialPage->{closure}(string)
#4 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/ChangesListSpecialPage.php(1544): array_map(Closure, array)
#5 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/ChangesListSpecialPage.php(1022): ChangesListSpecialPage->buildQuery(array, array, array, array, array, FormOptions)
#6 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/ChangesListSpecialPage.php(629): ChangesListSpecialPage->getRows()
#7 /srv/mediawiki/php-1.35.0-wmf.31/includes/specials/SpecialRecentChanges.php(164): ChangesListSpecialPage->execute(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/SpecialPage.php(576): SpecialRecentChanges->execute(NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/SpecialPageFactory.php(618): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(973): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(535): MediaWiki->main()
#13 /srv/mediawiki/php-1.35.0-wmf.31/index.php(47): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Details

Request ID: 571489e6-9647-4fb9-a3c1-a5d53d6ea40b

Stack Trace

#0 /srv/mediawiki/php-1.35.0-wmf.36/includes/title/NamespaceInfo.php(189): NamespaceInfo->makeValidNamespace(string, string)
#1 /srv/mediawiki/php-1.35.0-wmf.36/includes/changes/ChangesList.php(246): NamespaceInfo->isTalk(string)
#2 /srv/mediawiki/php-1.35.0-wmf.36/includes/changes/ChangesList.php(224): ChangesList->getHTMLClassesForFilters(RecentChange)
#3 /srv/mediawiki/php-1.35.0-wmf.36/includes/changes/OldChangesList.php(37): ChangesList->getHTMLClasses(RecentChange, boolean)
#4 /srv/mediawiki/php-1.35.0-wmf.36/includes/specials/SpecialRecentChanges.php(440): OldChangesList->recentChangesLine(RecentChange, boolean, integer)
#5 /srv/mediawiki/php-1.35.0-wmf.36/includes/specialpage/ChangesListSpecialPage.php(1659): SpecialRecentChanges->outputChangesList(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#6 /srv/mediawiki/php-1.35.0-wmf.36/includes/specialpage/ChangesListSpecialPage.php(671): ChangesListSpecialPage->webOutput(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#7 /srv/mediawiki/php-1.35.0-wmf.36/includes/specials/SpecialRecentChanges.php(164): ChangesListSpecialPage->execute(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.36/includes/specialpage/SpecialPage.php(580): SpecialRecentChanges->execute(NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.36/includes/specialpage/SpecialPageFactory.php(634): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.35.0-wmf.36/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.35.0-wmf.36/includes/MediaWiki.php(986): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.35.0-wmf.36/includes/MediaWiki.php(543): MediaWiki->main()
#13 /srv/mediawiki/php-1.35.0-wmf.36/index.php(47): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Subject	Repo	Branch	Lines +/-
Filter invalid namespace on Special:RecentChanges and friend	mediawiki/core	master	+70 -30
NamespaceInfo::makeValidNamespace: Don't throw for -1 or -2	mediawiki/core	wmf/1.35.0-wmf.36	+7 -1
NamespaceInfo::makeValidNamespace: Don't throw for -1 or -2	mediawiki/core	master	+7 -1
NamespaceInfo: Throw specifically if called on a non-int/non-int-like namespace	mediawiki/core	master	+25 -0

Customize query in gerrit

Related Objects

Mentioned In: T255088: Internal error on Special:RecentChanges: "NamespaceInfo::isTalk called with non-integer (string) namespace '-1'"
T255016: NamespaceInfo::isTalk called with non-integer (string) namespace '-1'
Mentioned Here: T254173: 1.35.0-wmf.36 deployment blockers
T255016: NamespaceInfo::isTalk called with non-integer (string) namespace '-1'
T252077: WikimediaPrometheusQueryServiceLagProvider: PHP Warning: A non-numeric value encountered

Event Timeline

KartikMistry created this task.May 19 2020, 8:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2020, 8:01 AM

OK. Seems duplicate of: T252077.

Nikerabbit updated the task description. (Show Details)May 19 2020, 8:10 AM

Nikerabbit edited projects, added Wikimedia-production-error, MediaWiki-Recent-changes; removed ContentTranslation.May 19 2020, 8:17 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 19 2020, 8:17 AM

In T253098#6147574, @KartikMistry wrote:

OK. Seems duplicate of: T252077.

The PHP warning for "A non-numeric value encountered" just means that some code somewhere used a number value incorrectly. Similar to general errors like "Variable undefined" or "Class undefined" these are not usually the same issue.

Do we think that the root cause for these two happens to be the same?

Change 598117 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] NamespaceInfo: Throw specifically if called on a non-int namespace

https://gerrit.wikimedia.org/r/598117

gerritbot added a project: Patch-For-Review.May 22 2020, 9:18 PM

thcipriani moved this task from Untriaged to May 2020 on the Wikimedia-production-error board.May 27 2020, 6:47 PM

Krinkle renamed this task from Logspam: ErrorException from line 175 of /srv/mediawiki/php-1.35.0-wmf.31/includes/title/NamespaceInfo.php: PHP Warning: A non-numeric value encountered to "PHP Warning: A non-numeric value encountered" from NamespaceInfo.php via SpecialRecentChanges.php.May 27 2020, 7:12 PM

Change 598117 merged by jenkins-bot:
[mediawiki/core@master] NamespaceInfo: Throw specifically if called on a non-int/non-int-like namespace

https://gerrit.wikimedia.org/r/598117

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 8 2020, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2020, 11:10 PM

OK, now with the better error we can see the trigger:

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.36/includes/title/NamespaceInfo.php(189): NamespaceInfo->makeValidNamespace(string, string)
#1 /srv/mediawiki/php-1.35.0-wmf.36/includes/changes/ChangesList.php(246): NamespaceInfo->isTalk(string)
#2 /srv/mediawiki/php-1.35.0-wmf.36/includes/changes/ChangesList.php(224): ChangesList->getHTMLClassesForFilters(RecentChange)
#3 /srv/mediawiki/php-1.35.0-wmf.36/includes/changes/OldChangesList.php(37): ChangesList->getHTMLClasses(RecentChange, boolean)
#4 /srv/mediawiki/php-1.35.0-wmf.36/includes/specials/SpecialRecentChanges.php(440): OldChangesList->recentChangesLine(RecentChange, boolean, integer)
#5 /srv/mediawiki/php-1.35.0-wmf.36/includes/specialpage/ChangesListSpecialPage.php(1659): SpecialRecentChanges->outputChangesList(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#6 /srv/mediawiki/php-1.35.0-wmf.36/includes/specialpage/ChangesListSpecialPage.php(671): ChangesListSpecialPage->webOutput(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#7 /srv/mediawiki/php-1.35.0-wmf.36/includes/specials/SpecialRecentChanges.php(164): ChangesListSpecialPage->execute(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.36/includes/specialpage/SpecialPage.php(580): SpecialRecentChanges->execute(NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.36/includes/specialpage/SpecialPageFactory.php(634): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.35.0-wmf.36/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.35.0-wmf.36/includes/MediaWiki.php(986): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.35.0-wmf.36/includes/MediaWiki.php(543): MediaWiki->main()
#13 /srv/mediawiki/php-1.35.0-wmf.36/index.php(47): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Change 604386 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] NamespaceInfo::makeValidNamespace: Don't throw for -1 or -2

https://gerrit.wikimedia.org/r/604386

gerritbot added a project: Patch-For-Review.Jun 10 2020, 1:35 PM

Is this not a train blocker? RC isn't showing on metawiki and enwikiquote.

Indeed, T255016#6211050 implies to me that this should block the train. Someone feel free to correct me.

Aklapper added a parent task: T254173: 1.35.0-wmf.36 deployment blockers.Jun 10 2020, 4:01 PM

taavi subscribed.Jun 10 2020, 4:02 PM

Agusbou2015 subscribed.Jun 10 2020, 4:08 PM

@Aklapper Reverting largely per T254173#6210902 and -operations when this was initially found

taavi removed a parent task: T254173: 1.35.0-wmf.36 deployment blockers.Jun 10 2020, 4:08 PM

DannyS712 mentioned this in T255088: Internal error on Special:RecentChanges: "NamespaceInfo::isTalk called with non-integer (string) namespace '-1'".Jun 11 2020, 1:20 AM

Aklapper renamed this task from "PHP Warning: A non-numeric value encountered" from NamespaceInfo.php via SpecialRecentChanges.php to "PHP Warning: A non-numeric value encountered" from NamespaceInfo.php via SpecialRecentChanges.php - NamespaceInfo::isTalk called with non-integer (string) namespace '-1'.Jun 11 2020, 5:32 AM

Aklapper merged a task: T255088: Internal error on Special:RecentChanges: "NamespaceInfo::isTalk called with non-integer (string) namespace '-1'".

Aklapper changed the subtype of this task from "Task" to "Production Error".

Aklapper set Request ID to 571489e6-9647-4fb9-a3c1-a5d53d6ea40b.

Aklapper edited Stack Trace. (Show Details)

Aklapper set Phatality ID to 48403fa39ebf2183465d8f3c4e840632ce3034759c6fd21c6eae0cff58586961.

Aklapper added subscribers: DannyS712, CptViraj, Shizhao.

Base subscribed.Jun 11 2020, 6:35 AM

taavi merged a task: T255099: :m:Special:RecentChanges "Interner Fehler".Jun 11 2020, 6:45 AM

taavi added a subscriber: WikiBayer.

DannyS712 added a parent task: T254173: 1.35.0-wmf.36 deployment blockers.Jun 11 2020, 6:50 AM

Is this the cause for Recent Changes on nl.wiktionary showing just the message "Internal Error" (Interne fout)? This is blocking the patroling against spam and vandals, so it is an urgent problem.

In T253098#6213805, @MarcoSwart wrote:

Is this the cause for Recent Changes on nl.wiktionary showing just the message "Internal Error" (Interne fout)? This is blocking the patroling against spam and vandals, so it is an urgent problem.

Yes, this is the cause

In T253098#6213805, @MarcoSwart wrote:

Is this the cause for Recent Changes on nl.wiktionary showing just the message "Internal Error" (Interne fout)?

Hmm, yes, somehow the default view is invalid there due to a bad log entry; please use https://nl.wiktionary.org/w/index.php?hidebots=1&hidecategorization=1&hideWikibase=1&hidelog=1&limit=50&days=7&title=Speciaal:RecenteWijzigingen&urlversion=2 for now.

In T253098#6211056, @RhinosF1 wrote:

Is this not a train blocker? RC isn't showing on metawiki and enwikiquote.

And even when logged out at https://meta.wikimedia.org/wiki/Special:RecentChanges , so this is definitely "Unbreak now" material.

In T253098#6213881, @Nemo_bis wrote:

In T253098#6211056, @RhinosF1 wrote:

Is this not a train blocker? RC isn't showing on metawiki and enwikiquote.

And even when logged out at https://meta.wikimedia.org/wiki/Special:RecentChanges , so this is definitely "Unbreak now" material.

Raising to UBN. (for context, yesterday it only affected users with saved watchlist settings)

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 11 2020, 7:53 AM

In T253098#6213881, @Nemo_bis wrote:

In T253098#6211056, @RhinosF1 wrote:

Is this not a train blocker? RC isn't showing on metawiki and enwikiquote.

And even when logged out at https://meta.wikimedia.org/wiki/Special:RecentChanges , so this is definitely "Unbreak now" material.

Can reproduce logged out now

taavi merged a task: T255103: We cannot open the Page with MSG "Internal error".Jun 11 2020, 8:40 AM

taavi added a subscriber: Mtodo.

ABLouis subscribed.Jun 11 2020, 9:11 AM

MarcoAurelio subscribed.Jun 11 2020, 11:13 AM

Change 604386 merged by jenkins-bot:
[mediawiki/core@master] NamespaceInfo::makeValidNamespace: Don't throw for -1 or -2

https://gerrit.wikimedia.org/r/604386

Change 604675 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@wmf/1.35.0-wmf.36] NamespaceInfo::makeValidNamespace: Don't throw for -1 or -2

https://gerrit.wikimedia.org/r/604675

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 11 2020, 12:00 PM

Change 604675 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.36] NamespaceInfo::makeValidNamespace: Don't throw for -1 or -2

https://gerrit.wikimedia.org/r/604675

Mentioned in SAL (#wikimedia-operations) [2020-06-11T12:04:20Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.36/includes/title/NamespaceInfo.php: T253098 NamespaceInfo::makeValidNamespace: Don't throw for -1 or -2 (duration: 01m 06s)

Deeming this diversion into a UBN resolved; if people get a similar error but with a value that isn't an integer wrapped in a string, which is the real bug we're chasing, let's find that and fix that within this task. :-)

Jdforrester-WMF claimed this task.Jun 11 2020, 12:07 PM

taavi removed a parent task: T254173: 1.35.0-wmf.36 deployment blockers.Jun 11 2020, 12:08 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2020, 12:11 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.36; 2020-06-09); removed MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 11 2020, 1:00 PM

Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.Jul 1 2020, 8:49 AM

Jdforrester-WMF lowered the priority of this task from Medium to Low.

Still happening in wmf.39:

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.39/includes/title/NamespaceInfo.php(196): NamespaceInfo->makeValidNamespace(string, string)
#1 /srv/mediawiki/php-1.35.0-wmf.39/includes/title/NamespaceInfo.php(186): NamespaceInfo->isTalk(string)
#2 /srv/mediawiki/php-1.35.0-wmf.39/includes/title/NamespaceInfo.php(311): NamespaceInfo->isSubject(string)
#3 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/ChangesListSpecialPage.php(1539): NamespaceInfo->getAssociated(string)
#4 [internal function]: ChangesListSpecialPage->{closure}(string)
#5 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/ChangesListSpecialPage.php(1545): array_map(Closure, array)
#6 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/ChangesListSpecialPage.php(1023): ChangesListSpecialPage->buildQuery(array, array, array, array, array, FormOptions)
#7 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/ChangesListSpecialPage.php(630): ChangesListSpecialPage->getRows()
#8 /srv/mediawiki/php-1.35.0-wmf.39/includes/specials/SpecialRecentChanges.php(165): ChangesListSpecialPage->execute(NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/SpecialPage.php(580): SpecialRecentChanges->execute(NULL)
#10 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#12 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(986): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(543): MediaWiki->main()
#14 /srv/mediawiki/php-1.35.0-wmf.39/index.php(53): MediaWiki->run()
#15 /srv/mediawiki/php-1.35.0-wmf.39/index.php(46): wfIndexMain()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/608186 would add a intval, but it does not fix the root cause

Umherirrender claimed this task.Jul 10 2020, 7:43 PM

Change 608186 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Filter invalid namespace on Special:RecentChanges and friend

https://gerrit.wikimedia.org/r/608186

gerritbot added a project: Patch-For-Review.Jul 10 2020, 7:50 PM

• LarsWirzenius unsubscribed.Jul 14 2020, 2:56 PM

Change 608186 merged by jenkins-bot:
[mediawiki/core@master] Filter invalid namespace on Special:RecentChanges and friend

https://gerrit.wikimedia.org/r/608186

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 12 2020, 5:56 AM

Umherirrender closed this task as Resolved.Aug 12 2020, 8:23 AM