Page MenuHomePhabricator

Allow filtering of errors from logged in users
Open, HighPublic

Description

Many logged in users run custom gadgets. They contribute a lot of noise to the error dashboards in Logstash.

To make this data more usable and put less burden on developers to filter out this noise and find bugs that impact the majority of our anonymous users, I request that a field isloggedin in the response to filter out errors from logged in users.

Event Timeline

ovasileva triaged this task as Medium priority.Jul 7 2020, 3:34 PM
ovasileva moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
sdkim reassigned this task from ovasileva to jlinehan.Mon, Oct 5, 3:10 PM
sdkim added a subscriber: ovasileva.

Change 632741 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[mediawiki/extensions/WikimediaEvents@master] clientError: Adds 'is_logged_in' tag to aid filtering

https://gerrit.wikimedia.org/r/632741

Change 632741 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] clientError: Adds 'is_logged_in' tag to aid filtering

https://gerrit.wikimedia.org/r/632741

I believed this code should be live now (wmf13 is deployed on commons wiki) but I'm not seeing any errors with the tag. Is a further change needed?

We seem to have lost client side error tracking because of this change, so we should fix that before rolling out wmf13 any further so we don't lose it altogether.

Change 634120 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[mediawiki/extensions/WikimediaEvents@master] clientError: Convert bool to string to allow schema validation

https://gerrit.wikimedia.org/r/634120

Change 634124 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[schemas/event/primary@master] mediawiki/client/error: Adds is_logged_in field

https://gerrit.wikimedia.org/r/634124

jlinehan added a comment.EditedWed, Oct 14, 11:51 PM

I believe this issue is due to the event being invalid due to the fact that the values of members of the tags object must be strings per the schema, but we were providing a boolean value for is_logged_in. Being mindful of https://phabricator.wikimedia.org/T217142#5295424, plus the fact that there is already a 'tags' field being used in logstash somehow, I've updated the schema to have a top-level is_logged_in field, which takes a boolean value.

Change 634120 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] clientError: Add is_logged_in field rather than tags field

https://gerrit.wikimedia.org/r/634120

Thanks for addressing the logspam; much appreciated! However, is this an actual train blocker? I.e. should I be waiting on a backport to wmf/1.36.0-wmf.13 before promoting to all wikis today? If not, please remove T263179: 1.36.0-wmf.13 deployment blockers as a parent task.

Change 634256 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikimediaEvents@wmf/1.36.0-wmf.13] Revert "clientError: Adds 'is_logged_in' tag to aid filtering"

https://gerrit.wikimedia.org/r/634256

Jdlrobson raised the priority of this task from Medium to Unbreak Now!.Thu, Oct 15, 5:08 PM

I think we should be waiting on a backport. If the train rolls out further we'll lose a key bit of infrastructure (client-side error logging). This deploy is getting a little complex and we need more time.

As a short term solution and to unblock the wmf13 deploy, let's revert it in wmf13 and then move this to a wmf14 blocker

Change 634292 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[schemas/event/primary@master] mediawiki/client/error: Adds is_user_logged_in field

https://gerrit.wikimedia.org/r/634292

Change 634124 abandoned by Jason Linehan:
[schemas/event/primary@master] mediawiki/client/error: Adds is_logged_in field

Reason:

https://gerrit.wikimedia.org/r/634124

Change 634295 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[mediawiki/extensions/WikimediaEvents@master] clientError: Adds 'is_user_logged_in' field.

https://gerrit.wikimedia.org/r/634295

I think we should be waiting on a backport. If the train rolls out further we'll lose a key bit of infrastructure (client-side error logging). This deploy is getting a little complex and we need more time.

As a short term solution and to unblock the wmf13 deploy, let's revert it in wmf13 and then move this to a wmf14 blocker

Thanks for clarifying that. I'll make sure the backport is merged/synced before going to all wikis.

Change 634256 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.36.0-wmf.13] Revert "clientError: Adds 'is_logged_in' tag to aid filtering"

https://gerrit.wikimedia.org/r/634256

Jdlrobson lowered the priority of this task from Unbreak Now! to High.Thu, Oct 15, 7:01 PM
Jdlrobson removed a subscriber: Jdlrobson.

Mentioned in SAL (#wikimedia-operations) [2020-10-15T19:07:16Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.13/extensions/WikimediaEvents/: Revert "clientError: Adds is_logged_in tag to aid filtering" (T256173) (duration: 01m 58s)