Page MenuHomePhabricator

Encourage review of recently translated articles
Closed, ResolvedPublic

Assigned To
Authored By
Pginer-WMF
Jul 23 2021, 9:32 AM

Description

Translation is useful to create an initial version of an article, but it often requires further review. This ticket proposes to show a notice on recently translated articles that invites users to review and expand with the translation of a new section.

Notice for recently translated articlesDialog with instructions to reviewSecondary tab of the dialog to expand
review-page.png (851×375 px, 133 KB)
review-edit.png (851×375 px, 107 KB)
review-add.png (851×375 px, 79 KB)

As an initial exploration of this entry point, it will be exposed only on mobile and for logged-in users. Based on the results we can explore how to expand it to desktop (keeping an eye on whether expanding articles is available there by then: T234323). Check the "Details on Logic" below for more considerations about when to show this notice.

Design details

Notice

The notice uses the same placement and similar style as article issues.

  • The title of the notice is set in bold and uses Accent50 (#36c) color. The description text uses Base20 (#54595D) color. Both using a font size of 14px.
  • Article icon is used in Accent50 (#36c)
  • Taping the notice will open the instructions dialog.
  • Layout and spacing is detailed below:

review-page-layout.png (415×551 px, 47 KB)

Messages:

This page was recently translated
Help to improve the contents

Instructions dialog
The instructions dialog is modal, using a translucent overlay to darken the elements behind. Standard components for the overlay, dialog, and tab control should be reused.

The tab control will be only shown if there are sections available to translate. If there are not, the tab control will be hidden and only the instructions to review the contents will be provided.

More details on the content and actions below:

Improve the translation
Review contents | Add new sections

(Review contents tab:)

Translations reuse work by editors from other languages. However, some aspects can get lost in translation. You can help:

  1. Make the content read natural
Edit sentences to reorder or replace words as needed.
  2. Check the references
Readers access references to check the facts. Review the format of references and add relevant references in your language.
  3. Compare with the original
Make sure the original meaning was not been altered in the translation.

[Edit the page]
[Open original page in <source-language>]

  • "Edit the page" opens visual editor.
  • "Open original page in <source-language>" opens the source article in a new tab.

( "Add new sections" tab, only if sections are available to expand:)

Expand this page by translating sections available in other languages you know.
[Translate a new section]
Translate <section1>, <section2>, and more

  • "Translate a new section" links to Section translation with the article and language pair pre-selected.
  • "Translate <section1>, <section2>, and more" shows up to two of the available sections that can be expanded. The message will be adapted in the cases where there is only one (""Translate <section1>") or two sections (" "Translate <section1> and <section2>") available to expand.

Details on the logic

The notice will be shown if all the conditions below are met:

  • User is accessing the mobile web version of the article.
  • There are no other notices for the article. Article issues are represented in the same place and in a similar way. We may want to give preference to the article issues since they are defined after editor assessment.
  • User is logged-in
  • The article was published as a new page by Content or Section Translation.
    • Support for articles created with Section Translation will be covered in a separate ticket (T302061) since it requires their translations to be persisted (T270499)
  • The article was published in the last 10 days.
  • The article has less than 5 edits since it was published.
  • The page is not a redirect.

In addition, the tab control will be only shown if there are sections available to translate. If there are not, the tab control will be hidden and only the instructions to review the contents will be provided.

Event Timeline

Note that this will require a new event_source value in the content_translation_event schema (T287403).

Pginer-WMF raised the priority of this task from Medium to High.Sep 6 2021, 9:26 PM

Change 732671 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Add entrypoint for reviewing recently translated pages

https://gerrit.wikimedia.org/r/732671

Change 734222 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Add UI for entrypoint for reviewing recently translated pages

https://gerrit.wikimedia.org/r/734222

Change 732671 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add entrypoint for reviewing recently translated pages

https://gerrit.wikimedia.org/r/732671

Change 734222 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add UI for entrypoint for reviewing recently translated pages

https://gerrit.wikimedia.org/r/734222

Change 737354 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211108

https://gerrit.wikimedia.org/r/737354

Change 737354 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211108

https://gerrit.wikimedia.org/r/737354

For this entry point, has the instrumentation part be considered as part of the current work or is it preferred to create a separate ticket (to implement or discuss details about it)?

Thanks for the work on this, @ngkountas. It is already taking a good shape, but some adjustments may still be needed.

Invite not visible for articles created with Section Translation

The invite is visible on articles created with Content Translation but not on those created with Section Translation. Some examples:

Recent article created with Content Translation on Thai Wikipedia:

th.m.wikipedia.org_wiki_%E0%B8%9B%E0%B8%A3%E0%B8%B1%E0%B8%8A%E0%B8%8D%E0%B8%B2%E0%B8%99%E0%B8%B4%E0%B9%80%E0%B8%A7%E0%B8%A8%E0%B8%A7%E0%B8%B4%E0%B8%97%E0%B8%A2%E0%B8%B2(iPhone 12 Pro).png (2×1 px, 1 MB)
th.m.wikipedia.org_wiki_%E0%B8%9B%E0%B8%A3%E0%B8%B1%E0%B8%8A%E0%B8%8D%E0%B8%B2%E0%B8%99%E0%B8%B4%E0%B9%80%E0%B8%A7%E0%B8%A8%E0%B8%A7%E0%B8%B4%E0%B8%97%E0%B8%A2%E0%B8%B2(iPhone 12 Pro) (1).png (2×1 px, 555 KB)
th.m.wikipedia.org_wiki_%E0%B8%9B%E0%B8%A3%E0%B8%B1%E0%B8%8A%E0%B8%8D%E0%B8%B2%E0%B8%99%E0%B8%B4%E0%B9%80%E0%B8%A7%E0%B8%A8%E0%B8%A7%E0%B8%B4%E0%B8%97%E0%B8%A2%E0%B8%B2(iPhone 12 Pro) (3).png (2×1 px, 442 KB)

A recent article on Hausa Wikipedia is not showing the invite:

ha.m.wikipedia.org_wiki_Vidi_Bilu(iPhone 12 Pro).png (2×1 px, 233 KB)

Wrong target page when expanding with new sections

Using the previous article from Thai Wikipedia the option to translate a new section leads to this view where the Thai article is selected as source and shows no sections to translate.
The expected behaviour would be to reach this view instead where the English article as source and sections are available to translate. Both views shown side-by-side below for more clarity:

CurrentExpected
th.m.wikipedia.org_wiki_Special_ContentTranslation_from=en&to=th&campaign=mfrecenttranslation&sx=true&page=%E0%B8%9B%E0%B8%A3%E0%B8%B1%E0%B8%8A%E0%B8%8D%E0%B8%B2%E0%B8%99%E0%B8%B4%E0%B9%80%E0%B8%A7%E0%B8%A8%E0%B8%A7%E0%B8%B4%E0%B8%97%E0 (1).png (1×828 px, 97 KB)
th.m.wikipedia.org_wiki_%E0%B8%9E%E0%B8%B4%E0%B9%80%E0%B8%A8%E0%B8%A9_ContentTranslation(iPhone XR).png (1×828 px, 755 KB)

In addition, accessing the invite to translate sections makes it impossible for the user to return to the article by using the browser back button. The user is trapped into a redirect loop:

Additional questions

Some additional questions to help inform next steps:

  • Since replicating the scenarios requires some steps to find the right article meeting the conditions, can this component be reviewed in Storybook? That would make it easier to review visual aspects and identify future regressions if any
  • Is this entry point instrumented, or a separate task is needed for it?
Pginer-WMF changed the task status from Open to In Progress.Jan 21 2022, 11:41 AM

Change 757637 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX recent translation entrypoint: Fix redirection to SX

https://gerrit.wikimedia.org/r/757637

Development is stalled until unified CX-SX tables are created/updated according to comments in https://phabricator.wikimedia.org/T270499#7648564. These tables will be used to check for articles that were recently translated using Content or Section Translation. This is currently possible only for article created using CX.

ngkountas changed the task status from In Progress to Stalled.Feb 1 2022, 1:28 AM

Development is stalled until unified CX-SX tables are created/updated according to comments in https://phabricator.wikimedia.org/T270499#7648564. These tables will be used to check for articles that were recently translated using Content or Section Translation. This is currently possible only for article created using CX.

If I'm understanding this correctly, this limitation means we can show the entry point for articles created with Content Translation, but not for articles created with Section Translation. Other than that, have the issues surfaced in T287236#7622050 been addressed?
If that is the case, we can create a separate ticket for accounting for articles created by Section Translation. If not, some work can still continue in that font.

Based on input from @ngkountas I created a separate ticket for the pending piece: T302061: Encourage review of recently translated articles with Section Translation (which is blocked on T270499). In this way, the current ticket can move forward.

So regarding the points form the previous comment (T287236#7622050):

  • Invite not visible for articles created with Section Translation. Now it is expected, and this will be supported in T302061.
  • Wrong target page when expanding with new sections. Now it works as expected.
  • accessing the invite to translate sections makes it impossible for the user to return to the article by using the browser back button. Now it is possible to return.

From the above comments, the final questions are the piece that may still need clarification to determine if more follow-up tickets are needed:

  • Since replicating the scenarios requires some steps to find the right article meeting the conditions, can this component be reviewed in Storybook? That would make it easier to review visual aspects and identify future regressions if any
  • Is this entry point instrumented, or a separate task is needed for it?
Pginer-WMF changed the task status from Stalled to In Progress.Feb 18 2022, 10:50 AM

I can confirm that the instrumentation for this entrypoint has already been implemented and the "dashboard_open" event should be logged properly with the event_source attribute set to "mfrecenttranslation" when the "Translate a new section" button is clicked inside the dialog.

Etonkovidova subscribed.

Tested on thwiki wmf.25.

(1) +1 to @Pginer-WMF question:

Since replicating the scenarios requires some steps to find the right article meeting the conditions, can this component be reviewed in Storybook? That would make it easier to review visual aspects and identify future regressions if any

It turned out that I could not find a single article that displays the warning that is not a redirect - do I miss some specs on how to find such articles with the warning? I used RecentChanges filters with ContentTranslation tag and excluded SectionTranslation tagged edits).

(2) Quite few articles with the warning are redirects, e.g.
https://th.m.wikipedia.org/w/index.php?title=เอมมี_เนอเทอร์&redirect=no

https://th.m.wikipedia.org/w/index.php?title=เพ็กกี้_วิตสัน&redirect=no

https://th.m.wikipedia.org/w/index.php?title=有声歯茎側面摩擦音&redirect=no

https://th.m.wikipedia.org/w/index.php?title=นาโอมิ_ปาร์เกอร์_ฟราเลย์&redirect=no

Screen Shot 2022-03-16 at 2.12.02 PM.png (1×724 px, 145 KB)

Those redirects will display the overlay, but Review content tab "Edit this page" would open a blank page and Add new section tab "Translate a new section would display a general Translate section.

(3) If a user follows a redirect, the article there would not present the warning.

I filed an issue with the vertical scrolling - T304018: [mobile] sx-recent-translation-dialog-container allows to scroll content behind it

It turned out that I could not find a single article that displays the warning that is not a redirect - do I miss some specs on how to find such articles with the warning? I used RecentChanges filters with ContentTranslation tag and excluded SectionTranslation tagged edits).

The method you followed makes sense, but the filtering condition that "The article has less than 5 edits since it was published." may be getting in the way. I checked recent articles on Thai Wikipedia and they seem often edited with more than 5 edits after publishing. You can try with other wikis such as Tamil, Azerbaijani or Hausa. In those it was easier to find articles that meet the conditions.

(2) Quite few articles with the warning are redirects, e.g.

This was intended to show only on "content" articles, not redirects.
I'll add an additional condition to exclude them. Thanks for catching this!

(2) Quite few articles with the warning are redirects, e.g.
...

Those redirects will display the overlay, but Review content tab "Edit this page" would open a blank page and Add new section tab "Translate a new section would display a general Translate section.

(3) If a user follows a redirect, the article there would not present the warning.

Regarding redirects, I created a follow-up ticket to prevent showing the invite in such case: T305129: Avoid entry point for the review of recently translated articles to be shown on redirects
Trying to show the invite on the redirected page seems too complicated and error-prone. If someone decided to move the article we can consider that a major act of review and the notice to encourage further reviewing may not be worth it.

Regarding the questions on how to test this, I provided some comments in T287236#7785031. Are those helpful to continue the QA process? Is anything else needed?

(2) Quite few articles with the warning are redirects, e.g.
...

Those redirects will display the overlay, but Review content tab "Edit this page" would open a blank page and Add new section tab "Translate a new section would display a general Translate section.

(3) If a user follows a redirect, the article there would not present the warning.

Regarding redirects, I created a follow-up ticket to prevent showing the invite in such case: T305129: Avoid entry point for the review of recently translated articles to be shown on redirects
Trying to show the invite on the redirected page seems too complicated and error-prone. If someone decided to move the article we can consider that a major act of review and the notice to encourage further reviewing may not be worth it.

Regarding the questions on how to test this, I provided some comments in T287236#7785031. Are those helpful to continue the QA process? Is anything else needed?

Thanks, @Pginer-WMF for the answers and the review!

Re-checked (the screenshots with some info) are below. Also, checked the functionality - the links, the user workflow etc. All works as expected. If there are no follow-ups on the messages or the layout of the dialogs, the scope of this task is done.

hawiki Special:NewPages with contenttranslation-v2 and sectiontranslation. Below are the screenshots from Android. Comparing with the mockup - the overlay Improve the translation covers the screen entirely (it was tested on 360 x 740 Samsung Galaxy S8). The screen underneath is scrollable (already filed as T304018)

Screenshot_20220405-113328_Chrome.jpg (2×1 px, 417 KB)
Screenshot_20220405-113355_Chrome.jpg (2×1 px, 419 KB)
Screenshot_20220405-113430_Chrome.jpg (2×1 px, 234 KB)

Change 1008417 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Recent translation entrypoint: Use codex CSS buttons and icons

https://gerrit.wikimedia.org/r/1008417

Change 1008417 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Recent translation entrypoint: Use codex CSS buttons and icons

https://gerrit.wikimedia.org/r/1008417