Page MenuHomePhabricator

Deploy config to introduce manual topic subscriptions as Beta Feature at Phase 2 projects
Closed, ResolvedPublic

Description

This task is about making manual topic subscriptions available as a beta feature at the ===Phase 2 wikis listed below

Deployment timing

This deployment is tentatively scheduled for Wednesday, 25 August during the Morning backport window that runs from 18:00 - 19:00 UTC.

⚠️ Note: the deployment date will be finalized on Tuesday, 24 August once we've confirmed wikis have not raised any concerns with the plan @Whatamidoing-WMF communicated in T288704#7298872.

Phase 2 wikis

via T286096.

Wiki code
All Wikipedias except English Wikipedia

Requirements

For people at the partner wikis above who have the Discussion tools beta feature enabled, they will see the following:

  1. In Special:Preferences#mw-prefsection-betafeatures: the Discussion tools beta feature should contain a list item that reads: Receive notifications when new comments are added in sections you have subscribed to.
  2. In Special:Preferences#mw-prefsection-editing: a new setting within the Discussion pages section that contains a setting titled Enable topic subscription and this setting should be enabled by default
  3. On a talk page with at least one ==H2==, a [ subscribe ] affordance should appear next to it

Minimum test case

At each of the wikis listed beneath Wikis to test on, complete the Test instructions.

Wikis to test on

  1. Japanese (ja.wiki)
  2. Hebrew (he.wiki)
  3. Bengali (bn.wiki)
  4. Russian (ru.wiki)
  5. Vietnamese (vi.wiki)

Test instructions

  1. Visit Special:Preferences#mw-prefsection-betafeaturesand verify the Discussion tools beta feature contains a list item that reads: Receive notifications when new comments are added in sections you have subscribed to.
  2. Visit Special:Preferences#mw-prefsection-editing and verify a new setting appears within the Discussion pages section titled Enable topic subscription and this setting should be enabled by default
  3. Visit a talk page and verify [ subscribe ] affordances appear next to each ==H2==

Done

  • All ===Requirements are met
  • All issues encountered during testing are documented

Event Timeline

Deployment timing
This deployment is tentatively scheduled for Wednesday, 25 August.

The deployment date will be finalized on Tuesday, 24 August once we've confirmed wikis have not raised any concerns with the plan @Whatamidoing-WMF communicated in T288704#7298872.

Change 714720 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable topic subscriptions as a beta feature on Wikipedias except enwiki

https://gerrit.wikimedia.org/r/714720

Note that there are a few wikis that you wouldn't think are Wikipedias, but which are treated as if they were. See my comment from last year when we did the same thing for the reply tool:

The proposed config patch uses the 'wikipedia' dblist, which has a few consequences:

  • Newly created Wikipedias will also automatically get DiscussionTools as a beta feature. It also includes a few Wikipedias that were created after the spreadsheet in the task, and which are not listed there, e.g. smnwiki.
  • A few non-Wikipedia sites are included, because they're in that dblist for some reason, e.g. arbcom_enwiki, tenwiki, wg_enwiki. They are mostly private or closed so this shouldn't affect anyone negatively. (I was actually surprised to learn about this.)

In Special:Preferences#mw-prefsection-betafeatures: the Discussion tools beta feature should contain a list item that reads: Receive notifications when new comments are added in sections you have subscribed to.

I will note that the beta description doesn't change based on enabled features, so this isn't really something to spell out / test. 😅

Change 714720 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable topic subscriptions as a beta feature on Wikipedias except enwiki

https://gerrit.wikimedia.org/r/714720

Mentioned in SAL (#wikimedia-operations) [2021-08-25T18:05:44Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 2b14eb525e99008d5103a93c5bd01f75211dca99: Enable topic subscriptions as a beta feature on Wikipedias except enwiki (T287801) (duration: 01m 06s)

@matmarex: It seems for Russian Wikipedia, the list item for "Receive Notifications" is missing under Discussion Tools section on Preferences>Beta Features page.

Also, I have already mentioned this to @ppelberg that on Ja wiki, when I use Google Translate on the Preferences>Beta Features page, the word "Receive Notifications" gets duplicated and both were hyperlinked. I know we generally ignore these cases, but mentioning it anyways : )

Screen Shot 2021-08-26 at 2.50.49 PM.png (912×1 px, 186 KB)

@matmarex: It seems for Russian Wikipedia, the list item for "Receive Notifications" is missing under Discussion Tools section on Preferences>Beta Features page.

It looks like the Russian translation hasn't been updated yet since we added that item: https://translatewiki.net/wiki/MediaWiki:Discussiontools-preference-description/ru (last edited in February)

Also, I have already mentioned this to @ppelberg that on Ja wiki, when I use Google Translate on the Preferences>Beta Features page, the word "Receive Notifications" gets duplicated and both were hyperlinked. I know we generally ignore these cases, but mentioning it anyways : )

Screen Shot 2021-08-26 at 2.50.49 PM.png (912×1 px, 186 KB)

It looks like there was a mistake in the Japanese translation, which included the words "Receive notifications" in English, and perhaps caused Google Translate to get confused. It has just been corrected yesterday: https://translatewiki.net/w/i.php?title=MediaWiki:Discussiontools-preference-description/ja&diff=10255066&oldid=10169336 and this change should reach the wiki with the deployment train next week.

@matmarex: It seems for Russian Wikipedia, the list item for "Receive Notifications" is missing under Discussion Tools section on Preferences>Beta Features page.

It looks like the Russian translation hasn't been updated yet since we added that item: https://translatewiki.net/wiki/MediaWiki:Discussiontools-preference-description/ru (last edited in February)

Per a meeting we had as a team offline, @Whatamidoing-WMF is going to look into the above. This investigation will happen in T290275.

Considering the above, I am resolving this task.