Page MenuHomePhabricator
Create Task
Maniphest T297271

Function Editor - Create an Chip component
Closed, ResolvedPublic
Actions

Description

As an user I would like to have access to a chip component that will allow me to enter multiple strings. This component is used in the function editor to define the alias

We need to make sure that the CHIP component is not already available within the existing Vue component library. Ask Geno or simone for details on the library.

  • Allow the user to enter a string
  • Allow the user to "click enter" to save the string
  • Allow the user to more strings
  • Allow the user to "delete" the string
NOTE: The component may need further development after completing to define how it looks with long individual string or a big number of strings.

Related Objects
Search...

Event Timeline

SimoneThisDot created this task.Dec 8 2021, 8:51 AM
Jdforrester-WMF added a comment.Dec 8 2021, 2:39 PM

From the designs this appears to be akin to the existing MenuTagMultiselect widget we have in OOUI.

I know that Codex doesn't have one of these yet (and beyond T277047 there's no specific task to make one), but I imagine we'd want to align to that agreed design // accessibility structure at first?

Quiddity unsubscribed.Dec 8 2021, 6:53 PM
Jdforrester-WMF removed • aishwaryavardhana as the assignee of this task.Dec 14 2021, 5:12 PM

I believe that this is not blocked on Aishwarya and is waiting for development.

Jdforrester-WMF moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Dec 14 2021, 5:12 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Dec 14 2021, 5:31 PM
RHo subscribed.Dec 15 2021, 4:11 PM
In T297271#7556400, @Jdforrester-WMF wrote:

From the designs this appears to be akin to the existing MenuTagMultiselect widget we have in OOUI.

I know that Codex doesn't have one of these yet (and beyond T277047 there's no specific task to make one), but I imagine we'd want to align to that agreed design // accessibility structure at first?

I would recommend looking at tasks for chip/tag components T280701, T147811, and T280681 to see if any of those could fit, with additional info about the particular use-case.

SimoneThisDot mentioned this in T297100: Function Editor - Create the function definition main content area.Jan 3 2022, 11:42 AM
• JKieserman changed the task status from Open to In Progress.Jan 4 2022, 3:14 PM
• JKieserman claimed this task.
• JKieserman added a comment.Jan 4 2022, 3:19 PM

Hi @RHo! From the looks of it, https://phabricator.wikimedia.org/T280701 would work for us. It doesn't look the interactivity is defined on the ticket yet but @aishwaryavardhana had mentioned double clicking to edit. What is the current status of this task? Is it something we could use and/or help contribute?

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 11 2022, 12:00 PM
Jdforrester-WMF removed a project: Epic.Jan 11 2022, 5:08 PM
Jdforrester-WMF moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.Jan 11 2022, 5:32 PM
RHo added a subscriber: bmartinezcalvo.Jan 17 2022, 11:24 AM
In T297271#7596153, @JKieserman wrote:

Hi @RHo! From the looks of it, https://phabricator.wikimedia.org/T280701 would work for us. It doesn't look the interactivity is defined on the ticket yet but @aishwaryavardhana had mentioned double clicking to edit. What is the current status of this task? Is it something we could use and/or help contribute?

Hi @JKieserman - sounds great if you could contribute to this component definition! I think the best folks to connect are those in the Design Systems team - and likely @bmartinezcalvo will collaborate with @aishwaryavardhana and others interested in a chip component to define and prioritise it.

DVrandecic closed this task as Resolved.Jan 18 2022, 5:24 PM
DVrandecic moved this task from In progress to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits