Maniphest T321934

E2E test for CUJ 3: Edit a function definition
Closed, ResolvedPublic
Actions

Assigned To

Nik.xyz.in

Authored By

	SDunlap
	Oct 28 2022, 7:11 PM

Description

Context
We currently have a suite of end-to-end (E2E) tests that run on every patch merge request. We'd like to add test cases for the 7 critical user journeys (CUJs).

User flow

Find a function from the Wikifunctions landing page
Navigate to the function page
Go to the edit page for this function
Get a clear idea of what fields allow for modification and which fields don’t
Modify the values of:
1. Function name,
2. Function aliases,
3. Input list
  1. Add/remove input fields
  2. Edit input type
  3. Edit input labels
4. Output type
Publish my updates
1. Visualize function definition successfully saved
2. IF ERROR: Visualize function saving errors in a clear way for me to correct and re-save

Hints

code location for tests: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/tests/selenium/
information on Selenium testing on MediaWiki: https://www.mediawiki.org/wiki/Selenium

Details

	Subject	Repo	Branch	Lines +/-
	ignore	mediawiki/extensions/WikiLambda	master	+270 -142

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	BUG REPORT	None	T344206 Special:MathStatus exception error on Wikifunctions
Resolved		Jdforrester-WMF	T342865 Post-creation work for wikifunctionswiki
Resolved		BTullis	T289316 Prepare and check storage layer for Wikifunctions.org (new public content wiki)
Resolved		Jdforrester-WMF	T275945 Create Wikifunctions.org
Resolved		Jdforrester-WMF	T299176 Phase Theta – Root task
Resolved		SDunlap	T294388 Run some full end-to-end browser integration tests on Beta Cluster Wikifunctions now it exists
Resolved		SDunlap	T276847 Write a suite of user experience end-to-end integration tests for WikiLambda in selenium/etc. sufficient for us to launch with
Resolved		Nik.xyz.in	T321934 E2E test for CUJ 3: Edit a function definition
Resolved		DVrandecic	T318933 CUJ 3: Edit a function definition
Resolved		DVrandecic	T318314 Function editor: Remove an item from the list of arguments
Resolved		• AdesojiThisDot	T318315 Function editor: Implement functionality of "remove input field" using the Mobile view button.
Resolved		Ddwaal	T318317 Function editor: Implement "remove input field" button for Desktop view
Resolved		AAlhazwani-WMF	T312121 The dropdown menu of the "output type" from the function definition page is hidden under another component
Resolved		None	T323805 Design: edit a function definition
Resolved		• aishwaryavardhana	T285418 A way to easily and intuitively create and edit functions
Resolved		• aishwaryavardhana	T285419 Initial user flow diagrams for function editor
Invalid		• aishwaryavardhana	T285421 Generative design research: Testing of new hypotheses and mental models
Declined		• SWoodruff-WMF	T285422 Function editor: User education, interface copy, notifications and alerts
Declined		• SWoodruff-WMF	T285684 As someone who is new to creating functions, I would like to be able to start with an easy task
Resolved		• aishwaryavardhana	T296693 Desktop designs for function editor v1
Resolved		• AdesojiThisDot	T297086 Function Editor - Sidebar - Language selector
Declined		• AdesojiThisDot	T298203 Provide an easy way on the front-end for Wikifunctions to know what languages are supported (and what their ZIDs are)
Resolved		SimoneThisDot	T297095 Function Editor - Function Definition - New component
Resolved		• JKieserman	T297098 Function Editor - Function definition - Heading
Resolved		• AdesojiThisDot	T297099 Function Editor - Enhance the "Object selector" to allow user to type within its first entry instead than the input itself to align with the designs
Resolved		SimoneThisDot	T297100 Function Editor - Create the function definition main content area
Resolved		• AdesojiThisDot	T297101 Function Editor - Allow user to add labels in another language in function definition
Resolved		• JKieserman	T297104 Function Editor - Provide the ability for users to publish, write implementation and cancel function
Resolved		• JKieserman	T297271 Function Editor - Create an Chip component
Resolved		• AdesojiThisDot	T297280 Function Editor - sidebar - Update diagram
Resolved		gengh	T297869 Function Editor: Allow user to REMOVE an Input from a function definition
Resolved		SimoneThisDot	T298464 Remove old function editor and its files
Resolved		• aishwaryavardhana	T296698 Provide a UX design for function viewing
Resolved		SimoneThisDot	T301518 Explore replacing the legacy function editor with fallback to the generic editor via a button, so that functions can be connected to implementations and testers and we can scrap the legacy function editor
Resolved		• aishwaryavardhana	T296694 Mobile designs for function editor v1
Resolved		• aishwaryavardhana	T296696 Provide a compelling, scalable, validated UX design for function creation and editing
Resolved		• aishwaryavardhana	T297458 User flow for when a user edits definition
Resolved		• aishwaryavardhana	T297462 User flow when a user only edits labels
Resolved		• aishwaryavardhana	T297463 User flow for how a user would complete multilingual edits
Resolved		None	T297464 Decide on the UX design for the edit summary
Resolved		• aishwaryavardhana	T297465 Design notes for if an input type is changed
Resolved		• aishwaryavardhana	T297466 Design notes for if an output type is changed
Resolved		• aishwaryavardhana	T297467 Decide on the UX design for attaching and detatching (but not editing) implementations and testers
Resolved		• aishwaryavardhana	T297668 Revisit user flows for function editor
Resolved		• SWoodruff-WMF	T318316 Function editor: Design function argument (input) delete button/icon for Desktop view.
Resolved		AAlhazwani-WMF	T320410 Design: Function editor, redefine separation between fields and blocks.
Resolved		AAlhazwani-WMF	T270304 Design a "Publish" component
Resolved		SimoneThisDot	T268296 Display to user why an object is not stored
Duplicate		None	T274424 Show errors if creation of ZObject fails
Resolved		DVrandecic	T316686 Copy: change text for confirmation dialog when creating a new function on mobile
Resolved		DVrandecic	T303336 Users can write an edit summary when publishing which can be seen by other users in histories
Resolved		DVrandecic	T299004 Have the publish function enable/disable itself only if there have been changes
Resolved		gengh	T326656 FunctionEditor: Implement separation between fields and blocks changes

Event Timeline

SDunlap created this task.Oct 28 2022, 7:11 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 28 2022, 7:11 PM

SDunlap removed SDunlap as the assignee of this task.Oct 28 2022, 7:11 PM

SDunlap triaged this task as High priority.

SDunlap added a project: good first task.

zeljkofilipin removed a project: User-zeljkofilipin.Oct 31 2022, 12:43 PM

Jdforrester-WMF moved this task from Incoming to Blocking launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Nov 2 2022, 10:31 PM

Jdforrester-WMF added a parent task: T318933: CUJ 3: Edit a function definition.Nov 28 2022, 7:09 PM

Jdforrester-WMF removed a parent task: T318933: CUJ 3: Edit a function definition.Jan 5 2023, 4:19 PM

Jdforrester-WMF added a subtask: T318933: CUJ 3: Edit a function definition.

DVrandecic closed subtask T318933: CUJ 3: Edit a function definition as Resolved.Jan 18 2023, 4:35 PM

SDunlap mentioned this in T328587: End-to-end test coverage for Abstract Wikipedia's Wikifunctions.Feb 1 2023, 6:25 PM

Started working on it

@SDunlap
There is lot of work already been done on this issue
can you let me know the current status of this task?

We probably want to finish T321933 before doing this one. @Teleosteen has a patch which is ~75% of the way there (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/868787), but I think he's gotten busy with other things, so he might be able to hand it off to you. We can chat about it on IRC.

It looks like T321933 has been completed and @Nik.xyz.in is working on T321935, T321937
Can I work on this task? @Nik.xyz.in @SDunlap

Hi and thank you for your interest! Please check thoroughly https://www.mediawiki.org/wiki/New_Developers (and all of its communication section!). The page covers how to get started, assigning tasks, task status, how to find a codebase, how to create patches, where to ask general development questions and where to get help with setup problems, and how to ask good questions. Thanks a lot! :)

@Appare45 thank you for your interest. Unless @Nik.xyz.in doesn't think he'll be able to get to it soon, I'd suggest picking up another unassigned task. If you're interested in the e2e tests specifically, you can check out: T321940. Another (unit) testing task is: T294826.