Page MenuHomePhabricator

E2E test for CUJ 3: Edit a function definition
Closed, ResolvedPublic

Description

Context
We currently have a suite of end-to-end (E2E) tests that run on every patch merge request. We'd like to add test cases for the 7 critical user journeys (CUJs).

User flow

  1. Find a function from the Wikifunctions landing page
  2. Navigate to the function page
  3. Go to the edit page for this function
  4. Get a clear idea of what fields allow for modification and which fields don’t
  5. Modify the values of:
    1. Function name,
    2. Function aliases,
    3. Input list
      1. Add/remove input fields
      2. Edit input type
      3. Edit input labels
    4. Output type
  6. Publish my updates
    1. Visualize function definition successfully saved
    2. IF ERROR: Visualize function saving errors in a clear way for me to correct and re-save

Hints

Related Objects

StatusSubtypeAssignedTask
OpenBUG REPORTNone
OpenNone
ResolvedBTullis
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedSDunlap
ResolvedSDunlap
ResolvedNik.xyz.in
ResolvedDVrandecic
ResolvedDVrandecic
Resolved AdesojiThisDot
ResolvedDdwaal
ResolvedAAlhazwani-WMF
ResolvedNone
Resolvedaishwaryavardhana
Resolvedaishwaryavardhana
Invalidaishwaryavardhana
DeclinedSWoodruff-WMF
DeclinedSWoodruff-WMF
Resolvedaishwaryavardhana
Resolved AdesojiThisDot
Declined AdesojiThisDot
ResolvedSimoneThisDot
Resolved JKieserman
Resolved AdesojiThisDot
ResolvedSimoneThisDot
Resolved AdesojiThisDot
Resolved JKieserman
Resolved JKieserman
Resolved AdesojiThisDot
Resolvedgengh
ResolvedSimoneThisDot
Resolvedaishwaryavardhana
ResolvedSimoneThisDot
Resolvedaishwaryavardhana
Resolvedaishwaryavardhana
Resolvedaishwaryavardhana
Resolvedaishwaryavardhana
Resolvedaishwaryavardhana
ResolvedNone
Resolvedaishwaryavardhana
Resolvedaishwaryavardhana
Resolvedaishwaryavardhana
Resolvedaishwaryavardhana
ResolvedSWoodruff-WMF
ResolvedAAlhazwani-WMF
ResolvedAAlhazwani-WMF
ResolvedSimoneThisDot
DuplicateNone
ResolvedDVrandecic
ResolvedDVrandecic
ResolvedDVrandecic
Resolvedgengh

Event Timeline

SDunlap triaged this task as High priority.
SDunlap added a project: good first task.

@SDunlap
There is lot of work already been done on this issue
can you let me know the current status of this task?

We probably want to finish T321933 before doing this one. @Teleosteen has a patch which is ~75% of the way there (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/868787), but I think he's gotten busy with other things, so he might be able to hand it off to you. We can chat about it on IRC.

It looks like T321933 has been completed and @Nik.xyz.in is working on T321935, T321937
Can I work on this task? @Nik.xyz.in @SDunlap

Hi and thank you for your interest! Please check thoroughly https://www.mediawiki.org/wiki/New_Developers (and all of its communication section!). The page covers how to get started, assigning tasks, task status, how to find a codebase, how to create patches, where to ask general development questions and where to get help with setup problems, and how to ask good questions. Thanks a lot! :)

@Appare45 thank you for your interest. Unless @Nik.xyz.in doesn't think he'll be able to get to it soon, I'd suggest picking up another unassigned task. If you're interested in the e2e tests specifically, you can check out: T321940. Another (unit) testing task is: T294826.

Change 931915 had a related patch set uploaded (by Nik.xyz.in; author: Nik.xyz.in):

[mediawiki/extensions/WikiLambda@master] e2e: Make function tests sync with other tests

https://gerrit.wikimedia.org/r/931915

Change 936810 had a related patch set uploaded (by Nik.xyz.in; author: Nik.xyz.in):

[mediawiki/extensions/WikiLambda@master] e2e: Make function tests sync with other tests

https://gerrit.wikimedia.org/r/936810

Change 931915 abandoned by Nik.xyz.in:

[mediawiki/extensions/WikiLambda@master] e2e: Make function tests sync with other tests

Reason:

https://gerrit.wikimedia.org/r/931915

Change 936810 abandoned by Nik.xyz.in:

[mediawiki/extensions/WikiLambda@master] ignore

Reason:

https://gerrit.wikimedia.org/r/936810

Change 931915 restored by Nik.xyz.in:

[mediawiki/extensions/WikiLambda@master] e2e: Make function tests sync with other tests

https://gerrit.wikimedia.org/r/931915