Page MenuHomePhabricator

Card: Add the "portrait" orientation
Open, LowPublic

Description

Background goal

The MVP of the Card component T256036: Add Card component to Codex included just the default landscape orientation. This task covers adding the portrait orientation:

image.png (904×850 px, 63 KB)

User stories

add at least one user story

Previous implementations

Design spec

Once a component spec sheet has been created in Figma, remove the note stating that the spec is missing and link to the spec below.

Component spec sheet

Open questions

  • Do we really need a portrait version with the icon on top, or can we unify it with the landscape card with the icon next to the text?
    Captura de pantalla 2024-01-18 a las 17.31.31.png (348×1 px, 32 KB)

Acceptance criteria (or Done)

Design

  • Design the Figma spec sheet and add it in this task
  • Update the component in the Figma library. This step will be done by a DST member.
  • Update the Card Guidelines in Codex, including recommendations on when to use each Landscape or Portrait Card

Code

  • Implement the component in Codex

Event Timeline

DAbad subscribed.

pulling into this sprint after MVP discussion

My apologies for not sharing earlier. Card's portrait mode designs are available in this new version of the Card exploration file in Figma.

While working on this version, I realized that, rather than thumbnails, portrait cards should probably use a different component: Image. Thumbnails should be reserved to provide small content previews, and they don't need to be adjusted to specific aspect ratios (such as 16:9, in this case). I would like to collect opinions and concerns, technical or otherwise, related to this approach: Should we create a new Image component? Should Thumbnail remain separate or exist as a (smaller) variant of Image?

Status update: Initial specs are ready, but there are some questions that should be discussed with the team in order to proceed, like the need to create an image component and the relationship of that element with Thumbnail.

ldelench_wmf changed the task status from Open to Stalled.Aug 29 2022, 3:28 PM
ldelench_wmf moved this task from Inbox to Needs Refinement on the Design-System-Team board.

Assuming we still want to do this as part of T278311, leaving in Needs Refinement.

egardner raised the priority of this task from Medium to Needs Triage.Oct 2 2023, 9:15 PM
egardner moved this task from Needs Refinement to Backlog on the Design-System-Team board.

In the context of using the machine translation form MinT to support Wikipedia readers (T359072), we are considering to use the portrait orientation of the card component.

The context is the following, the user has selected an article to read an automatic translation (e.g., translating the Moon from English to Korean). Although the user selection is the main option to proceed, we want to surface articles in the target Wikipedia that may already exist on the selected topic (to enable the user to access the human-created content instead). In this context, we want to represent the selected article in a visually prominent way with enough text translated from the article (for which the portrait version of the card seems a great fit), while the alternative can be presented in a less prominent way (using a card in landscape version).

This scenario is illustrated below in a mockup:

MinT Selected Topic.png (871×320 px, 97 KB)

Thanks for sharing this use case @Pginer-WMF! What is the timeline for the MVP (T359072)? Design-System-Team is currently focused on a number of different work streams and it may take a bit of time to get to this. Would the Language team be open to upstreaming this change into Codex? I believe the engineers are already comfortable with Vue, so there might not be as much of a learning curve required.

Thanks for sharing this use case @Pginer-WMF! What is the timeline for the MVP (T359072)? Design-System-Team is currently focused on a number of different work streams and it may take a bit of time to get to this. Would the Language team be open to upstreaming this change into Codex? I believe the engineers are already comfortable with Vue, so there might not be as much of a learning curve required.

We want to make progress on the MinT for Wikipedia Readers MVP (T359072) during this fiscal year. I think it can be a good opportunity for the Language team to upstream a change to Codex. I guess we can use the landscape version as a temporary solution while the upstream version is built by the Language team. Some guidance and review may still be needed from the Design Systems team, but having a temporary solution may provide some more flexibility.

Queuing for refinement given the recent need in real use cases.

CCiufo-WMF changed the task status from Stalled to Open.Nov 8 2024, 4:17 PM
CCiufo-WMF removed subscribers: DAbad, STH, Sarai-WMDE.