Page MenuHomePhabricator

Ensure UserGroupManager::addUserToGroup is not called on temporary users from Wikibase extension
Closed, ResolvedPublic2 Estimated Story Points

Description

Following T340470, Ensure that UserGroupManager::addUserToGroup is not called on temporary users in Wikibase extension
Link to code search where calls are made can be found here

Related Objects

StatusSubtypeAssignedTask
In ProgressNiharika
OpenNone
OpenTchanders
OpenNone
ResolvedSTran
ResolvedUmherirrender
Resolved AGueyte
Duplicate AGueyte
ResolvedSTran
ResolvedDreamy_Jazz
OpenSTran
OpenSTran
OpenSTran
ResolvedSTran
ResolvedSTran
Resolvedkostajh
OpenNone
OpenNone
OpenSTran
ResolvedSTran
ResolvedBUG REPORTDreamy_Jazz
OpenNone
Resolved TThoabala
Resolved TThoabala
Resolved TThoabala
Resolved AGueyte
ResolvedBUG REPORT AGueyte
ResolvedBUG REPORT AGueyte
Resolved AGueyte
Resolved AGueyte
ResolvedCyndymediawiksim
DuplicateNone
OpenNone
ResolvedTchanders
Resolved TThoabala
Resolved TThoabala

Event Timeline

All calls on this seem to only be coming from tests(see code search link above).

In
tests/phpunit/includes/Api/PermissionsTestCase.php

foreach ( $groups as $group ) {
				$userGroupManager->addUserToGroup( $this->user, $group );
			}
		}
		// reset rights cache
		$userGroupManager->addUserToGroup( $this->user, "dummy" );
		$userGroupManager->removeUserFromGroup( $this->user, "dummy" );

tests/phpunit/includes/Api/SetAliasesTest.php

// Make sure our user is no longer allowed to edit terms.
		$services->getUserGroupManager()->removeUserFromGroup( $user, 'all-permission' );
		$services->getUserGroupManager()->addUserToGroup( $user, 'no-permission' );
		$services->getPermissionManager()->invalidateUsersRightsCache( $user );

and in

tests/phpunit/includes/MediaWikiEditEntityTest.php

foreach ( $add as $group ) {
			$userGroupManager->addUserToGroup( $user, $group );
		}
	}

I think Its safe skip this extension.