Page MenuHomePhabricator

Parsoid needs to run findVariantLink or some equivalent thing
Closed, ResolvedPublic

Description

Symptom:

[[zh:User:Liangent/parsoid-bug]] this page:

PHP parser links it to User:Liangent/parsoid测试
https://zh.wikipedia.org/wiki/User:Liangent/parsoid-bug?action=render

while Parsoid links it to User:Liangent/parsoid測試
http://parsoid.wmflabs.org/zh/User:Liangent/parsoid-bug


Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:44 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz51587.
Arlolra set Security to None.
Aklapper subscribed.

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

Arlolra subscribed.

Well, the patches there say,

Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

so it doesn't look like the functionality is being removed, just refactored. The issue in the description is still present.

Change 738019 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/services/parsoid@master] Implement basic variant link resolution

https://gerrit.wikimedia.org/r/738019

Change #738019 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Implement basic variant link resolution

https://gerrit.wikimedia.org/r/738019

Change #1032723 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/services/parsoid@master] Disable Chinese language conversion for variant link resolution

https://gerrit.wikimedia.org/r/1032723

Change #1032723 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Disable Chinese language conversion for variant link resolution

https://gerrit.wikimedia.org/r/1032723

Change #1034127 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a5

https://gerrit.wikimedia.org/r/1034127

Change #1034127 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a5

https://gerrit.wikimedia.org/r/1034127

ABreault-WMF subscribed.

The general issue of variant link resolution is resolved in T53587#9772479 but conversion is disabled for zhwiki in Parsoid. That's covered by T204969