Page MenuHomePhabricator
Create Task
Maniphest T612

Landing a patch with arc currently will sometimes strip author information
Closed, InvalidPublic
Actions

Description

In T127#1793, @flimport wrote:

milimetric wrote on 2014-04-25 19:40:22 (UTC)

As far as I can see, the process of landing a patch with arc currently will sometimes strip author information: https://secure.phabricator.com/T4333.

Can someone provide reproducible steps in http://phab-01.wmflabs.org , please?

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedDzahnT123525 reduce amount of remaining Ubuntu 12.04 (precise) systems in production
 Resolved• CmjohnsonT138978 decom antimony (datacenter)
 ResolvedDzahnT123718 Phase out antimony.wikimedia.org (git.wikimedia.org / gitblit)
 ResolvedDanny_BT138986 Archive #Gitblit-Deprecate
 ResolvedPaladoxT137353 Update all on-wiki references to git.wikimedia.org and replace them with the Phabricator equivalent
 OpenDzahnT323073 Make https://git.wikimedia.org not redirect to Phabricator Diffusion
 Resolved• demonT111465 [keyresult] Deprecate gitblit in favor of Diffusion
 Resolved• demonT752 Use Diffusion as canonical location for browsing code repos (not gitblit)
 ResolvedPaladoxT108864 Update mediawiki.org templates to link to Diffusion, not gitblit
 ResolvedNemo_bisT101358 Update {{git file}} to link to diffusion
 Resolved• demonT110607 redirect gerrit repo paths to diffusion callsigns
 ResolvedPaladoxT111887 Diffusion replacement for tarfile download from git.wikimedia.org
 ResolvedKrenairT122674 Make all /r/project/* paths in phabricator accessible without login
 Resolved• mmodellT129447 Diffusion redirect from name to callsign doesn't always work
 InvalidNoneT135336 Update Module:Callsigns in mediawiki.org
 DeclinedNoneT76788 ExtensionDistributor should use Phabricator/Diffusion instead of Gerrit
 Resolved• demonT616 Import all gerrit.wikimedia.org repositories with Diffusion
 InvalidNoneT98348 Implement the Wikimedia Foundation Call to Action 2015
 InvalidNoneT98358 WMF to integrate, consolidate, and pause or stop stalled initiatives
 ResolvedQgilT553 Engineering Community team goals for October 2014
 DeclinedNoneT617 Provide static dump of Gerrit
 DuplicateNoneT18 Plan to migrate code review from Gerrit to Phabricator
 ResolvedgregT597 Identify Arcanist showstoppers for wikimedians
 InvalidgregT612 Landing a patch with arc currently will sometimes strip author information

Event Timeline

Qgil created this task.Oct 10 2014, 8:19 AM
Qgil raised the priority of this task from to Medium.
Qgil updated the task description. (Show Details)
Qgil added projects: Gerrit-Migration, Phabricator (Upstream).
Qgil changed Security from none to None.
Qgil added subscribers: Qgil, Milimetric.
Qgil mentioned this in T127: Find way to use Differential with plain git (i.e.: without requiring arc).Oct 10 2014, 9:10 AM
Qgil moved this task from To Triage to Need Discussion on the Gerrit-Migration board.Oct 10 2014, 9:18 AM
Qgil mentioned this in T597: Identify Arcanist showstoppers for wikimedians.Oct 10 2014, 11:54 AM
• mmodell subscribed.Oct 11 2014, 5:57 AM

Upstream seems to be suggesting that it's mostly resolved and they don't even know how to reproduce the problem.

@Milimetric do you have an example of when this happens?

• Mattflaschen-WMF subscribed.Nov 7 2014, 4:59 AM
Qgil lowered the priority of this task from Medium to Low.Nov 27 2014, 7:57 AM

Currently #Code-Review is in the queue of Phabricator subprojects after Project-Management and Gitblit-Deprecate. If someone wants to work on this task, take it and assign the priority accordingly.

Nemo_bis moved this task from Backlog to Wikimedia requests on the Phabricator (Upstream) board.Nov 28 2014, 7:09 PM
Qgil moved this task from Wikimedia requests to Upstreamed on the Phabricator (Upstream) board.Dec 16 2014, 12:27 PM
Qgil removed a project: Phabricator (Upstream).Feb 4 2015, 8:20 PM
JanZerebecki subscribed.Mar 3 2015, 6:02 PM
JanZerebecki mentioned this in T91420: git commit hash remains the same from submitting to after merge.Mar 3 2015, 6:18 PM
• mmodell added a comment.May 1 2015, 5:05 AM

I don't think this actually happens, nobody has provided any steps to reproduce, and upstream hasn't ran into it.

• Mattflaschen-WMF unsubscribed.May 5 2015, 12:50 AM
greg closed this task as Invalid.May 24 2015, 8:43 AM
greg claimed this task.
greg subscribed.

No update in over a year on a test case. Closing.

greg moved this task from Need Discussion to Done/Archive on the Gerrit-Migration board.Sep 24 2015, 11:34 PM
Restricted Application added a project: User-greg. · View Herald TranscriptSep 24 2015, 11:34 PM
greg moved this task from Backlog to Done on the User-greg board.Sep 24 2015, 11:37 PM
• demon subscribed.Nov 13 2015, 6:30 PM
In T612#1251388, @mmodell wrote:

I don't think this actually happens, nobody has provided any steps to reproduce, and upstream hasn't ran into it.

This did happen, a lot. It's been fixed though :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL